Add Windows platform TLS verifier for TURN#50
Open
nickprice101 wants to merge 1 commit intoWonderInventions:developfrom
Open
Add Windows platform TLS verifier for TURN#50nickprice101 wants to merge 1 commit intoWonderInventions:developfrom
nickprice101 wants to merge 1 commit intoWonderInventions:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR ports the addon forward to a newer libwebrtc baseline and adds a Windows platform certificate verifier for secure TURN/TLS connections.
Key pieces:
SSLCertificateVerifierWhy
The failing TURN-over-TLS path reproduced as:
unable to get local issuer certificateOn the same machine and credentials, plain
turn:3478succeeded, including the401challenge and subsequent successful ALLOCATE.That showed the breakage was in the native TLS validation path, not TURN auth.
This change lets the Windows addon validate TURN/TLS chains against the platform trust store instead of failing in the built-in verification path.
Validation
wrtc.nodesuccessfully on Windows against the newer libwebrtc treeturns:443now completes TLS, sends ALLOCATE, and gathers a relay candidateturn:3478still succeeds