Repository navigation
Keep the footer subscribe field readable for logged-in users - #3695
Open
muneeb-ashraf wants to merge 1 commit into
Open
muneeb-ashraf wants to merge 1 commit into
muneeb-ashraf wants to merge 1 commit into
Conversation
Jetpack prefills the email field for logged-in users and disables it. Its disabled styles use currentcolor at half opacity, which renders as an empty grey box with invisible text in Learn's dark footer. Restore the form text color and full opacity, with the light background used for read-only fields. Fixes WordPress#3525. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6LxjEQnP4PPgXXvAM3M2F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3525.
What
For logged-in users, the Jetpack Subscriptions block in the footer prefills the email field with the account email and disables it. Jetpack's inline block CSS then applies this rule:
In Learn's dark footer,
currentcoloris white, so the field becomes white text on a white box at half opacity. That reads as an empty grey bar with no placeholder and no visible email, which is what the issue describes.This adds a rule in
src/style/_jetpack.scssfor the disabled state only. It restores the form text color and full opacity, and uses the light form background (--wp--custom--form--search--color--background) so the field still reads as not editable. The logged-out field is unchanged.Testing
On https://learn.wordpress.org/ while logged in, I injected the compiled rule through DevTools and checked the computed styles of the footer email field:
rgb(255, 255, 255)0.5rgb(30, 30, 30)1rgb(246, 246, 246)With the rule, the prefilled email is legible next to the Subscribe button. The placeholder rule that shares Jetpack's selector list still applies as before for logged-out visitors.
I ran stylelint on the file with the wporg-repo-tools config. The only error is the existing line 3, whose disable comment still uses the old
max-line-lengthrule name. I didn't touch it here.I didn't attach screenshots because the logged-in state shows my account email. To check after deploy, log in and look at the "Sign up for updates" field in the footer.
AI assistance
🤖 Generated with Claude Code
https://claude.ai/code/session_01W6LxjEQnP4PPgXXvAM3M2F