[AST] Support INSERT/REPLACE without INTO and MySQL priority modifiers#343
Open
wp-fuse wants to merge 1 commit intoWordPress:trunkfrom
Open
[AST] Support INSERT/REPLACE without INTO and MySQL priority modifiers#343wp-fuse wants to merge 1 commit intoWordPress:trunkfrom
wp-fuse wants to merge 1 commit intoWordPress:trunkfrom
Conversation
517eca6 to
7f869ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective: Enhance the AST driver to support MySQL INSERT and REPLACE statements that omit the INTO keyword, and safely handle MySQL-specific priority modifiers that are unsupported in SQLite.
Changes:
Implemented robust INTO keyword injection in execute_insert_or_replace_statement.
Added logic to automatically skip unsupported MySQL priority modifiers (LOW_PRIORITY, HIGH_PRIORITY, DELAYED) which trigger syntax errors in SQLite.
Ensured that INTO is injected at the correct position relative to survive modifiers like OR IGNORE (translated from MySQL IGNORE).
Added semantic check to only apply OR IGNORE transformation on INSERT statements, not REPLACE.
Fixed a potential syntax issue in array_splice for better cross-version PHP compatibility.
Verification:
Validated via unit tests including simple INSERT without INTO, INSERT IGNORE without INTO, and INSERT LOW_PRIORITY ohne INTO.
All tests passing with WP_SQLITE_AST_DRIVER enabled.
Coding standards (CS) validated and fixed.