Update compiler options to meet binskim requirements#9699
Merged
stsoe merged 2 commits intoXilinx:masterfrom Apr 1, 2026
Merged
Update compiler options to meet binskim requirements#9699stsoe merged 2 commits intoXilinx:masterfrom
stsoe merged 2 commits intoXilinx:masterfrom
Conversation
To fix BA2028 and BA6002, use /guard:cast /d2CastGuardFailureMode:fastfail /GL and /GF compiler option. Tested successful build locally.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Update the comment for better explantation
Collaborator
|
Interesting, have you tried manually in XRT-MCDM, so that we get no surprises when updating XRT submodule later? |
stsoe
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
To fix binskim BA2028 and BA6002.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
Use
/guard:cast/d2CastGuardFailureMode:fastfail/GLand/GFcompiler option.Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Tested successful build locally.
Documentation impact (if any)
None