Skip to content

refactor(spec): move v0.9 and v0.9.1 catalogs to catalogs/ (#2700) - #4150

Merged
josemontespg merged 1 commit into
mainfrom
move-v0-9-basic-catalogs
Nov 17, 2026
Merged

josemontespg merged 1 commit into
mainfrom
move-v0-9-basic-catalogs

Conversation

@josemontespg

@josemontespg josemontespg commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Moves the v0.9 and v0.9.1 basic catalogs (along with their implementation guides) and the v0.9 minimal catalog out of specification/ into catalogs/basic/{v0_9,v0_9_1}/ and catalogs/minimal/v0_9/, so every maintained catalog lives under the top-level catalogs/ directory while specification/ holds protocol schemas and documentation.

Catalog $id and catalogId URIs remain unchanged (https://a2ui.org/specification/<version>/catalogs/...), and docs/site/scripts/prepare-spec-assets.mjs and scripts/docs_site_preview.mjs stage the moved schemas and examples back under specification/<version>/catalogs/ so published schema URLs continue to resolve on a2ui.org.

Fixes #2700

Changes

  • Move specification/v0_9/catalogs/basic/ and specification/v0_9/docs/basic_catalog_implementation_guide.md to catalogs/basic/v0_9/, specification/v0_9_1/catalogs/basic/ and specification/v0_9_1/docs/basic_catalog_implementation_guide.md to catalogs/basic/v0_9_1/, and specification/v0_9/catalogs/minimal/ to catalogs/minimal/v0_9/.
  • Update catalogs/README.md, AGENTS.md, and Starlight spec-schemas.mjs / prepare-spec-assets.mjs / scripts/docs_site_preview.mjs to publish the moved catalogs at their existing $id URLs.
  • Point specification/scripts/validate.py, specification/v0_9(_1)/test/run_tests.py, and the conformance suites (conformance/core/*.yaml, conformance/adapter/adapter_conformance_v0_9.yaml, conformance/e2e/v0_9_1/*.yaml, conformance/test_data/node/*.yaml) at the new paths.
  • Update repository path references and symlinked example directories across typescript/, python/, eval/ (preserving legacy path mapping in _MOVED_CATALOG_PREFIXES for encrypted datasets), dart/, swift/, kotlin/, samples/, and tools/.

Verification

  • Ran python3 specification/scripts/validate.py, specification/v0_9/test/run_tests.py, specification/v0_9_1/test/run_tests.py, and uv run pytest across Python, conformance, E2E scenarios, eval, and documentation example validators.
  • Built all TypeScript workspaces and ran unit, conformance, E2E scenario, and explorer Karma suites across @a2ui/web_core, @a2ui/agent, @a2ui/lit, @a2ui/angular, @a2ui/react, kotlin/agent_sdk_legacy, ./scripts/fix_format.sh --check, and ./scripts/fix_licenses.py --check (Dart and Swift suites run in CI).

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Docs Site Preview Removed

The preview for PR #4150 has been cleaned up because the pull request is closed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the repository layout by moving the pre-1.0 basic and minimal catalogs (v0.9 and v0.9.1) out of the versioned specification subdirectories and into the top-level catalogs directory, updating all references, scripts, documentation, and tests across multiple languages. The review feedback identifies two key areas for improvement: ensuring robust path resolution in codegen_pydantic.py by using os.path.normpath to handle potential trailing slashes, and replacing fragile substring checks in the Python conformance tests with a more robust path resolution helper.

@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from 220864d to 0adf0cd Compare November 11, 2026 00:09
github-actions Bot added a commit that referenced this pull request Nov 11, 2026
@josemontespg
josemontespg force-pushed the kotlin-decouple-basic-catalog-ids branch from fae1d8f to fed0264 Compare November 14, 2026 00:38
@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from 0adf0cd to ee93fda Compare November 14, 2026 00:38
github-actions Bot added a commit that referenced this pull request Nov 14, 2026
@josemontespg josemontespg added the skip-changelog-check Use for noop PRs to skip CHANGELOG updates. label Nov 14, 2026
@josemontespg
josemontespg marked this pull request as ready for review November 16, 2026 18:58
@josemontespg josemontespg removed the skip-changelog-check Use for noop PRs to skip CHANGELOG updates. label Nov 16, 2026
@josemontespg
josemontespg force-pushed the kotlin-decouple-basic-catalog-ids branch from fed0264 to 2eb3ca3 Compare November 16, 2026 23:14
@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from ee93fda to c3a3b4a Compare November 16, 2026 23:14
github-actions Bot added a commit that referenced this pull request Nov 16, 2026
@josemontespg
josemontespg force-pushed the kotlin-decouple-basic-catalog-ids branch from 2eb3ca3 to d180eb2 Compare November 16, 2026 23:26
@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from c3a3b4a to 482a0f2 Compare November 16, 2026 23:26
github-actions Bot added a commit that referenced this pull request Nov 16, 2026
Base automatically changed from kotlin-decouple-basic-catalog-ids to main November 16, 2026 23:40
@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from 482a0f2 to 071bdc5 Compare November 16, 2026 23:40
@josemontespg
josemontespg removed this pull request from stack #4151 November 16, 2026 23:41
github-actions Bot added a commit that referenced this pull request Nov 16, 2026

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change relocates the v0.9 and v0.9.1 basic catalogs (catalog.json, examples/, rules.txt, and basic_catalog_implementation_guide.md) and the v0.9 minimal catalog (catalog.json, examples/, and README.md) from specification/ into catalogs/basic/{v0_9,v0_9_1}/ and catalogs/minimal/v0_9/. It updates paths across conformance suites, multi-language SDKs, eval dataset loaders, and docs asset scripts while preserving canonical $id URLs on a2ui.org.

The relocation is well executed overall, with one high-severity link resolution regression in docs/site/src/lib/spec-schemas.mjs (resolveSchemaExplorerUrl returns null for catalogs/basic/v0_9/catalog.json) and two medium issues in conformance/conformance_harness_implementation_guide.md and typescript/renderers/angular/a2ui_explorer/scripts/generate-examples.mjs. Active flags: --panel (--focus deletion-and-consolidation folded into rev-a as Focus Priority).

🤖 Agent-generated

Comment thread docs/site/src/lib/spec-schemas.mjs Resolved
@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from 071bdc5 to fee6b51 Compare November 17, 2026 02:02
github-actions Bot added a commit that referenced this pull request Nov 17, 2026

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset relocates the v0.9 and v0.9.1 basic catalogs (catalog.json, examples/, rules.txt, and basic_catalog_implementation_guide.md) and the v0.9 minimal catalog (README.md, catalog.json, and examples/) out of specification/v0_9/ and specification/v0_9_1/ into catalogs/basic/v0_9/, catalogs/basic/v0_9_1/, and catalogs/minimal/v0_9/. It updates path references across conformance suites, multi-language SDKs and code generators, developer tools, evaluation dataset loaders, and docs site asset staging while preserving canonical https://a2ui.org/specification/... $id URIs.

All five prior review threads (on codegen_pydantic.py, test_conformance.py, spec-schemas.mjs, Angular generate-examples.mjs, and conformance_harness_implementation_guide.md) are addressed at HEAD (fee6b518). Panel review (--panel, --focus deletion-and-consolidation (auto) folded into rev-a as Focus Priority) found one low documentation inconsistency in typescript/renderers/lit/a2ui_explorer/README.md and four untouched downstream docs needing follow-up updates. Citation audit: 0 critical/high checked (none reported).

🤖 Agent-generated

@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from fee6b51 to a50443a Compare November 17, 2026 20:39
github-actions Bot added a commit that referenced this pull request Nov 17, 2026
@josemontespg
josemontespg force-pushed the move-v0-9-basic-catalogs branch from a50443a to 2e9b060 Compare November 17, 2026 22:06
github-actions Bot added a commit that referenced this pull request Nov 17, 2026
@josemontespg
josemontespg merged commit 7fae1b7 into main Nov 17, 2026
71 of 77 checks passed
@josemontespg
josemontespg deleted the move-v0-9-basic-catalogs branch November 17, 2026 23:21
github-actions Bot added a commit that referenced this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move v0.9 / v0.9.1 basic catalogs from specification/ to catalogs/

2 participants