Repository navigation
refactor(spec): move v0.9 and v0.9.1 catalogs to catalogs/ (#2700) - #4150
Conversation
🧹 Docs Site Preview RemovedThe preview for PR #4150 has been cleaned up because the pull request is closed. |
There was a problem hiding this comment.
Code Review
This pull request reorganizes the repository layout by moving the pre-1.0 basic and minimal catalogs (v0.9 and v0.9.1) out of the versioned specification subdirectories and into the top-level catalogs directory, updating all references, scripts, documentation, and tests across multiple languages. The review feedback identifies two key areas for improvement: ensuring robust path resolution in codegen_pydantic.py by using os.path.normpath to handle potential trailing slashes, and replacing fragile substring checks in the Python conformance tests with a more robust path resolution helper.
220864d to
0adf0cd
Compare
fae1d8f to
fed0264
Compare
0adf0cd to
ee93fda
Compare
fed0264 to
2eb3ca3
Compare
ee93fda to
c3a3b4a
Compare
2eb3ca3 to
d180eb2
Compare
c3a3b4a to
482a0f2
Compare
482a0f2 to
071bdc5
Compare
gspencergoog
left a comment
There was a problem hiding this comment.
This change relocates the v0.9 and v0.9.1 basic catalogs (catalog.json, examples/, rules.txt, and basic_catalog_implementation_guide.md) and the v0.9 minimal catalog (catalog.json, examples/, and README.md) from specification/ into catalogs/basic/{v0_9,v0_9_1}/ and catalogs/minimal/v0_9/. It updates paths across conformance suites, multi-language SDKs, eval dataset loaders, and docs asset scripts while preserving canonical $id URLs on a2ui.org.
The relocation is well executed overall, with one high-severity link resolution regression in docs/site/src/lib/spec-schemas.mjs (resolveSchemaExplorerUrl returns null for catalogs/basic/v0_9/catalog.json) and two medium issues in conformance/conformance_harness_implementation_guide.md and typescript/renderers/angular/a2ui_explorer/scripts/generate-examples.mjs. Active flags: --panel (--focus deletion-and-consolidation folded into rev-a as Focus Priority).
🤖 Agent-generated
071bdc5 to
fee6b51
Compare
gspencergoog
left a comment
There was a problem hiding this comment.
This changeset relocates the v0.9 and v0.9.1 basic catalogs (catalog.json, examples/, rules.txt, and basic_catalog_implementation_guide.md) and the v0.9 minimal catalog (README.md, catalog.json, and examples/) out of specification/v0_9/ and specification/v0_9_1/ into catalogs/basic/v0_9/, catalogs/basic/v0_9_1/, and catalogs/minimal/v0_9/. It updates path references across conformance suites, multi-language SDKs and code generators, developer tools, evaluation dataset loaders, and docs site asset staging while preserving canonical https://a2ui.org/specification/... $id URIs.
All five prior review threads (on codegen_pydantic.py, test_conformance.py, spec-schemas.mjs, Angular generate-examples.mjs, and conformance_harness_implementation_guide.md) are addressed at HEAD (fee6b518). Panel review (--panel, --focus deletion-and-consolidation (auto) folded into rev-a as Focus Priority) found one low documentation inconsistency in typescript/renderers/lit/a2ui_explorer/README.md and four untouched downstream docs needing follow-up updates. Citation audit: 0 critical/high checked (none reported).
🤖 Agent-generated
fee6b51 to
a50443a
Compare
a50443a to
2e9b060
Compare
Summary
Moves the
v0.9andv0.9.1basic catalogs (along with their implementation guides) and thev0.9minimal catalog out ofspecification/intocatalogs/basic/{v0_9,v0_9_1}/andcatalogs/minimal/v0_9/, so every maintained catalog lives under the top-levelcatalogs/directory whilespecification/holds protocol schemas and documentation.Catalog
$idandcatalogIdURIs remain unchanged (https://a2ui.org/specification/<version>/catalogs/...), anddocs/site/scripts/prepare-spec-assets.mjsandscripts/docs_site_preview.mjsstage the moved schemas and examples back underspecification/<version>/catalogs/so published schema URLs continue to resolve ona2ui.org.Fixes #2700
Changes
specification/v0_9/catalogs/basic/andspecification/v0_9/docs/basic_catalog_implementation_guide.mdtocatalogs/basic/v0_9/,specification/v0_9_1/catalogs/basic/andspecification/v0_9_1/docs/basic_catalog_implementation_guide.mdtocatalogs/basic/v0_9_1/, andspecification/v0_9/catalogs/minimal/tocatalogs/minimal/v0_9/.catalogs/README.md,AGENTS.md, and Starlightspec-schemas.mjs/prepare-spec-assets.mjs/scripts/docs_site_preview.mjsto publish the moved catalogs at their existing$idURLs.specification/scripts/validate.py,specification/v0_9(_1)/test/run_tests.py, and the conformance suites (conformance/core/*.yaml,conformance/adapter/adapter_conformance_v0_9.yaml,conformance/e2e/v0_9_1/*.yaml,conformance/test_data/node/*.yaml) at the new paths.typescript/,python/,eval/(preserving legacy path mapping in_MOVED_CATALOG_PREFIXESfor encrypted datasets),dart/,swift/,kotlin/,samples/, andtools/.Verification
python3 specification/scripts/validate.py,specification/v0_9/test/run_tests.py,specification/v0_9_1/test/run_tests.py, anduv run pytestacross Python, conformance, E2E scenarios, eval, and documentation example validators.@a2ui/web_core,@a2ui/agent,@a2ui/lit,@a2ui/angular,@a2ui/react,kotlin/agent_sdk_legacy,./scripts/fix_format.sh --check, and./scripts/fix_licenses.py --check(Dart and Swift suites run in CI).