Repository navigation
fix(web_core,angular): remove non-spec @path ChildList template fallbacks - #4274
Merged
gspencergoog merged 2 commits intoNov 18, 2026
Conversation
…acks Remove '@path' fallbacks from ChildList template handling across GenericBinder, isTemplateRefObject, analyzeJsonChildRefProperty, and Angular's ComponentBinder so template resolution and reference extraction require plain 'path' as defined in specification/v1_0/json/common_types.json. Add v1.0 ChildList template conformance cases in common_types.yaml and validator_v1_0.yaml rejecting '@path' on template objects.
Contributor
There was a problem hiding this comment.
Code Review
This pull request enforces strict compliance with the v1.0 specification by restricting ChildList template properties to use only the plain path key (e.g., {componentId, path}) and removing support for the non-standard @path key. This breaking change is implemented across schema validation, reference mapping, binder logic, integrity checks, and the Angular renderer, with comprehensive conformance and unit tests added to verify the new behavior. I have no additional feedback to provide as there are no review comments.
gspencergoog
marked this pull request as ready for review
November 17, 2026 18:32
josemontespg
approved these changes
Nov 17, 2026
josemontespg
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Checked against specification/v1_0/json/common_types.json, the Angular CHANGELOG breaking-change entry, and the unit and conformance tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes non-specification
'@path'fallbacks fromChildListtemplate handling in@a2ui/web_coreand@a2ui/angular. Also adds v1.0 conformance coverage verifying thatChildListtemplates require plain"path"and reject"@path".In protocol v1.0,
DataBindingmoved to"@path", whileChildListtemplate objects kept plain"path"({"componentId": "...", "path": "..."}withadditionalProperties: falseinspecification/v1_0/json/common_types.json). Removing these fallbacks aligns TypeScript and Angular runtime binding and reference extraction with the protocol specification and with Dart, Swift, and Python.Changes
'@path'fallback fromGenericBinder.bindStructuralTemplateintypescript/core/web_core/src/resolution/generic-binder.ts.'@path'template-shape checks fromisTemplateRefObjectintypescript/core/web_core/src/resolution/ref-fields.ts,analyzeJsonChildRefPropertyintypescript/core/web_core/src/catalog/reference-map.ts, andextractPointersintypescript/core/web_core/src/validation/integrity-checker.ts.'@path'fallback fromComponentBinder.extractNodeTemplateandisChildListTemplateObjectintypescript/renderers/angular/src/core/component-binder.service.ts, and document the change intypescript/renderers/angular/CHANGELOG.md.test_v10_child_list_is_ids_or_templateinconformance/core/common_types.yamlandtest_v10_child_list_template_rejects_at_path_errorinconformance/core/validator_v1_0.yaml.typescript/core/web_core/src/validation/integrity-checker.test.tsand add unit tests intypescript/core/web_core/src/resolution/generic-binder.test.tsandtypescript/renderers/angular/src/core/component-binder.service.spec.ts.Impact & Risks
@a2ui/angular,ComponentBinder.bindNodeno longer populatesBoundProperty.templatefrom unvalidated{componentId, '@path'}objects (BREAKING CHANGEnoted intypescript/renderers/angular/CHANGELOG.md). Standard schema validation already rejected{componentId, '@path'}againstspecification/v1_0/json/common_types.json.@a2ui/web_core, the'@path'template fallbacks were added after0.15.0and have not been published in a release.Testing
@a2ui/web_core:yarn workspace @a2ui/web_core build && yarn workspace @a2ui/web_core lint && yarn workspace @a2ui/web_core test && node typescript/core/web_core/tests/conformance/conformance_test.mjs.@a2ui/angular:yarn workspace @a2ui/angular build && yarn workspace @a2ui/angular lint && yarn workspace @a2ui/angular test.common_typesandvalidator_v1_0runners viapytest conformance/tests/test_conformance_yaml.py python/a2ui_core/tests/test_conformance.py../scripts/fix_licenses.py --check.