fix: add data-state guard to init check in samples 339 and 342#596
Closed
oblomov-dev wants to merge 1 commit intostandardfrom
Closed
fix: add data-state guard to init check in samples 339 and 342#596oblomov-dev wants to merge 1 commit intostandardfrom
oblomov-dev wants to merge 1 commit intostandardfrom
Conversation
client->check_on_init() checks the root app's check_initialized flag, not the sub-app's own state. When sample 338 dynamically creates a new sub-app instance after a tab switch, the root app (338) is already initialized so check_on_init() returns false — causing get_data() and render_main() to be skipped on a fresh instance, leaving mt_table/mt_data as NULL and producing a NULL-dereference error. Add `OR mt_table IS INITIAL` / `OR mt_data IS INITIAL` so that freshly created sub-app instances always run their initialization regardless of the root app's state, while already-initialized (deserialized) instances correctly skip it on subsequent roundtrips. https://claude.ai/code/session_013QHAz9q9WnLNYngajxtFwD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client->check_on_init() checks the root app's check_initialized flag, not the sub-app's own state. When sample 338 dynamically creates a new sub-app instance after a tab switch, the root app (338) is already initialized so check_on_init() returns false — causing get_data() and render_main() to be skipped on a fresh instance, leaving mt_table/mt_data as NULL and producing a NULL-dereference error.
Add
OR mt_table IS INITIAL/OR mt_data IS INITIALso that freshly created sub-app instances always run their initialization regardless of the root app's state, while already-initialized (deserialized) instances correctly skip it on subsequent roundtrips.https://claude.ai/code/session_013QHAz9q9WnLNYngajxtFwD