fix(*): resolve typeScript visitor imports for map types#238
Merged
mttrbrts merged 1 commit intoMay 31, 2026
Merged
Conversation
Signed-off-by: Moh <40035796+muhabdulkadir@users.noreply.github.com>
mttrbrts
approved these changes
May 31, 2026
5 tasks
apoorv7g
pushed a commit
to apoorv7g/concerto-codegen
that referenced
this pull request
Jun 1, 2026
…ct#238) Signed-off-by: Moh <40035796+muhabdulkadir@users.noreply.github.com> Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Fixed TypeScript visitor code generation to correctly import map alias types without interface prefixes, ensuring generated imports match the emitted type names.
Map declarations emit
export type Name = Map<key, value>. For map types from external namespaces, the imports must use direct type names (e.g.,import {MapTypeName}notimport {IMapTypeName}). This fix ensures consistency between what's imported and what's used in the generated types.Changes
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname