fix(test): make external model fixtures hermetic#154
Open
Rishabh060105 wants to merge 2 commits into
Open
Conversation
added 2 commits
May 14, 2026 23:13
Signed-off-by: Rishabh Jain <rishabhj2005@email.com>
Signed-off-by: Rishabh Jain <rishabhj2005@email.com>
Author
|
Hi @mttrbrts, the fix follows the Concerto-style cached external model pattern. What changed:
I also verified the full suite locally after the change: npm test -- --runInBand --coverage=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153
Summary
This change makes the test suite hermetic for the remaining external-model paths.
It replaces live model downloads in the affected tests with cached
@models...fixtures, following the same naming pattern already used in Concerto tests and existing Accord Project archive fixtures.Changes
test/modelsModelManagerTemplateMarkInterpreter.test.tsto stop callingupdateExternalModels()at runtimeTemplateArchiveProcessor.test.tsto resolve external model fetches from local cached fixturesTest
npm test -- --runInBand --coverage=falseResults: