Moving to scaleset client for the controller

[nikola-jokic]

No description provided.

[github-actions]

Hello! Thank you for your contribution.

Please review our contribution guidelines to understand the project's testing and code conventions.

[Copilot]

Pull request overview

This PR migrates the actions.github.com controllers from the legacy github/actions client to the newer github.com/actions/scaleset client by introducing a scaleset-backed multi-client and updating secret resolution, controller logic, and tests accordingly.

Changes:

• Add a new controllers/actions.github.com/multiclient scaleset-backed client cache and update controllers to use it via secretresolver.
• Refactor secret resolution into controllers/actions.github.com/secretresolver and extract the shared ActionsGitHubObject interface into controllers/actions.github.com/object.
• Update dependency github.com/actions/scaleset to v0.2.0 and adjust controller/resource builder code + tests for renamed fields/types.

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
main.go	Wire up the new scaleset multiclient + secretresolver and switch comma-slice parsing to strings.SplitSeq.
logging/logger.go	Minor formatting cleanup of zap options definition.
logger/logger.go	New helper for creating *slog.Logger from level/format.
go.mod / go.sum	Bump github.com/actions/scaleset to v0.2.0.
controllers/actions.github.com/secretresolver/secret_resolver.go	New secretresolver package; builds proxy + custom RootCAs options and requests a multiclient per config.
controllers/actions.github.com/multiclient/multi_client.go	New scaleset multiclient implementation with client caching and client construction.
controllers/actions.github.com/multiclient/fake/*	New fake multiclient/client implementations for tests.
controllers/actions.github.com/object/object.go	New shared ActionsGitHubObject interface extracted from old resolver.
controllers/actions.github.com/resourcebuilder.go	Update types/fields to scaleset equivalents and switch SecretResolver to an interface.
controllers/actions.github.com/_controller.go	Switch JIT config + client usage types to scaleset-backed interfaces.
controllers/actions.github.com/*_test.go	Update tests to use new secretresolver + multiclient fakes; adjust TLS/proxy tests accordingly.
cmd/ghalistener/*	Rename ConfigureUrl → ConfigureURL and update usages/tests; reuse new slog logger helper.
apis/actions.github.com/v1alpha1/ephemeralrunner_types.go	Rename RunnerScaleSetId → RunnerScaleSetID.
.mockery.yaml / controllers/actions.github.com/mocks_test.go	Update mockery config and add generated mocks for controller package.

Comments suppressed due to low confidence (4)

controllers/actions.github.com/secretresolver/secret_resolver.go:60

• This returns an error using %v, which prevents unwrapping with errors.Is/As. Use %w when wrapping the underlying error so callers can detect specific failure causes.
  controllers/actions.github.com/secretresolver/secret_resolver.go:28
• SecretResolver now has a logger field and WithLogger(...) option, but the logger is never read/used anywhere in this type, so the option currently has no effect. Either use sr.logger for resolver/client creation logging (and/or plumb it into the underlying scaleset client options) or remove the field/option to avoid misleading API surface.
  controllers/actions.github.com/secretresolver/secret_resolver.go:79
• This returns an error using %v, which prevents unwrapping with errors.Is/As. Use %w when wrapping the underlying error so callers can detect specific failure causes.
  controllers/actions.github.com/secretresolver/secret_resolver.go:42
• New(...) validates k8sClient but not scalesetMultiClient. If scalesetMultiClient is nil, GetActionsService will panic later on first use. Consider validating it in New (panic or return error) to fail fast with a clearer message.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

entry.rootCAs.Equal(opts.RootCAs) will panic when a cached entry has rootCAs == nil (the common case when no custom CA is configured). Handle nils explicitly (e.g., treat both nil as equal; otherwise compare non-nil pools) before calling Equal.

[Draco7587]

Hola