Restore beta proxy env support with EnvHttpProxyAgent#342
Draft
parkerbxyz wants to merge 3 commits intobetafrom
Draft
Restore beta proxy env support with EnvHttpProxyAgent#342parkerbxyz wants to merge 3 commits intobetafrom
parkerbxyz wants to merge 3 commits intobetafrom
Conversation
Use Undici's EnvHttpProxyAgent in the shared request client so the beta branch keeps proxy support without relying on NODE_USE_ENV_PROXY or respawning the action process. Add focused proxy tests and regenerate snapshots/dist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a real end-to-end proxy job that starts a local CONNECT proxy, runs the action with https_proxy, and asserts that traffic actually tunneled through the proxy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the extra post-action API request from the proxy workflow job so it only verifies the action succeeds and that proxy traffic occurred. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
betacurrently has no proxy handling inlib/request.js, but Node's built-in env-proxy support still requiresNODE_USE_ENV_PROXY=1at process startup. This restores proxy support onbetawithout respawning the action process, and adds CI coverage so future changes keep exercising the proxy path.EnvHttpProxyAgentin the shared request client whenever proxy env vars are present, so bothmain.jsandpost.jsinherit the behavior automaticallyNO_PROXY=*bypasshttps_proxy, and asserts that traffic actually tunneled through the proxydist/outputThis keeps the runtime fix localized to
lib/request.jsand avoids the subprocess workaround explored in #284. I'd appreciate extra eyes on the proxy smoke test job since it becomes the long-term guardrail for this behavior.Created with GitHub Desktop