Skip to content

HTTP Request Compression for ADBRO Bid Adapter#2

Open
inebritov wants to merge 2 commits intomasterfrom
feature/ADBRO-4395-compression-support
Open

HTTP Request Compression for ADBRO Bid Adapter#2
inebritov wants to merge 2 commits intomasterfrom
feature/ADBRO-4395-compression-support

Conversation

@inebritov
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@inebritov inebritov requested a review from ashvetsov January 15, 2026 10:43
@inebritov inebritov self-assigned this Jan 15, 2026
expect(serverRequest.url).to.exist;
expect(serverRequest.url).to.equal('https://prebid.adbro.me/pbjs?placementId=1234');
expect(serverRequest.options).to.exist;
expect(serverRequest.options.endpointCompression).to.be.true;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a dedicated test case within the same group:

it('Configures compression for the ServerRequest object', function () {
  const serverRequest = serverRequests[0];
  expect(serverRequest.options).to.exist;
  expect(serverRequest.options.endpointCompression).to.be.true;
}

It's always better to add new test cases than to modify existing ones.

…tatement

Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21059761616

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 219 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.007%) to 93.375%

Files with Coverage Reduction New Missed Lines %
modules/excoBidAdapter.js 1 70.34%
test/spec/modules/tcfControl_spec.js 1 99.55%
modules/ringieraxelspringerBidAdapter.js 3 94.22%
modules/mediagoBidAdapter.js 4 86.42%
modules/tcfControl.ts 4 93.47%
src/adapters/bidderFactory.ts 7 92.82%
modules/adkernelBidAdapter.js 9 92.17%
modules/nodalsAiRtdProvider.js 10 88.15%
src/auction.ts 12 91.84%
test/spec/modules/pubmaticBidAdapter_spec.js 13 96.48%
Totals Coverage Status
Change from base Build 21058833224: 0.007%
Covered Lines: 207751
Relevant Lines: 215921

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants