You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[codegen] Support the current protocol reference graph deterministically #1100
The Python type generator did not cleanly consume the current protocol source graph used by the reporting RFC. Two general generator assumptions failed:
sibling macro-*.json references were not recognized/resolved consistently;
selected canonical-ref preservation handled canonical URLs but not equivalent local relative references.
After those were fixed, newly generated shared names (Alignment, PrimaryKey, and TimezoneBasis) also tripped the collision gate and needed explicit review/allowlisting.
Impact
Valid changes in protocol reference layout can break Python generation even when the JSON Schema suite passes. Fixing each schema locally or copying only the desired generated models hides the incompatibility until release time.
Expected
Resolve sibling, parent-relative, root-relative, and canonical URL references through one normalized path algorithm.
Assert that normalized references cannot escape the schema root.
Add fixtures covering sibling macro-*.json references and local/canonical forms of the same reference.
Keep collision failures loud, but include a deterministic review/update workflow and focused diagnostics showing each source definition.
Run the generator against the protocol PR bundle in CI.
The generator fixes and collision decisions are already implemented in #1095; this issue should remain the regression/acceptance record for that work.
My take: PR #1095 is open and covers all five acceptance criteria listed here (reference normalization, escape assertion, fixtures, collision workflow, CI bundle run). This issue should stay open as the tracking surface until that PR merges and the criteria are verified.
Activity
bokelley commentedon Aug 29, 2026
Triage
Classification: Bug (codegen / validation)
Bucket(s): validation
Status: deferred
What the experts said:
My take: PR #1095 is open and covers all five acceptance criteria listed here (reference normalization, escape assertion, fixtures, collision workflow, CI bundle run). This issue should stay open as the tracking surface until that PR merges and the criteria are verified.
Blocked-on: #1095 — resurfaces on merge
Triaged by Claude Code. Session: https://claude.ai/code/session_0166Xyt6h1Q9uAhDRvhMDRFk
Generated by Claude Code
fix(codegen): make regeneration atomic and deterministic (#1115)