You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(packaging): make VCS-built wheels include runtime schemas #1104
Installing the Python SDK directly from a Git commit produces a wheel with no adcp/_schemas directory.
The repository's release workflows explicitly run python scripts/bundle_schemas.py before python -m build, but a normal PEP 517 VCS install (adcp @ git+https://...@<sha>) invokes the build backend without that repository-specific preparation step. Setuptools therefore sees no package data to include.
Reproduction
Install a Git commit into a clean environment.
Inspect Path(adcp.__file__).parent / "_schemas", or call:
The schema directory is absent and the call raises:
LookupError: no 3.1 schema for list_creatives::request
The same commit works as an editable checkout because scripts/bundle_schemas.py had already populated the ignored source tree locally. Released PyPI artifacts work because CI runs the bundling step explicitly.
Impact
Git-SHA dependency pins are not reproducible for SDK/adopter integration testing.
Local editable validation can pass while the exact same commit fails in adopter CI.
This blocks testing a protocol PR, SDK PR, and adopter PR together before a prerelease is published.
Proposed acceptance criteria
A PEP 517 wheel built from a clean VCS checkout contains the supported 2.5, 3.0, 3.1, and current 3.2 schema bundles without relying on a pre-existing ignored directory.
A clean installed wheel resolves a representative versioned 3.1 model and current generated reporting model.
Release-built and VCS-built wheels contain the same supported schema-version set.
Add a CI smoke that builds from a checkout after ensuring src/adcp/_schemas is absent.
An implementation is being validated in #1095 by copying tracked supported bundles into the wheel build directory from a build_py hook.
My take: The build_py-hook approach described here is under active development on the #1095 branch. Deferring until that PR ships or the packaging fix is extracted to a standalone PR. If the fix needs to land independently of #1095's protocol-blocking dependency (adcontextprotocol/adcp#6953 and adcontextprotocol/adcp#6966), opening a dedicated fix(packaging) PR that Closes #1104 directly — separate from the reporting reconciliation work — would unblock adopters sooner.
Activity
bokelley commentedon Aug 29, 2026
Triage
Classification: Bug
Bucket(s): (no matching label — packaging/build-system has no exact label in this repo)
Status: deferred
What the experts said:
My take: The
build_py-hook approach described here is under active development on the #1095 branch. Deferring until that PR ships or the packaging fix is extracted to a standalone PR. If the fix needs to land independently of #1095's protocol-blocking dependency (adcontextprotocol/adcp#6953 and adcontextprotocol/adcp#6966), opening a dedicatedfix(packaging)PR thatCloses #1104directly — separate from the reporting reconciliation work — would unblock adopters sooner.Blocked-on: #1095 — resurfaces on merge
Triaged by Claude Code. Session: https://claude.ai/code/443d48dc-262b-556b-b772-06786a27b560
Generated by Claude Code
fix(packaging): include schemas in VCS-built wheels (#1118)