Skip to content

3.2 beta gate: remove dead reporting webhook compatibility patch #1105

Closed

Description

@bokelley

Release blocker

The Python SDK's candidate-bundle validation refuses AdCP 3.2.0-beta.10 because schemas/patches/01-reporting-webhook-operation-id.patch is now dead: the upstream protocol bundle already contains the patched shape.

Failing protocol run: https://github.com/adcontextprotocol/adcp/actions/runs/33308083808/job/99248392514
Protocol PR: adcontextprotocol/adcp#7007

The SDK's failure is useful and explicit:

Patch is DEAD (upstream already has this change): 01-reporting-webhook-operation-id.patch

Acceptance criteria

  • Remove the dead patch and fold any dependent model/helper/test assumptions into the generated upstream shape.
  • Regeneration and validate-generated pass against the 3.2.0-beta.10 candidate bundle.
  • tests/test_code_generation.py and tests/test_schemas_version_pin.py pass.
  • Rerun the AdCP Version Packages SDK-bundle gate and link the passing run here.

Activity

  1. added
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on Aug 30, 2026
  2. bokelley commented on Aug 30, 2026

    @bokelley
    ContributorAuthor

    Triage

    Classification: Bug (release-blocker)
    Bucket(s): validation / code-generation (no repo labels found for these buckets — gap noted)
    Status: ready-to-implement

    What the experts said:

    • code-reviewer: Non-breaking once the beta.10 bundle is fetched and field constraints verified; src/adcp/ADCP_VERSION must be bumped before make regenerate-schemas can confirm patch 01 is dead, and patch 02 must be evaluated in the same PR (it will also be classified dead against the beta.9 working tree).
    • ad-tech-protocol-expert: Removal is protocol-sound but requires char-for-char comparison of the operation_id pattern/minLength/maxLength in beta.10 against the injected values; numbering churn in aliases.py is a known risk on any version bump per CLAUDE.md.

    My take: The fix is non-breaking — ReportingWebhook.operation_id stays Required[str] for all SDK consumers, just sourced from upstream rather than the patch. The prerequisite is fetching the beta.10 bundle to verify the field definition and profile-tier stripping match exactly before deleting the patch.

    Implementation scope:

    • Bump src/adcp/ADCP_VERSION to 3.2.0-beta.10, run make regenerate-schemas to fetch the bundle and confirm patch 01 dead
    • Delete schemas/patches/01-reporting-webhook-operation-id.patch; verify beta.10 core/reporting-webhook.json has the same minLength/maxLength/pattern: "^[A-Za-z0-9_.:-]{1,255}$" the patch injected; also check the model-context profile variants for correct constraint stripping
    • Evaluate patch 02 independently: if beta.10's core/mcp-webhook-payload.json operation_id description contains both push_notification_config.operation_id and reporting_webhook.operation_id as substrings, delete it; otherwise retarget or update it — do not assume dead without running the test
    • Run make validate-generated + pytest tests/test_reporting_webhook_operation_id.py tests/test_code_generation.py tests/test_schemas_version_pin.py; spot-check aliases.py:2131-2132 (ReportingWebhookAuthentication) for numbering churn after regen

    Triaged by Claude Code. Session: https://claude.ai/code/session_01QpcBPkVM4JgVv44BqG7ftj


    Generated by Claude Code

  3. added
    bugSomething isn't working
    and removed
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions