You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
3.2 beta gate: remove dead reporting webhook compatibility patch #1105
The Python SDK's candidate-bundle validation refuses AdCP 3.2.0-beta.10 because schemas/patches/01-reporting-webhook-operation-id.patch is now dead: the upstream protocol bundle already contains the patched shape.
Classification: Bug (release-blocker) Bucket(s): validation / code-generation (no repo labels found for these buckets — gap noted) Status: ready-to-implement
What the experts said:
code-reviewer: Non-breaking once the beta.10 bundle is fetched and field constraints verified; src/adcp/ADCP_VERSION must be bumped before make regenerate-schemas can confirm patch 01 is dead, and patch 02 must be evaluated in the same PR (it will also be classified dead against the beta.9 working tree).
ad-tech-protocol-expert: Removal is protocol-sound but requires char-for-char comparison of the operation_id pattern/minLength/maxLength in beta.10 against the injected values; numbering churn in aliases.py is a known risk on any version bump per CLAUDE.md.
My take: The fix is non-breaking — ReportingWebhook.operation_id stays Required[str] for all SDK consumers, just sourced from upstream rather than the patch. The prerequisite is fetching the beta.10 bundle to verify the field definition and profile-tier stripping match exactly before deleting the patch.
Implementation scope:
Bump src/adcp/ADCP_VERSION to 3.2.0-beta.10, run make regenerate-schemas to fetch the bundle and confirm patch 01 dead
Delete schemas/patches/01-reporting-webhook-operation-id.patch; verify beta.10 core/reporting-webhook.json has the same minLength/maxLength/pattern: "^[A-Za-z0-9_.:-]{1,255}$" the patch injected; also check the model-context profile variants for correct constraint stripping
Evaluate patch 02 independently: if beta.10's core/mcp-webhook-payload.jsonoperation_id description contains both push_notification_config.operation_id and reporting_webhook.operation_id as substrings, delete it; otherwise retarget or update it — do not assume dead without running the test
Run make validate-generated + pytest tests/test_reporting_webhook_operation_id.py tests/test_code_generation.py tests/test_schemas_version_pin.py; spot-check aliases.py:2131-2132 (ReportingWebhookAuthentication) for numbering churn after regen
Activity
bokelley commentedon Aug 30, 2026
Triage
Classification: Bug (release-blocker)
Bucket(s): validation / code-generation (no repo labels found for these buckets — gap noted)
Status: ready-to-implement
What the experts said:
src/adcp/ADCP_VERSIONmust be bumped beforemake regenerate-schemascan confirm patch 01 is dead, and patch 02 must be evaluated in the same PR (it will also be classified dead against the beta.9 working tree).operation_idpattern/minLength/maxLength in beta.10 against the injected values; numbering churn inaliases.pyis a known risk on any version bump per CLAUDE.md.My take: The fix is non-breaking —
ReportingWebhook.operation_idstaysRequired[str]for all SDK consumers, just sourced from upstream rather than the patch. The prerequisite is fetching the beta.10 bundle to verify the field definition and profile-tier stripping match exactly before deleting the patch.Implementation scope:
src/adcp/ADCP_VERSIONto3.2.0-beta.10, runmake regenerate-schemasto fetch the bundle and confirm patch 01 deadschemas/patches/01-reporting-webhook-operation-id.patch; verify beta.10core/reporting-webhook.jsonhas the sameminLength/maxLength/pattern: "^[A-Za-z0-9_.:-]{1,255}$"the patch injected; also check the model-context profile variants for correct constraint strippingcore/mcp-webhook-payload.jsonoperation_iddescription contains bothpush_notification_config.operation_idandreporting_webhook.operation_idas substrings, delete it; otherwise retarget or update it — do not assume dead without running the testmake validate-generated+pytest tests/test_reporting_webhook_operation_id.py tests/test_code_generation.py tests/test_schemas_version_pin.py; spot-checkaliases.py:2131-2132(ReportingWebhookAuthentication) for numbering churn after regenTriaged by Claude Code. Session: https://claude.ai/code/session_01QpcBPkVM4JgVv44BqG7ftj
Generated by Claude Code