Repository navigation
Closed
Labels
Description
Goal
Make the @adcp/sdk 14.0.0 (AdCP 3.2.1 compliance bundle) storyboard lanes gating, then remove the @adcp/sdk@13.1.3 pin in .github/workflows/ci.yml.
Context
@adcp/sdk@latest moved to 14.0.0 at 2026-10-01 12:39 UTC. 14.0.0 embeds the AdCP 3.2.1 compliance bundle. The storyboard lanes installed latest, so main CI on release commit b7e5a07 (run 36865170866) graded the example and reference sellers against 3.2.1 storyboards and failed. The PR CI for #1262 had passed on 13.1.3. The gating lanes are now pinned to @adcp/sdk@13.1.3. Advisory (advisory: @adcp/sdk 14.0.0) lanes keep these gaps visible.
Partial fixes for 8.0.x are on branch fix/examples-adcp-3-2-1-storyboards:
seller_agent.pystops advertisingcanonical_creatives=false. The adcp-3.0 lane still passes 59/59.- The sales-proposal-mode seller declares
buying_modes: ["brief", "refine"].
Gaps by lane, with SDK 14.0.0
examples/seller_agent.py (media_buy_seller)
- (on branch) The seller advertised
media_buy.features.canonical_creatives: false. Its own framework then rejected every 3.2 request withAdCP 3.2+ requires canonical creatives(11 failures, 22 cascaded skips). With the flag removed, 5 failures remain: -
total_budget_redistribution:- create must echo
total_budget(the package sum). update_media_buywithtotal_budgetalone must rescale active packages proportionally and echototal_budgetandaffected_packages.total_budgettogether withpackagesmust returnVALIDATION_ERRORwhen the amount doesn't match the resulting package sum.get_media_buysmust persist the scaled budgets.
- create must echo
-
read_filter_behavior/filter_media_buys:get_media_buysignoresstatus_filter. Apply it together withmedia_buy_ids(AND logic). Default to["active"]whenmedia_buy_idsis omitted. -
delivery_reporting/simulate_and_verify: thesimulate_deliverycontroller call failed with a runner-side "fetch failed". Needs investigation, may be intermittent. - Storyboard/design question:
advanced_delivery_reporting/discover_productsendsbuying_mode: "wholesale"without arequires_capabilitygate. The spec makes wholesale opt-in ("absent declaration is treated as ['brief']… sellers MAY return INVALID_REQUEST"). SDK 14 refuses the call client-side: "Seller does not support wholesale buying mode." Two options: fix the storyboard upstream, gating it onmedia_buy.buying_modes contains wholesaleor using a brief; or have the example implement wholesale, which also needsget_productsfilters,requested_metricsnarrowing,time_based_views, and a sorted, truncatedby_formatbreakdown.
sales-proposal-mode (media_buy_seller/proposal_finalize)
- (on branch) The router capabilities left out
buying_modes, so the default was["brief"]and SDK 14 refusedbuying_mode: "refine". The fix declares["brief", "refine"]inapp.pyandplatform.py. Possible library follow-up: advertiserefineautomatically when a ProposalManager with finalize is wired. - Storyboard/design question: the
finalize_proposal/get_products_finalize_replaystep expectsreplayed: trueon a same-key finalize retry. The seller declaresadcp.idempotency.supported: false, and the spec says there is then no replay guarantee. Today the seller re-runs finalize and returnsPROPOSAL_NOT_COMMITTED. Two options: gate the step upstream on idempotency support, or wire framework idempotency (replay of the intercepted finalize) into the example.
examples/multi_platform_seller (PlatformRouter)
- SDK 14 fails the run with exit code 3 at
__spec_conformance__/account_discovery: "declared account-bearing specialism(s) [sales-guaranteed, sales-non-guaranteed] but advertises neither list_accounts nor sync_accounts". SDK 13.1.3 reported the same failure, plus 5 failing steps (missingcache_scopeonget_products,PRODUCT_NOT_FOUNDinstead ofTERMS_REJECTED,MEDIA_BUY_NOT_FOUNDinstead ofPACKAGE_NOT_FOUND), but exited 0. The lane only checks the exit code, so it never really gated storyboard results. Exposelist_accountsorsync_accounts, fix the surfaced failures, and assertoverall_statusin the workflow.
v3 reference seller (translator)
- Design question: the 3.2.1 storyboards now declare
prerequisites.controller_seeding: truewith account fixtures (adcp #7601). That covers everymedia_buy_sellerstoryboard applicable to this seller, includinginvalid_transitionsandmeasurement_terms_rejected, which previously gave 8 passing steps. The translator deliberately has nocomply_test_controller, so 14.0.0 skips all 190 steps (missing_test_controller=134,not_applicable=55). The "Assert storyboard passed" gate (steps_passed > 0) and the anti-façade upstream-traffic gate can't pass. Separately, the gate's missing-tool check reports['']because SDK 14's syntheticmissing_toolstep foroutcome_target_list_products_inert(list_products) has an emptytask. Decide between a sandbox-only seeding controller (at leastseed_account) on the translator and a redefined lane.
Not SDK-related
- "Receipt rolling compatibility (eight actual artifacts)" failed in run 36865170866 only because
actions/checkouttimed out after 2 minutes. It's a flake and passes on rerun.
Activity
ci(storyboard): pin gating runner to @adcp/sdk 13.1.3, add 14.0.0 adv…
bokelley commentedon Oct 1, 2026
Triage
Classification: Epic / tracking (multi-component CI gating)
Bucket(s): examples, cross-repo (labels not present in repo; noted in run summary)
Status: ready-for-human
Milestone: omitted (no milestone indicated)
What the experts said:
total_budget_redistribution,filter_media_buys,multi_platform_selleraccount_discovery) are deterministic code fixes with no spec ambiguity and could land in one PR on the existingfix/examples-adcp-3-2-1-storyboardsbranch. Items 4 (wholesale buying_mode) and 7 (translatorcontroller_seeding) each have upstream design questions inadcontextprotocol/adcpthat may block full CI gating for weeks. Item 5 (idempotency replay) is fixable in-repo by wiring the existingIdempotencyStore. Item 3 (simulate_and_verify"fetch failed") is likely a CI network race, not a code defect.My take: This issue is epic-shaped — it spans four sellers, seven distinct sub-items, two upstream spec dependencies in
adcontextprotocol/adcp(items 4 and 7), and the terminal step (removing the@adcp/sdk@13.1.3pin in.github/workflows/ci.yml) is itself out of triage scope. Triage cannot create peer issues or open the CI workflow, so a human should structure this as a task list and decide the PR sequencing.Recommended next steps:
fix/examples-adcp-3-2-1-storyboardsbranch already carries thecanonical_creativesandbuying_modesfixes; items 1/2/6 are clean mechanical additions. A/triage executecomment on this issue (once no triage-managed PR is open) would authorize that PR.IdempotencyStoreinto the example and flipadcp.idempotency.supported: true; no upstream change needed.advanced_delivery_reporting/discover_productonbuying_modes contains wholesalein the storyboard (adcontextprotocol/adcp); decide between a sandboxseed_accountcontroller for the translator or a lane redefinition before the pin is removed.simulate_deliverystoryboard step; do not block the gating PR on it.Triaged by Claude Code. Session: https://claude.ai/code/session_01RJa16SvjBm8n3kAyEPUjia
Generated by Claude Code
ci(storyboard): pin gating runner to @adcp/sdk 13.1.3, add 14.0.0 adv…