Skip to content

Make @adcp/sdk 14.0.0 (AdCP 3.2.1) storyboard lanes gating #1273

Closed

Description

@bokelley

Goal

Make the @adcp/sdk 14.0.0 (AdCP 3.2.1 compliance bundle) storyboard lanes gating, then remove the @adcp/sdk@13.1.3 pin in .github/workflows/ci.yml.

Context

@adcp/sdk@latest moved to 14.0.0 at 2026-10-01 12:39 UTC. 14.0.0 embeds the AdCP 3.2.1 compliance bundle. The storyboard lanes installed latest, so main CI on release commit b7e5a07 (run 36865170866) graded the example and reference sellers against 3.2.1 storyboards and failed. The PR CI for #1262 had passed on 13.1.3. The gating lanes are now pinned to @adcp/sdk@13.1.3. Advisory (advisory: @adcp/sdk 14.0.0) lanes keep these gaps visible.

Partial fixes for 8.0.x are on branch fix/examples-adcp-3-2-1-storyboards:

  • seller_agent.py stops advertising canonical_creatives=false. The adcp-3.0 lane still passes 59/59.
  • The sales-proposal-mode seller declares buying_modes: ["brief", "refine"].

Gaps by lane, with SDK 14.0.0

examples/seller_agent.py (media_buy_seller)

  • (on branch) The seller advertised media_buy.features.canonical_creatives: false. Its own framework then rejected every 3.2 request with AdCP 3.2+ requires canonical creatives (11 failures, 22 cascaded skips). With the flag removed, 5 failures remain:
  • total_budget_redistribution:
    • create must echo total_budget (the package sum).
    • update_media_buy with total_budget alone must rescale active packages proportionally and echo total_budget and affected_packages.
    • total_budget together with packages must return VALIDATION_ERROR when the amount doesn't match the resulting package sum.
    • get_media_buys must persist the scaled budgets.
  • read_filter_behavior/filter_media_buys: get_media_buys ignores status_filter. Apply it together with media_buy_ids (AND logic). Default to ["active"] when media_buy_ids is omitted.
  • delivery_reporting/simulate_and_verify: the simulate_delivery controller call failed with a runner-side "fetch failed". Needs investigation, may be intermittent.
  • Storyboard/design question: advanced_delivery_reporting/discover_product sends buying_mode: "wholesale" without a requires_capability gate. The spec makes wholesale opt-in ("absent declaration is treated as ['brief']… sellers MAY return INVALID_REQUEST"). SDK 14 refuses the call client-side: "Seller does not support wholesale buying mode." Two options: fix the storyboard upstream, gating it on media_buy.buying_modes contains wholesale or using a brief; or have the example implement wholesale, which also needs get_products filters, requested_metrics narrowing, time_based_views, and a sorted, truncated by_format breakdown.

sales-proposal-mode (media_buy_seller/proposal_finalize)

  • (on branch) The router capabilities left out buying_modes, so the default was ["brief"] and SDK 14 refused buying_mode: "refine". The fix declares ["brief", "refine"] in app.py and platform.py. Possible library follow-up: advertise refine automatically when a ProposalManager with finalize is wired.
  • Storyboard/design question: the finalize_proposal/get_products_finalize_replay step expects replayed: true on a same-key finalize retry. The seller declares adcp.idempotency.supported: false, and the spec says there is then no replay guarantee. Today the seller re-runs finalize and returns PROPOSAL_NOT_COMMITTED. Two options: gate the step upstream on idempotency support, or wire framework idempotency (replay of the intercepted finalize) into the example.

examples/multi_platform_seller (PlatformRouter)

  • SDK 14 fails the run with exit code 3 at __spec_conformance__/account_discovery: "declared account-bearing specialism(s) [sales-guaranteed, sales-non-guaranteed] but advertises neither list_accounts nor sync_accounts". SDK 13.1.3 reported the same failure, plus 5 failing steps (missing cache_scope on get_products, PRODUCT_NOT_FOUND instead of TERMS_REJECTED, MEDIA_BUY_NOT_FOUND instead of PACKAGE_NOT_FOUND), but exited 0. The lane only checks the exit code, so it never really gated storyboard results. Expose list_accounts or sync_accounts, fix the surfaced failures, and assert overall_status in the workflow.

v3 reference seller (translator)

  • Design question: the 3.2.1 storyboards now declare prerequisites.controller_seeding: true with account fixtures (adcp #7601). That covers every media_buy_seller storyboard applicable to this seller, including invalid_transitions and measurement_terms_rejected, which previously gave 8 passing steps. The translator deliberately has no comply_test_controller, so 14.0.0 skips all 190 steps (missing_test_controller=134, not_applicable=55). The "Assert storyboard passed" gate (steps_passed > 0) and the anti-façade upstream-traffic gate can't pass. Separately, the gate's missing-tool check reports [''] because SDK 14's synthetic missing_tool step for outcome_target_list_products_inert (list_products) has an empty task. Decide between a sandbox-only seeding controller (at least seed_account) on the translator and a redefined lane.

Not SDK-related

  • "Receipt rolling compatibility (eight actual artifacts)" failed in run 36865170866 only because actions/checkout timed out after 2 minutes. It's a flake and passes on rerun.

Activity

  1. added
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on Oct 1, 2026
  2. bokelley commented on Oct 1, 2026

    @bokelley
    ContributorAuthor

    Triage

    Classification: Epic / tracking (multi-component CI gating)
    Bucket(s): examples, cross-repo (labels not present in repo; noted in run summary)
    Status: ready-for-human
    Milestone: omitted (no milestone indicated)

    What the experts said:

    • ad-tech-protocol-expert: Items 1/2/6 (total_budget_redistribution, filter_media_buys, multi_platform_seller account_discovery) are deterministic code fixes with no spec ambiguity and could land in one PR on the existing fix/examples-adcp-3-2-1-storyboards branch. Items 4 (wholesale buying_mode) and 7 (translator controller_seeding) each have upstream design questions in adcontextprotocol/adcp that may block full CI gating for weeks. Item 5 (idempotency replay) is fixable in-repo by wiring the existing IdempotencyStore. Item 3 (simulate_and_verify "fetch failed") is likely a CI network race, not a code defect.

    My take: This issue is epic-shaped — it spans four sellers, seven distinct sub-items, two upstream spec dependencies in adcontextprotocol/adcp (items 4 and 7), and the terminal step (removing the @adcp/sdk@13.1.3 pin in .github/workflows/ci.yml) is itself out of triage scope. Triage cannot create peer issues or open the CI workflow, so a human should structure this as a task list and decide the PR sequencing.

    Recommended next steps:

    • PR immediately eligible (items 1, 2, 6): the fix/examples-adcp-3-2-1-storyboards branch already carries the canonical_creatives and buying_modes fixes; items 1/2/6 are clean mechanical additions. A /triage execute comment on this issue (once no triage-managed PR is open) would authorize that PR.
    • In-repo follow-on (item 5): wire IdempotencyStore into the example and flip adcp.idempotency.supported: true; no upstream change needed.
    • Upstream question (items 4, 7): gate advanced_delivery_reporting/discover_product on buying_modes contains wholesale in the storyboard (adcontextprotocol/adcp); decide between a sandbox seed_account controller for the translator or a lane redefinition before the pin is removed.
    • Flake (item 3): add a CI readiness poll before the simulate_delivery storyboard step; do not block the gating PR on it.

    Triaged by Claude Code. Session: https://claude.ai/code/session_01RJa16SvjBm8n3kAyEPUjia


    Generated by Claude Code

  3. added and removed
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions