You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug(decisioning): validate_platform requires list_creative_formats_legacy, which AdCP 3.2 deprecates #1281
On 8.0.0, validate_platform treats list_creative_formats_legacy as required for every sales-* specialism, but AdCP 3.2 deprecates list_creative_formats. So a seller built natively on AdCP 3.2:
gets a boot-time UserWarning that it is "missing 'list_creative_formats_legacy' — required by the SalesPlatform Protocol"; and
fails to boot with INVALID_REQUEST under ADCP_DECISIONING_STRICT_VALIDATE_PLATFORM=1, which the docs recommend setting in CI.
Details
adcp/decisioning/dispatch.py:471-477: _SALES_RECOMMENDED includes list_creative_formats_legacy. RECOMMENDED_METHODS_PER_SPECIALISM applies it to all ten sales-* slugs.
adcp/decisioning/specialisms/sales.py:26 and :335-343 say the method is "Required when claiming any sales-* specialism in v6.0 rc.1+".
The bundled 3.2 schema media-buy/list-creative-formats-request.json sets "deprecated": true. Its description reads: "DEPRECATED in 3.2. Compatibility request for legacy named-format discovery. Sales agents expose purchasable canonical declarations on get_products Product.format_options[] ..."
There's also a stale pointer: the warning and the strict-mode error both send adopters to src/adcp/decisioning/specialisms/sales.py:184-227 for "the canonical method list". In 8.0.0 those lines are the get_products / refine_get_products docstring.
Observed
At boot, Embedded Sales Agent (sales-non-guaranteed, AdCP 3.2 native) logs:
UserWarning: DecisioningPlatform claims 'sales-non-guaranteed' but is missing 'list_creative_formats_legacy' — required by the SalesPlatform Protocol ...
Ask
When the server's negotiated release is 3.2 or later, drop list_creative_formats_legacy from the recommended set, or at least from strict mode. Keep it only for sellers that still serve pre-3.2 versions. Also update the Protocol docstring and point the warning at the actual method list.
Classification: Bug Bucket(s): decisioning/validation (no matching repo label — gap noted) Status: ready-for-human Milestone: omit
What the experts said:
ad-tech-protocol-expert: Non-breaking — list_creative_formats_legacy is already "optional, present-or-absent" per the module docstring; its presence in _SALES_RECOMMENDED is self-contradictory; unconditional removal has no dispatch consequence and no version seam is needed.
code-reviewer: Minor breaking — RECOMMENDED_METHODS_PER_SPECIALISM is in __all__; removing a method from its frozenset values changes the observable public contract; two assertions in test_validate_platform_warnings.py must be updated atomically; stale pointer fix is non-breaking.
My take: Both experts agree on the approach (unconditional removal is correct; version-conditional is unnecessary complexity). They disagree on the version-bump question, which is a project policy call.
Implementation scope:
dispatch.py:475 — remove "list_creative_formats_legacy" from _SALES_RECOMMENDED
dispatch.py:1016-1017 and :1037-1038 — replace stale sales.py:184-227 pointer with the actual method table location (sales.py:21-27)
sales.py:342 — update docstring from "Required when claiming any sales-* specialism in v6.0 rc.1+" to reflect 3.2 deprecation
tests/test_validate_platform_warnings.py:135 — update pointer string; :139-150 — remove list_creative_formats_legacy from expected warned set; add a passing-case test for a 3.2-native platform (no list_creative_formats_legacy)
Human decision needed: Patch release (RECOMMENDED set change is corrections-only) or minor (public __all__ dict value changed)? Once that's settled, this is ready to implement with /triage execute.
Activity
bokelley commentedon Oct 2, 2026
Triage
Classification: Bug
Bucket(s): decisioning/validation (no matching repo label — gap noted)
Status: ready-for-human
Milestone: omit
What the experts said:
list_creative_formats_legacyis already "optional, present-or-absent" per the module docstring; its presence in_SALES_RECOMMENDEDis self-contradictory; unconditional removal has no dispatch consequence and no version seam is needed.RECOMMENDED_METHODS_PER_SPECIALISMis in__all__; removing a method from its frozenset values changes the observable public contract; two assertions intest_validate_platform_warnings.pymust be updated atomically; stale pointer fix is non-breaking.My take: Both experts agree on the approach (unconditional removal is correct; version-conditional is unnecessary complexity). They disagree on the version-bump question, which is a project policy call.
Implementation scope:
dispatch.py:475— remove"list_creative_formats_legacy"from_SALES_RECOMMENDEDdispatch.py:1016-1017and:1037-1038— replace stalesales.py:184-227pointer with the actual method table location (sales.py:21-27)sales.py:342— update docstring from "Required when claiming anysales-*specialism in v6.0 rc.1+" to reflect 3.2 deprecationtests/test_validate_platform_warnings.py:135— update pointer string;:139-150— removelist_creative_formats_legacyfrom expected warned set; add a passing-case test for a 3.2-native platform (nolist_creative_formats_legacy)Human decision needed: Patch release (RECOMMENDED set change is corrections-only) or minor (public
__all__dict value changed)? Once that's settled, this is ready to implement with/triage execute.Triaged by Claude Code. Session: https://claude.ai/code/session_019tLKm9BWx9V7zFX8iwQXRC
Generated by Claude Code