Skip to content

__all__ carries duplicate entries in adcp and adcp.types #1380

Closed

Description

@KonstantinMirin

Three names appear twice in a generated __all__. Measured against a3441958c:

adcp         len= 732  unique= 731  duplicates=['AcquireRightsResponse1']
adcp.types   len= 925  unique= 923  duplicates=['WholesaleFeedEvent', 'WholesaleFeedWebhook']

Each duplicate resolves to a single class, so from adcp.types import * works and binds
923 names rather than raising. The entries are redundant rather than broken.

Why it is worth fixing anyway

__all__ is a list, so anything that scans it rather than setting it counts a duplicate
twice. That is not hypothetical: two independent counts of the exported RootModel
population disagreed — 45 against 46 — purely because one iterated the list and the other
took a set, and WholesaleFeedEvent is a RootModel. The population is 45; the 46 was the
duplicate.

A generated __all__ should be de-duplicated at the point it is written, so a consumer
counting exports gets the same answer whichever way they iterate.

Where

The consolidation step that emits these lists. The duplicates appear in the generated
output, not in a hand-maintained list, so the fix belongs in the generator rather than in
a correction applied afterwards.

Activity

  1. added
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on Oct 3, 2026
  2. bokelley commented on Oct 3, 2026

    @bokelley
    Contributor

    Triage

    Classification: Bug
    Bucket(s): client (types/codegen surface — no exact label match found; gap noted)
    Status: deferred

    What the experts said: Fold candidate — PR #1367 (open, same author, filed today) rewrites the consolidation/generation layer for adcp.types and explicitly defers __all__ curation to a hand-maintained step. The de-duplication fix directly overlaps the files #1367 is actively reworking; no separate expert panel run.

    My take: The fix belongs in the consolidation step that #1367 is reworking. Folding the __all__ de-duplication there before merge keeps the change coherent with the new generation logic and avoids a follow-up conflict on the same files.

    Blocked-on: #1367 — resurfaces on merge


    Triaged by Claude Code. Session: https://claude.ai/code/session_01QZ1q6TDa4x6zhFTmneRTWo


    Generated by Claude Code

  3. added and removed
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on Oct 3, 2026
  4. added a commit that references this issue on Oct 4, 2026
    197bcde
  5. added a commit that references this issue on Oct 5, 2026
    d033c36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions