You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
__all__ carries duplicate entries in adcp and adcp.types #1380
Each duplicate resolves to a single class, so from adcp.types import * works and binds
923 names rather than raising. The entries are redundant rather than broken.
Why it is worth fixing anyway
__all__ is a list, so anything that scans it rather than setting it counts a duplicate
twice. That is not hypothetical: two independent counts of the exported RootModel
population disagreed — 45 against 46 — purely because one iterated the list and the other
took a set, and WholesaleFeedEvent is a RootModel. The population is 45; the 46 was the
duplicate.
A generated __all__ should be de-duplicated at the point it is written, so a consumer
counting exports gets the same answer whichever way they iterate.
Where
The consolidation step that emits these lists. The duplicates appear in the generated
output, not in a hand-maintained list, so the fix belongs in the generator rather than in
a correction applied afterwards.
Classification: Bug Bucket(s): client (types/codegen surface — no exact label match found; gap noted) Status: deferred
What the experts said: Fold candidate — PR #1367 (open, same author, filed today) rewrites the consolidation/generation layer for adcp.types and explicitly defers __all__ curation to a hand-maintained step. The de-duplication fix directly overlaps the files #1367 is actively reworking; no separate expert panel run.
My take: The fix belongs in the consolidation step that #1367 is reworking. Folding the __all__ de-duplication there before merge keeps the change coherent with the new generation logic and avoids a follow-up conflict on the same files.
Activity
bokelley commentedon Oct 3, 2026
Triage
Classification: Bug
Bucket(s): client (types/codegen surface — no exact label match found; gap noted)
Status: deferred
What the experts said: Fold candidate — PR #1367 (open, same author, filed today) rewrites the consolidation/generation layer for
adcp.typesand explicitly defers__all__curation to a hand-maintained step. The de-duplication fix directly overlaps the files #1367 is actively reworking; no separate expert panel run.My take: The fix belongs in the consolidation step that #1367 is reworking. Folding the
__all__de-duplication there before merge keeps the change coherent with the new generation logic and avoids a follow-up conflict on the same files.Blocked-on: #1367 — resurfaces on merge
Triaged by Claude Code. Session: https://claude.ai/code/session_01QZ1q6TDa4x6zhFTmneRTWo
Generated by Claude Code
fix(codegen): keep the format-reference agent_url as the wire string (#…
fix(types): name each export once in __all__ (adcontextprotocol#1393)