Repository navigation
Description
Conditional on adcontextprotocol/adcp#8797. Do this only if that PR lands, expected before 3.3 rc.0. If it's dropped, close this issue.
Problem
The reporting-subscription coverage vectors in tests/fixtures/reporting_subscriptions/spec/ are vendored from adcontextprotocol/adcp 8ee1bfa2. That's 3.3.0-beta.4, and the 3.3.0-beta.5 and beta.6 bundles carry byte-identical copies.
adcontextprotocol/adcp#8797 ("beta.5 coverage — package_ids exceptions compose; billing stub at timezone cutovers") changes the reference model, and probably the vectors and the differential regressions. Both SDKs already follow the spec text on both points:
- a
package_idsexception composes with resolution; - a billing feed owes a stub at an account-timezone cutover.
The Python SDK carries three differential regressions where it deliberately disagrees with the 8ee1bfa2 model. Once #8797 lands, the vendored files and the parity test must move to the new spec commit and still pass byte for byte, and the regressions should reconcile with the new model.
Spec reference
- feat(reporting): beta.5 coverage — package_ids exceptions compose; billing stub at timezone cutovers adcp#8797, open, not in 3.3.0-beta.6.
static/compliance/source/test-vectors/reporting-subscriptions/:vectors.json,case.schema.json,error-codes.json,reason-codes.json,offering-checks.json,README.md.core/reporting-subscription.jsoncutovertext: a billing stub at every cutover, account-timezone changes included.
Fix sketch
- Once #8797 is in a signed bundle, re-vendor the six files from that bundle's
compliance/test-vectors/reporting-subscriptions/, or from the spec commit. UpdateSPEC_COMMITand the SHA-256 pins. - Run
tests/test_reporting_subscription_parity.pyandtests/test_reporting_subscription_beta4.py. All vectors, offering checks and regressions must pass. - Where the new reference model now agrees with the SDK, drop or rewrite the three differential regressions, and the timezone-cutover stub test, so they assert against the vectors.
- Update
docs/reporting-subscriptions-coverage.md, which still says the8ee1bfa2model emits no stub at a timezone cutover. - Confirm
REPORTING_STORAGE_CONTRACTandadcp_reporting_storage.contract.STORAGE_CONTRACTdon't change. Coverage is computed, not persisted.
Code locations (next at 807141962)
tests/fixtures/reporting_subscriptions/spec/: the six vendored files.tests/test_reporting_subscription_parity.py:SPEC_COMMIT(43) andPINNEDSHA-256s (44–49).tests/test_reporting_subscription_beta4.py:DIFFERENTIAL(323),test_differential_regressions_match_the_reference_model(336),test_a_billing_feed_owes_a_stub_at_an_account_timezone_cutover(353).tests/fixtures/reporting_subscriptions/differential-regressions.json.docs/reporting-subscriptions-coverage.md:160.src/adcp/reporting/subscriptions/coverage.pyandexplain.py: exception composition and cutover handling, if the new vectors expose a difference.
Activity