You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug(v3-ref-seller): storyboard terminal-error codes mismatch on three update / create scenarios #701
Each is a terminal code that cascade rules can't mask — the seller is returning some other error code in adcp_error.code (or returning success). These are real spec-conformance regressions in the v3 reference seller, not storyboard fixture issues.
- create_media_buy_aggressive_terms [media_buy]: Error code is TERMS_REJECTED at /adcp_error/code
- update_unknown_media_buy [media_buy]: Error code is MEDIA_BUY_NOT_FOUND at /adcp_error/code
- update_unknown_package [media_buy]: Error code is PACKAGE_NOT_FOUND at /adcp_error/code
What to investigate
For each failure: pull the request/response from the storyboard run artifact (v3-storyboard-result-1.zip), confirm what code the seller actually returns, then map that to either:
a seller-side bug: handler returns the wrong code → fix handler
a translator-side bug: upstream code translation dropping/remapping the wrong code → fix the translation map
a spec-vs-code drift: the canonical AdCP error-code enum changed and the seller hasn't caught up → bump
#693's whole purpose is to make the storyboard gate assert on results. Until these three are resolved, the v3 storyboard CI job stays red, blocking #693 from landing or making main permanently red on merge.
Acceptance
All three storyboard steps pass with the spec-correct error code in adcp_error.code
Root cause documented (seller / translator / spec drift) per step in the fix PR
Verdict: ready-to-investigate-then-fix. Three real spec-conformance bugs in the v3-ref-seller translator path.
Investigation first (required before drafting): pull v3-storyboard-result-1.zip from run 25732467897, inspect actual adcp_error.code returned for each of the 3 steps, then categorize:
Most likely: handler-side bug in examples/v3_reference_seller/src/platform.py mapping seller-internal errors to wire codes. Translator (examples/v3_reference_seller/src/upstream.py) is the secondary suspect.
Coupled with #703 (same storyboard run, blocks the same gate). Likely worth one combined investigation pass even if separate PRs.
The handler logic that would emit the spec-correct terminal codes never runs — the request is rejected at the commercial-identity gate in _resolve_buyer_agent (src/adcp/decisioning/handler.py:441-552) before reaching the handler. get_adcp_capabilities works because it explicitly bypasses auth (handler.py:1279).
Fixing the auth regression in #703 resolves all three terminal-code mismatches here. Tracking the root cause + fix at #703.
Activity
bokelley commentedon May 14, 2026
Manual triage.
Verdict: ready-to-investigate-then-fix. Three real spec-conformance bugs in the v3-ref-seller translator path.
Investigation first (required before drafting): pull
v3-storyboard-result-1.zipfrom run 25732467897, inspect actualadcp_error.codereturned for each of the 3 steps, then categorize:create_media_buy_aggressive_terms→ expectedTERMS_REJECTEDupdate_unknown_media_buy→ expectedMEDIA_BUY_NOT_FOUNDupdate_unknown_package→ expectedPACKAGE_NOT_FOUNDMost likely: handler-side bug in
examples/v3_reference_seller/src/platform.pymapping seller-internal errors to wire codes. Translator (examples/v3_reference_seller/src/upstream.py) is the secondary suspect.Coupled with #703 (same storyboard run, blocks the same gate). Likely worth one combined investigation pass even if separate PRs.
bokelley commentedon May 14, 2026
Closing as duplicate of #703 based on investigation.
Evidence
Pulled the CI artifact
v3-storyboard-result.jsonfrom run 25732467897. All three failing steps return the identical wire payload:{ "adcp_error": { "code": "PERMISSION_DENIED", "message": "<registry-miss boilerplate from _resolve_buyer_agent>" } }create_media_buy_aggressive_termsupdate_unknown_media_buyupdate_unknown_packageThe handler logic that would emit the spec-correct terminal codes never runs — the request is rejected at the commercial-identity gate in
_resolve_buyer_agent(src/adcp/decisioning/handler.py:441-552) before reaching the handler.get_adcp_capabilitiesworks because it explicitly bypasses auth (handler.py:1279).Fixing the auth regression in #703 resolves all three terminal-code mismatches here. Tracking the root cause + fix at #703.