You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #753 (feat(adagents): publisher_domains compact form, revoked_publisher_domains, streaming fetch caps) hand-patched the cached 3.0 schemas to add the publisher_domains[] compact form on publisher-property-selector and revoked_publisher_domains[] on adagents.json. The commit message explicitly noted:
The cached schemas will be overwritten on the next make regenerate-schemas once upstream 3.0.10+ ships and ADCP_VERSION is bumped — the runtime / test changes are independent of the cached schema text.
Upstream is now at 3.0.12. The SDK is pinned to 3.0.7 (src/adcp/ADCP_VERSION). Time to bump and drop the hand-patch.
Scope
Edit src/adcp/ADCP_VERSION from 3.0.7 → 3.0.12.
Run make regenerate-schemas (executes scripts/sync_schemas.py).
Diff the regenerated src/adcp/types/_generated.py and src/adcp/types/generated_poc/**. Expected to converge with the hand-patched compact-form + revocation surfaces; flag any new shape that wasn't anticipated.
Re-run pytest tests/test_adagents.py tests/test_validation*.py to confirm runtime behaviour is unchanged.
Risks
3.0.7 → 3.0.12 is five point releases of drift. Likely other schema additions/changes between (new event types, field reordering, enum extensions). Each needs review on its own merits.
ad-tech-protocol-expert: flag-one-item — 3.0.x bumps are additive-only by policy; the concrete check is manual diff of adagents.json + publisher-property-selector.json to confirm upstream adopted the exact XOR compact-form shape from feat(adagents): publisher_domains compact form, revoked_publisher_domains, streaming fetch caps (closes #729) #753 (not a subtly different one that would silently drop the XOR constraint post-regen); an added or renamed Reason enum value would be caught by the existing test_revocation_reasons_match_generated_enum test, but a shape divergence on the selector discriminator would not.
code-reviewer: automate-with-caution — make regenerate-schemas produces SCHEMA_DELTAS.md which is machine-readable; a human must scan it for discriminated-union success/error variant numbering shifts, and also verify the string-keyed @_register_response_message decorators in src/adcp/types/base.py:100–197 still map to the correct semantic variant after any renumbering.
My take: Non-breaking maintenance, clear Execute-class — but the triage environment can't reach adcontextprotocol.org (CDN returns 403), so make regenerate-schemas cannot run here. Run it locally or in a CDN-accessible CI job, review SCHEMA_DELTAS.md + the base.py registrations, then merge.
Checklist for the implementer:
src/adcp/ADCP_VERSION → 3.0.12
make regenerate-schemas succeeds (checksum + Sigstore verify)
Activity
bokelley commentedon May 21, 2026
Triage
Classification: Enhancement (schema maintenance chore)
Bucket(s): validation, client
Status: ready-for-human
What the experts said:
flag-one-item— 3.0.x bumps are additive-only by policy; the concrete check is manual diff ofadagents.json+publisher-property-selector.jsonto confirm upstream adopted the exact XOR compact-form shape from feat(adagents): publisher_domains compact form, revoked_publisher_domains, streaming fetch caps (closes #729) #753 (not a subtly different one that would silently drop the XOR constraint post-regen); an added or renamedReasonenum value would be caught by the existingtest_revocation_reasons_match_generated_enumtest, but a shape divergence on the selector discriminator would not.automate-with-caution—make regenerate-schemasproducesSCHEMA_DELTAS.mdwhich is machine-readable; a human must scan it for discriminated-union success/error variant numbering shifts, and also verify the string-keyed@_register_response_messagedecorators insrc/adcp/types/base.py:100–197still map to the correct semantic variant after any renumbering.My take: Non-breaking maintenance, clear Execute-class — but the triage environment can't reach
adcontextprotocol.org(CDN returns 403), somake regenerate-schemascannot run here. Run it locally or in a CDN-accessible CI job, reviewSCHEMA_DELTAS.md+ thebase.pyregistrations, then merge.Checklist for the implementer:
src/adcp/ADCP_VERSION→3.0.12make regenerate-schemassucceeds (checksum + Sigstore verify)schemas/cache/3.0/adagents.json+core/publisher-property-selector.jsonmatch feat(adagents): publisher_domains compact form, revoked_publisher_domains, streaming fetch caps (closes #729) #753's intended shapesSCHEMA_DELTAS.mdshows no union-variant renumberingsrc/adcp/types/base.pyresponse-message registrations still correctpytest tests/test_adagents.py tests/test_validation*.pygreenTriaged by Claude Code. Session: https://claude.ai/code/session_01WQt7q5Rb3JQ6T7EUxqCX9W
Generated by Claude Code
chore(schemas): bump ADCP_VERSION 3.0.7 → 3.0.12 (closes #771) (#791)