You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expose sync_catalogs through decisioning platform specialism advertisement #786
adcp==5.6.0 includes the sync_catalogs MCP tool definition and SyncCatalogsRequest/response types, but the decisioning platform advertisement path does not currently expose it for any specialism.
In PlatformHandler.advertised_tools_for_instance(), tools are selected from SPECIALISM_TO_ADVERTISED_TOOLS. Current mappings include:
sales-catalog-driven -> media-buy lifecycle tools, but not sync_catalogs
no other specialism maps to sync_catalogs
The handler method currently falls back to the base ADCPHandler.sync_catalogs() not-supported implementation, so a platform cannot expose catalog discovery/sync through the normal DecisioningPlatform path the same way it can expose get_signals/activate_signal.
Why this matters
The AdCP docs/spec describe sync_catalogs as the task for catalog sync and discovery mode: omitting catalogs should return existing synced catalogs without modification. Catalog-driven sellers need this to let buyers discover existing account catalog state before sync_creatives / catalog-referenced media buys.
Expected SDK behavior
One of these would work:
Add sync_catalogs to an appropriate specialism mapping, likely sales-catalog-driven, and add a PlatformHandler.sync_catalogs decisioning-platform dispatcher analogous to sync_audiences; or
Add a dedicated catalog-sync specialism that advertises sync_catalogs and dispatches to DecisioningPlatform.sync_catalogs.
Correction: I filed this while working on signal catalog discovery, but is not the signals path. Signal catalog discovery is covered by plus the capability block. This issue should not be treated as a blocker for signals support. Closing to avoid mixing the media-buy catalog-sync question into signals work.
Correction to the prior comment: I filed this while working on signal catalog discovery, but sync_catalogs is not the signals path. Signal catalog discovery is covered by get_signals plus the signals.features.catalog_signals capability block. This issue should not be treated as a blocker for signals support.
Root cause confirmed: sync_catalogs tool and types shipped in adcp==5.6.0 but SPECIALISM_TO_ADVERTISED_TOOLS had no entry for sales-catalog-driven → sync_catalogs, and PlatformHandler had no dispatcher shim. Catalog-driven platforms couldn't surface the tool to buyers regardless of their specialism claim.
Wires sync_catalogs into SPECIALISM_TO_ADVERTISED_TOOLS["sales-catalog-driven"]
Adds PlatformHandler.sync_catalogs dispatcher (full SyncCatalogsRequest passed through — no arg_projector — so adopters retain access to req.delete_missing, req.dry_run, req.validation_mode)
Adds sync_catalogs to SalesPlatform Protocol body under the sales-catalog-driven-required section
Adds _require_platform_method guard → UNSUPPORTED_FEATURE (not INTERNAL_ERROR) when a non-catalog-driven platform receives the call
Pins the boot-fail contract with a validate_platform test, per-specialism filter tests, and _project_sync_catalogs unit tests
Pre-PR review by code-reviewer and dx-expert completed; all flagged items addressed before PR open. 191 tests pass.
Reopening for tracking. The original signals premise was wrong, but the later triage established a real catalog-driven specialism gap: sync_catalogs is not advertised/dispatched through the DecisioningPlatform path on current main. PR #790 is the existing candidate, but it is now conflicting and maintainer edits are disabled, so this may need a re-cut from main.
code-reviewer: No blockers. Flagged sync_catalogs in _OPTIONAL_PLATFORM_METHODS as semantically misleading (fixed before PR open) and noted the @runtime_checkable structural consequence as a documented tradeoff.
dx-expert: Blocker — adding sync_catalogs to the unified SalesPlatform Protocol body means isinstance(platform, SalesPlatform) now structurally requires sync_catalogs on every sales-* adopter, not just sales-catalog-driven. A sales-non-guaranteed adopter or agent-generated platform without sync_catalogs would silently fail the isinstance predicate. Recommends extracting a CatalogDrivenPlatform(SalesPlatform[TMeta], Protocol) sub-Protocol instead.
My take: The router's _protocol_method_names() walks vars(SalesPlatform) and synthesizes delegation methods — adding sync_catalogs to SalesPlatform is correct for the router to wire it through. There's no current production isinstance(platform, SalesPlatform) check that would break. The disagreement is about future DX risk for adopters who use isinstance as a capability predicate. Both expert positions are defensible; this is a design call @bokelley should make.
Design choice: Keep sync_catalogs on SalesPlatform (simpler, consistent with existing unified pattern, PR #790 is ready) vs. extract CatalogDrivenPlatform sub-Protocol (more precise, zero @runtime_checkable footgun risk). Draft PR #790 implements the unified-Protocol approach and is otherwise ready to merge (4325 tests pass, boot-fail gate, shim, projection, and advertisement all wired).
code-reviewer: No blockers. Design note on SalesPlatform Protocol body placement (intentional, mirrors sync_audiences pattern). Approved.
dx-expert: Approved after two passes. Previous blockers (missing example, _SyncSalesPlatform fixture gap) resolved. Migration note added.
My take: PR #790 had the correct implementation but conflicted against 6.1.0-beta.1 with maintainer edits disabled. Re-cut as draft PR #838 from current main — same logic, 235 tests pass.
Drafting PR #838 to replace the conflicting #790. Please review and close #790 as superseded if the new PR looks correct.
Activity
bokelley commentedon May 22, 2026
Correction: I filed this while working on signal catalog discovery, but is not the signals path. Signal catalog discovery is covered by plus the capability block. This issue should not be treated as a blocker for signals support. Closing to avoid mixing the media-buy catalog-sync question into signals work.
bokelley commentedon May 22, 2026
Closing because this was filed from the wrong signals premise; is unrelated to signals catalog discovery.
bokelley commentedon May 22, 2026
Correction to the prior comment: I filed this while working on signal catalog discovery, but
sync_catalogsis not the signals path. Signal catalog discovery is covered byget_signalsplus thesignals.features.catalog_signalscapability block. This issue should not be treated as a blocker for signals support.bokelley commentedon May 22, 2026
Triage outcome: Execute PR — additive non-breaking wire-up, no schema changes required.
Root cause confirmed:
sync_catalogstool and types shipped in adcp==5.6.0 butSPECIALISM_TO_ADVERTISED_TOOLShad no entry forsales-catalog-driven→sync_catalogs, andPlatformHandlerhad no dispatcher shim. Catalog-driven platforms couldn't surface the tool to buyers regardless of their specialism claim.Fix landed in draft PR #790:
sync_catalogsintoSPECIALISM_TO_ADVERTISED_TOOLS["sales-catalog-driven"]PlatformHandler.sync_catalogsdispatcher (fullSyncCatalogsRequestpassed through — noarg_projector— so adopters retain access toreq.delete_missing,req.dry_run,req.validation_mode)sync_catalogstoSalesPlatformProtocol body under thesales-catalog-driven-required section_require_platform_methodguard →UNSUPPORTED_FEATURE(notINTERNAL_ERROR) when a non-catalog-driven platform receives the callvalidate_platformtest, per-specialism filter tests, and_project_sync_catalogsunit testsPre-PR review by
code-revieweranddx-expertcompleted; all flagged items addressed before PR open. 191 tests pass.Generated by Claude Code
bokelley commentedon May 23, 2026
Reopening for tracking. The original signals premise was wrong, but the later triage established a real catalog-driven specialism gap: sync_catalogs is not advertised/dispatched through the DecisioningPlatform path on current main. PR #790 is the existing candidate, but it is now conflicting and maintainer edits are disabled, so this may need a re-cut from main.
feat(handlers): expose sync_catalogs through sales-catalog-driven spe…
feat(handlers): expose sync_catalogs through sales-catalog-driven spe…
bokelley commentedon May 23, 2026
Triage
Classification: Bug
Bucket(s): handlers
Status: ready-for-human
Milestone: omit
What the experts said:
sync_catalogsin_OPTIONAL_PLATFORM_METHODSas semantically misleading (fixed before PR open) and noted the@runtime_checkablestructural consequence as a documented tradeoff.sync_catalogsto the unifiedSalesPlatformProtocol body meansisinstance(platform, SalesPlatform)now structurally requiressync_catalogson everysales-*adopter, not justsales-catalog-driven. Asales-non-guaranteedadopter or agent-generated platform withoutsync_catalogswould silently fail the isinstance predicate. Recommends extracting aCatalogDrivenPlatform(SalesPlatform[TMeta], Protocol)sub-Protocol instead.My take: The router's
_protocol_method_names()walksvars(SalesPlatform)and synthesizes delegation methods — addingsync_catalogstoSalesPlatformis correct for the router to wire it through. There's no current productionisinstance(platform, SalesPlatform)check that would break. The disagreement is about future DX risk for adopters who useisinstanceas a capability predicate. Both expert positions are defensible; this is a design call @bokelley should make.Design choice: Keep
sync_catalogsonSalesPlatform(simpler, consistent with existing unified pattern, PR #790 is ready) vs. extractCatalogDrivenPlatformsub-Protocol (more precise, zero@runtime_checkablefootgun risk). Draft PR #790 implements the unified-Protocol approach and is otherwise ready to merge (4325 tests pass, boot-fail gate, shim, projection, and advertisement all wired).Triaged by Claude Code. Session: https://claude.ai/code/session_01RHG8jmrXLEyLjwaLTZHSi5
Generated by Claude Code
bokelley commentedon May 23, 2026
Triage
Classification: Bug (missing wire-up)
Bucket(s): handlers
Status: drafting-pr
Milestone: (omitted — beta branch)
What the experts said:
SalesPlatformProtocol body placement (intentional, mirrorssync_audiencespattern). Approved._SyncSalesPlatformfixture gap) resolved. Migration note added.My take: PR #790 had the correct implementation but conflicted against
6.1.0-beta.1with maintainer edits disabled. Re-cut as draft PR #838 from current main — same logic, 235 tests pass.Drafting PR #838 to replace the conflicting #790. Please review and close #790 as superseded if the new PR looks correct.
Triaged by Claude Code. Session: https://claude.ai/code/session_01NYBCVdwct1Hhz7GD1eaEHr
Generated by Claude Code
feat(handlers): expose sync_catalogs through sales-catalog-driven spe…