You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Allow signal-owned platforms to advertise get_signals without activate_signal #787
The current decisioning platform mapping treats signal-owned the same as signal-marketplace: both require and advertise get_signals plus activate_signal.
For publisher-owned signals that are already usable on the seller platform inventory, activate_signal is the wrong semantic. The seller returns its own first-party signals from get_signals; those signals can only be used on that seller inventory and are already active/usable in later media-buy targeting. There is no buyer-triggered destination provisioning step.
Current SDK behavior
adcp.decisioning.handler.SPECIALISM_TO_ADVERTISED_TOOLS["signal-owned"] includes activate_signal.
code-reviewer: Non-breaking for adopters (removing a requirement is less restrictive); two tests needed updating + new tests for both the required-method split and the advertised-tools divergence; @runtime_checkable Protocol gap documented via docstring warning. Approved after fixes.
ad-tech-protocol-expert: Option 1 (discovery-only) is semantically correct — activate_signal's destinations field supports both DSP activation and agent-type destinations, but the manifest discrepancy (signal_owned.exercised_tools includes activate_signal) is a spec authoring error, not a conformance requirement. exercised_tools describes what a buyer may encounter in a storyboard; it does not mandate implementation. Not a blocker.
My take: Option 1 (make signal-owned discovery-only) is the right fix — requiring activate_signal for first-party signals forces sellers to expose a semantically wrong method. The spec manifest discrepancy is surfaced in the PR body as a candidate spec errata item, with the alternative Option B path documented if the reviewer prefers to keep activate_signal advertised-but-optional.
Draft PR: #793 — implements REQUIRED_METHODS_PER_SPECIALISM["signal-owned"] = {"get_signals"} and SPECIALISM_TO_ADVERTISED_TOOLS["signal-owned"] = _SIGNALS_OWNED_ADVERTISED_TOOLS. All 4314 unit tests pass.
Closing as completed on current main. The decisioning surface now treats signal-owned as discovery-only: get_signals is required/advertised, activate_signal remains marketplace-only/optional, and OwnedSignalsPlatform plus tests document the split.
Activity
bokelley commentedon May 22, 2026
Triage
Classification: Bug (spec-misalignment in specialism method surface)
Bucket(s): handlers, client
Status: drafting-pr
Milestone: omitted
What the experts said:
@runtime_checkableProtocol gap documented via docstring warning. Approved after fixes.activate_signal'sdestinationsfield supports both DSP activation and agent-type destinations, but the manifest discrepancy (signal_owned.exercised_toolsincludesactivate_signal) is a spec authoring error, not a conformance requirement.exercised_toolsdescribes what a buyer may encounter in a storyboard; it does not mandate implementation. Not a blocker.My take: Option 1 (make
signal-owneddiscovery-only) is the right fix — requiringactivate_signalfor first-party signals forces sellers to expose a semantically wrong method. The spec manifest discrepancy is surfaced in the PR body as a candidate spec errata item, with the alternative Option B path documented if the reviewer prefers to keepactivate_signaladvertised-but-optional.Draft PR: #793 — implements
REQUIRED_METHODS_PER_SPECIALISM["signal-owned"] = {"get_signals"}andSPECIALISM_TO_ADVERTISED_TOOLS["signal-owned"] = _SIGNALS_OWNED_ADVERTISED_TOOLS. All 4314 unit tests pass.Triaged by Claude Code. Session: https://claude.ai/code/session_01Wj8hJ62PeTgk6J3aKn4PXp
Generated by Claude Code
bokelley commentedon May 23, 2026
Closing as completed on current main. The decisioning surface now treats signal-owned as discovery-only: get_signals is required/advertised, activate_signal remains marketplace-only/optional, and OwnedSignalsPlatform plus tests document the split.