You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: make examples/seller_agent.py storyboard job blocking #814
adcp#4907 is converging on using examples/seller_agent.py as the Phase 1 Python reference target for bidirectional storyboard interop CI, because that is already what this repo uses as its own storyboard reference seller.
Today, the storyboard job in .github/workflows/ci.yml is still marked continue-on-error: true:
storyboard:
name: AdCP storyboard runner — examples/seller_agent.pyruns-on: ubuntu-latest# Non-blocking until seller-agent content gaps in #304 are resolved.# Promote to required once overall_status: passing and controller_detected: true.continue-on-error: true
If examples/seller_agent.py is going to be treated as the Python reference target for @adcp/sdk release gating, Python CI should also treat that target as contract-bearing. Otherwise the upstream gate would be stricter than the repo that owns the reference seller.
Scope
Resolve or explicitly re-scope the remaining #304 content gaps that justified non-blocking mode.
Remove continue-on-error: true from the storyboard job once overall_status: passing and controller_detected: true are stable.
Confirm the job is required in branch protection if this repo uses required checks.
Acceptance
examples/seller_agent.py storyboard CI is blocking on PRs.
The job fails if overall_status != passing.
The job fails if controller_detected is false, unless the repo intentionally documents why controller detection is no longer required.
adcp#4907 can reference this job as the Python-owned signal for the Phase 1 reference target.
Classification: enhancement Bucket(s): (CI configuration — no standard bucket label matches; noted in run summary) Status: drafting-pr Milestone: (omitted — no version target specified)
What the experts said:
code-reviewer: change is correct and sufficient; timeout-minutes: 15 appropriate for boot profile; flagged hung-startup risk without a job-level timeout
My take: Both prerequisite issues are closed and the Assert pass step's hard assertions are already in place. Removing continue-on-error: true and adding a job-level timeout-minutes to all four storyboard jobs is the complete change. Branch protection enrollment (acceptance criterion #3) requires a manual repo-settings step after merge — noted in the PR description.
Activity
ci(storyboard): promote seller_agent storyboard job to blocking gate
bokelley commentedon May 22, 2026
Triage
Classification: enhancement
Bucket(s): (CI configuration — no standard bucket label matches; noted in run summary)
Status: drafting-pr
Milestone: (omitted — no version target specified)
What the experts said:
timeout-minutes: 15appropriate for boot profile; flagged hung-startup risk without a job-level timeouttimeout-minutesto peer jobs for consistency; stale(see #304)error message updated to actionable DemoStore method namesMy take: Both prerequisite issues are closed and the
Assert passstep's hard assertions are already in place. Removingcontinue-on-error: trueand adding a job-leveltimeout-minutesto all four storyboard jobs is the complete change. Branch protection enrollment (acceptance criterion #3) requires a manual repo-settings step after merge — noted in the PR description.Drafted PR: #819
Triaged by Claude Code. Session: https://claude.ai/code/session_01ByUxA2yuT7WcXrPtsD4yuG
Generated by Claude Code