Repository navigation
Description
Context
Python SDK 5.7.0 includes generated Pydantic models for accounts[].notification_configs[], NotificationConfig, and the 3.1 wholesale feed webhook schema under generated/internal paths. It also has WebhookSender.send_raw(...), which can send any pre-shaped payload safely.
For seller implementations wiring AdCP 3.1 catalog notifications, the remaining work is easy to get subtly wrong:
- importing internal
adcp.types.generated_poc.*modules instead of stable SDK aliases - hand-building
WholesaleFeedWebhook/WholesaleFeedEventdicts - preserving account-anchored
subscriber_id/account_idsemantics - preserving
event_typesfilters - preserving declarative replace semantics for
accounts[].notification_configs[] - emitting product/signal notifications through the signed sender with byte-exact body/signature behavior
Problem
There is no stable top-level SDK surface for these catalog webhook building blocks. In 5.7.0:
import adcp
from adcp import types
hasattr(adcp, "NotificationConfig") # False
hasattr(types, "NotificationConfig") # False
hasattr(adcp, "WholesaleFeedWebhook") # False
hasattr(types, "WholesaleFeedWebhook") # False
hasattr(adcp, "WholesaleFeedEvent") # False
hasattr(types, "WholesaleFeedEvent") # FalseWebhookSender exposes send_mcp, send_collection_list_changed, send_property_list_changed, etc., but not a dedicated send_wholesale_feed(...) helper. Downstream sellers can use send_raw, but that leaves envelope construction and protocol invariants to each implementation.
Proposal
Add stable SDK exports and a helper for AdCP 3.1 catalog notifications:
- export
NotificationConfigfromadcpandadcp.types - export
WholesaleFeedWebhookandWholesaleFeedEventfrom stableadcp/adcp.typespaths - add a builder or sender helper, e.g.:
await sender.send_wholesale_feed(
url=subscription.url,
subscriber_id=subscription.subscriber_id,
account_id=account_id,
notification_type="signal.updated",
wholesale_feed_version=feed_version,
cache_scope="public",
event=event,
)Optionally also provide small event builders for product.created/updated/priced/removed and signal.created/updated/priced/removed.
Acceptance criteria
- Stable imports for
NotificationConfig,WholesaleFeedWebhook, andWholesaleFeedEventwithout usinggenerated_pocmodules. - Helper validates required account/subscriber fields and event type/entity consistency.
- Helper sends through
WebhookSenderso RFC9421/HMAC/Bearer behavior and SSRF protections remain centralized. - Tests cover product and signal events, including
subscriber_id,account_id,wholesale_feed_version,cache_scope, andevent_typesfiltering guidance. - Docs include seller-side guidance for applying
accounts[].notification_configs[]fromsync_accountsand firing catalog webhooks.
Downstream impact
This would prevent every Python seller implementation from hand-rolling wholesale feed webhook envelopes and reduce drift with the JS SDK catalog-sync receiver behavior.
Activity
bokelley commentedon May 23, 2026
Closing as completed by merged #833. That PR added stable NotificationConfig / WholesaleFeedWebhook / WholesaleFeedEvent exports plus WebhookSender wholesale-feed sending helpers, docs, and tests.