Skip to content

Add helper for durable webhook proof-of-control challenges #839

Closed

Description

@bokelley

Context

The Python SDK 6.1.0 beta now has the key pieces salesagent needed for AdCP 3.1 catalog webhooks: NotificationConfig, wholesale feed webhook models, destination URL validation, and webhook sender/signing helpers.

One remaining duplicated-implementation risk is proof-of-control for durable webhook subscriptions registered through sync_accounts.accounts[].notification_configs[].

Salesagent PR #561 implemented this locally:

  • validate/normalize the destination URL
  • issue a webhook.challenge POST before activating a new/changed active durable subscription
  • require the receiver to echo the challenge value
  • allow active: false configs to be stored without a challenge

Ask

Add a Python SDK helper for durable webhook proof-of-control challenges, once the spec-level semantics are settled.

Useful surface could be something like:

result = await challenge_webhook_destination(
    url=config.url,
    account_id=account_id,
    subscriber_id=config.subscriber_id,
    authentication=config.authentication,
    timeout=..., 
)

or a lower-level helper that builds/validates the challenge payload and response.

Related spec issue

adcontextprotocol/adcp#4979

Why it matters

Sellers implementing durable webhook registration should not each hand-roll URL validation, challenge payloads, response parsing, timeout behavior, and auth/signing behavior differently.

Activity

  1. added
    enhancementNew feature or request
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on May 24, 2026
  2. bokelley commented on May 24, 2026

    @bokelley
    ContributorAuthor

    Triage

    Classification: Feature request
    Bucket(s): client, cross-repo (neither label found in this repo — flagged in run summary)
    Status: deferred

    What the experts said:
    Not consulted — pre-classification defer: issue is explicitly conditioned on spec issue resolution.

    My take: The SDK already has the webhook plumbing (NotificationConfig, destination URL validation, webhook sender/signing helpers) to host this helper once adcontextprotocol/adcp#4979 settles the proof-of-control semantics. Implementing before spec settlement risks shipping the wrong challenge shape (payload schema, echo mechanism, error codes, auth threading) and locking in a surface that the spec then changes.

    Blocked-on: adcontextprotocol/adcp#4979 — resurfaces on merge.


    Triaged by Claude Code. Session: https://claude.ai/code/cse_01B5deFAQRMCvBC1ZMcdtzWK


    Generated by Claude Code

  3. added and removed
    claude-triagingTriage routine is actively working on this issue (1-3 min)
    on May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions