Skip to content

fix(compat): preserve installment collection identity on downgrade - #1903

Open
aleksUIX wants to merge 1 commit into
adcontextprotocol:mainfrom
aleksUIX:claude/issue-1895-installment-collection
Open

aleksUIX wants to merge 1 commit into
adcontextprotocol:mainfrom
aleksUIX:claude/issue-1895-installment-collection

Conversation

@aleksUIX

@aleksUIX aleksUIX commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

A 3.2 get_products response can name an installment's parent through collection_ref. Downgrading to 3.1 currently drops it even when the product identifies one publisher namespace.

Map that reference to collection_id before projection when the publisher is unambiguous and matches. Preserve explicit shorthand and the caller's input. Keep loss reporting for references that 3.1 cannot represent safely.

Refs #1895. This targets main per RELEASING.md; next needs a forward-port after merge. The patch applies cleanly to the inspected next head, but runtime testing there is pending.

Validation:

  • Conversion, sweep, governance and loss-logging suites: 313 passed, 42 existing conditional skips.
  • Eight new regressions cover schema validity, parent identity, explicit shorthand, ambiguous publishers, input preservation and strict MCP handling. Unchanged main fails both parent-identity assertions.
  • Source lint, changed-file Black, source mypy, strict adopter mypy, pyright and suppression checks pass.
  • Syntax, versioned-stub and versioned-base generation checks pass. Hosted schema/model regeneration now passes with no diff; the local post-generation scratch-path restriction remains documented.
  • Full local CI is incomplete. The interrupted broad run encountered missing fixture paths, subprocess deadlines and a process-signalling restriction.

Hosted CI passes at 5c54e249: Python 3.10–3.13, schema/model regeneration, Postgres conformance and the selected storyboard/installed-artifact jobs are successful. The Python 3.12 job reports 14,185 unit/runtime passes and 4,723 conformance passes, with its recorded skips and expected failure. CI run.

Ready for review. Runtime testing on next remains pending. The incomplete local broad run above is not claimed as a pass.

Signed-off-by: Aleksander Sekowski <kontakt.sekowski@gmail.com>
@aleksUIX
aleksUIX marked this pull request as ready for review November 17, 2026 05:29

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve.

Clean version-translation fix. _downgrade_installment_collection_refs maps 3.2 collection_ref → 3.1 collection_id shorthand only when the product's collection selectors prove exactly one publisher namespace and the ref's publisher_domain matches — matching the documented 3.2/3.1 installment deprecation semantics. Fails closed on multiple publishers, missing collections, publisher mismatch, or conflicting shorthand, leaving collection_ref for _project to strip and report as a field_unavailable loss; operates on the deepcopied result so input is unmutated. This is the DR-0032/0033 Moves pathway with loss-reporting fallback; upgrade direction is a genuine no-op since 3.2 retains collection_id. Eight tests cover the matrix (schema validity, parent identity, shorthand preservation, ambiguity, strict MCP), satisfying the mandatory-pathway-test requirement.

No blocking or Medium findings. high_risk is true only because src/adcp/compat/versions.py was modified, but the reviewer surfaced no medium-or-higher concern on it, so the modification is presumed safe (does not trigger row 5). gated_paths is false, no no-auto-approve team match, first review. Rows 1–8 do not fire → row 9 approve.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant