Repository navigation
Conversation
Signed-off-by: Aleksander Sekowski <kontakt.sekowski@gmail.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve.
Clean version-translation fix. _downgrade_installment_collection_refs maps 3.2 collection_ref → 3.1 collection_id shorthand only when the product's collection selectors prove exactly one publisher namespace and the ref's publisher_domain matches — matching the documented 3.2/3.1 installment deprecation semantics. Fails closed on multiple publishers, missing collections, publisher mismatch, or conflicting shorthand, leaving collection_ref for _project to strip and report as a field_unavailable loss; operates on the deepcopied result so input is unmutated. This is the DR-0032/0033 Moves pathway with loss-reporting fallback; upgrade direction is a genuine no-op since 3.2 retains collection_id. Eight tests cover the matrix (schema validity, parent identity, shorthand preservation, ambiguity, strict MCP), satisfying the mandatory-pathway-test requirement.
No blocking or Medium findings. high_risk is true only because src/adcp/compat/versions.py was modified, but the reviewer surfaced no medium-or-higher concern on it, so the modification is presumed safe (does not trigger row 5). gated_paths is false, no no-auto-approve team match, first review. Rows 1–8 do not fire → row 9 approve.
A 3.2
get_productsresponse can name an installment's parent throughcollection_ref. Downgrading to 3.1 currently drops it even when the product identifies one publisher namespace.Map that reference to
collection_idbefore projection when the publisher is unambiguous and matches. Preserve explicit shorthand and the caller's input. Keep loss reporting for references that 3.1 cannot represent safely.Refs #1895. This targets
mainperRELEASING.md;nextneeds a forward-port after merge. The patch applies cleanly to the inspectednexthead, but runtime testing there is pending.Validation:
Hosted CI passes at
5c54e249: Python 3.10–3.13, schema/model regeneration, Postgres conformance and the selected storyboard/installed-artifact jobs are successful. The Python 3.12 job reports 14,185 unit/runtime passes and 4,723 conformance passes, with its recorded skips and expected failure. CI run.Ready for review. Runtime testing on
nextremains pending. The incomplete local broad run above is not claimed as a pass.