Repository navigation
feat(reporting): bind package source coverage to media buys - #1928
Open
rachitm022 wants to merge 1 commit into
Open
rachitm022 wants to merge 1 commit into
rachitm022 wants to merge 1 commit into
Conversation
rachitm022
requested review from
KonstantinMirin and
bokelley
as code owners
November 19, 2026 17:53
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — additive V2 package-aware reporting-source contract, no blocking findings.
What I checked:
- No no-auto-approve team match;
gated_paths: false;high_risk: false; first review of this PR. - Semver signal: V2 classes subclass V1;
__all__only gains entries (no removals/renames), sofeat(reporting):is the correct non-breaking prefix — no public-surface break ships under a non-breaking signal. - DR-0032/33 version pathway is "Refused": version-negotiation gate in
_validate_request_against_capabilitiesand manifest/response checks fail-closed on mismatch, and this is covered (test_v2_only_capability_rejects_v1_request, test_one_executor_can_negotiate_v1_and_v2_requests, test_mixed_request_manifest_versions_fail_admission). - Fingerprint identity binding verified:
publication_content_fingerprint_v2andcoverage_denominator_fingerprint_v2bind media_buy_ids/pairs so distinct buys yield distinct fingerprints even on empty coverage. - Row-fencing/explicit_zero logic, unique-package-pair enforcement, and strict echo of media_buy_ids/constituents all checked and safe; heavily tested (756-line contract test file).
Reviewer found no Critical/High/Medium findings. No decision-table trigger fired (rows 1–8 all negative), so this falls through to row 9 → approve.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Package reporting needs a source contract that binds each package to its parent media buy. An empty completed package report must retain its exact buy selector without inventing a buy-level metric cell or zero row.
What changed
media_buy_idsseparately from package-pair constituents; V2 fingerprints and manifest admission bind both.(media_buy_id, package_id)pairs, including zero-valued rows.(media_buy_id, package_id, requested dimension values)in both validation paths while retaining rows for distinct requested dimension values.Verification
make lintmake typecheckgit diff --checkThe prior broad
make testrun was canceled at 94% before a final result and was not rerun.make lint-allreports 49 E501 line-length errors outside this patch; Ruff checks for the three changed files pass.Integration
Jakarta owns the inline source's pre-stage validator invocation and final package admission. This PR changes only the source contract and its tests. Public Core reporting obligation and flat coverage schemas are unchanged.
Tracks AI-22388.