Repository navigation
chore(registry): sync generated registry types with the published OpenAPI - #3727
Merged
Merged
Conversation
…nAPI Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — generated registry snapshot refresh for adcp#8576.
Checked:
- No blocking findings — reviewer surfaced no critical/high/medium issues (rows 1 and 2 of the decision table do not fire;
gated_paths: false). - Additive, witness-faithful change — adds nullable
verdict_explanationplusStoryboardVerdictExplanation/StoryboardVerdictContributorschemas toregistry.yamlandtypes.generated.ts. Generated types match the schema at all three sites; both changed source files are generated/vendored with no hand edits. - Changeset correctness —
patchmatches established precedent for registry snapshot refreshes (#3669, identical shape); the change is additive and required-and-nullable, sopatchdoes not understate impact. - High-risk flag —
schemas/registry/registry.yaml (modified)matchesschemas/registry/**, but the modification is additive and preserves the file's contract with no medium-or-higher finding, so it is presumed safe (row 5 requires a medium finding to escalate; none exists).
No author-team gate, no gated-paths gate, no deletions, no sensitive-category findings. Falls through to row 9 → approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks CI on
mainand every open TS PR, including #3725.The "Generated, Docs & Formatting" lane regenerates the registry types from the live spec at
https://agenticadvertising.org/openapi/registry.yamland fails on any drift. The published spec gained the storyboard verdict explanation (adcontextprotocol/adcp#8576), so new PRs fail "Validate generated files are in sync".Regenerated with the repo's own command,
npm run generate-registry-types -- --sync. No hand edits.Added, nullable and additive:
verdict_explanationon storyboard resultsStoryboardVerdictExplanationandStoryboardVerdictContributorschemasThe generated types are exported through
@adcp/sdk's registry types, so this carries a patch changeset, as earlier syncs (#3669, #3373) did. The 16.x sync is a separate PR.🤖 Generated with Claude Code