Skip to content

chore(registry): sync generated registry types with the published OpenAPI - #3727

Merged
bokelley merged 1 commit into
mainfrom
chore/sync-registry-types-verdict-explanation
Nov 16, 2026
Merged

bokelley merged 1 commit into
mainfrom
chore/sync-registry-types-verdict-explanation

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Unblocks CI on main and every open TS PR, including #3725.

The "Generated, Docs & Formatting" lane regenerates the registry types from the live spec at https://agenticadvertising.org/openapi/registry.yaml and fails on any drift. The published spec gained the storyboard verdict explanation (adcontextprotocol/adcp#8576), so new PRs fail "Validate generated files are in sync".

Regenerated with the repo's own command, npm run generate-registry-types -- --sync. No hand edits.

Added, nullable and additive:

  • verdict_explanation on storyboard results
  • the StoryboardVerdictExplanation and StoryboardVerdictContributor schemas

The generated types are exported through @adcp/sdk's registry types, so this carries a patch changeset, as earlier syncs (#3669, #3373) did. The 16.x sync is a separate PR.

🤖 Generated with Claude Code

…nAPI

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — generated registry snapshot refresh for adcp#8576.

Checked:

  • No blocking findings — reviewer surfaced no critical/high/medium issues (rows 1 and 2 of the decision table do not fire; gated_paths: false).
  • Additive, witness-faithful change — adds nullable verdict_explanation plus StoryboardVerdictExplanation/StoryboardVerdictContributor schemas to registry.yaml and types.generated.ts. Generated types match the schema at all three sites; both changed source files are generated/vendored with no hand edits.
  • Changeset correctness — patch matches established precedent for registry snapshot refreshes (#3669, identical shape); the change is additive and required-and-nullable, so patch does not understate impact.
  • High-risk flag — schemas/registry/registry.yaml (modified) matches schemas/registry/**, but the modification is additive and preserves the file's contract with no medium-or-higher finding, so it is presumed safe (row 5 requires a medium finding to escalate; none exists).

No author-team gate, no gated-paths gate, no deletions, no sensitive-category findings. Falls through to row 9 → approve.

@bokelley
bokelley merged commit 6c74752 into main Nov 16, 2026
45 checks passed
@bokelley
bokelley deleted the chore/sync-registry-types-verdict-explanation branch November 16, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant