Repository navigation
chore(release): prepare ESA SDK 17 prerelease lane - #3737
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean release-infra PR.
This PR touches only .changeset/pre.json, .github/workflows/release.yml, and docs/development/NPM-DIST-TAGS.md (3 files, 10 additions / 3 deletions) against 17.x-esa. It flips the prerelease tag beta→esa, adds a 17.x-esa push trigger with a branch-scoped ADCP_NPM_TAG=adcp-3.3-esa, and documents the maintenance channel.
The correctness-critical seam was verified: the ${{ ... || '' }} ternary yields an empty string on main/16.x, which publish-adcp-release.ts:57 treats as falsy and falls through to preState.tag, preserving beta (main) and latest (16.x) publishing. Only 17.x-esa gets the adcp-3.3-esa dist-tag, avoiding collision with main's beta. No changeset is required since no src/lib/**, bin/**, or published package.json paths are touched. Doc prose is consistent with no stale blob/main links.
No blocking or medium findings. No high-risk flag, no gated paths, no author team gate, no prior decision. Falls through to row 9.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — CI-only change, no blocking or medium findings.
This PR scopes to three CI-only files: a scoped npm-audit exception verifier (verify-scoped-audit-exception.cjs), its node:test suite, and the ci.yml wiring (plus .changeset/pre.json, release.yml, and a docs file). The verifier is tightly scoped to the pinned picomatch GHSA advisory, time-boxed to 2026-11-25, and fail-closed on any new advisory, path drift, version change, or audit/registry failure — all exercised by the tests. Root package name matches the asserted @adcp/sdk.
No wire/SDK surface touched (src/lib/** untouched), so no changeset required (.github/** changes). Witness-not-translator, version-pathway, official-transport, and changeset-vs-wire mandates are not implicated. gated_paths is false and review_decision is APPROVED; high_risk is false; no no-auto-approve team match. The prior clean approve stands and remains valid.
Decision table: no critical/high (row 1 n/a), gate satisfied (row 2 n/a), no deletions in high-risk paths (row 3 n/a), no medium findings (rows 4/5/8 n/a), prior decision was approve (row 6 n/a), no team gate (row 7 n/a) → falls through to row 9: approve.
Why
The package-coverage SDK fix is merged into
17.x-esa, but the branch still has Changesetsbetapre-mode and no release trigger. A maintenance package needs its ownesaprerelease version andadcp-3.3-esanpm tag so it cannot collide with SDK 17 releases frommain.What changed
betapre-mode and immediately enteresapre-mode. This changes only.changeset/pre.json; the SDK package stays at17.0.0-beta.22until Changesets versions the pending release PR.17.x-esato the release workflow's push branches. On that branch only, the release job setsADCP_NPM_TAG=adcp-3.3-esa; main and 16.x retain their existing behaviour.The existing SDK changeset remains pending. This PR does not edit package versions,
ADCP_VERSION, schemas, creative code, or the publish script. It carries the maintenance release lines from #3734 to this branch; #3734 remains a separate PR againstmain.Safety and release sequence
The release workflow has only a
pushtrigger formain,16.x, and17.x-esa. Pushing this feature branch or opening this PR cannot run it or publish a package. A maintainer's merge into17.x-esawill activate the release workflow. Its reference-seller interop job runs first. With the pendingsdk-core-package-coveragechangeset, Changesets selects version mode and opens a release PR. A maintainer must review and merge that release PR before the publish step runs. Before merging this setup PR, confirm the pending changeset still exists andchangeset statusstill reports an SDK release; otherwise the action could select publish mode.Verification
changeset statusreports@adcp/sdk17.0.0-beta.22→17.0.0-esa.23fromsdk-core-package-coverage; reporting-storage remains0.3.0-beta.6. npm currently has neither17.0.0-esa.23nor theadcp-3.3-esadist-tag.ADCP_NPM_TAG=adcp-3.3-esa npm run release -- --dry-runselected that dist-tag and kept theesaprerelease identifier. It did not publish.npm run lint:workflows, Prettier on all three changed files, andgit diff --checkpassed.