Repository navigation
Conversation
…ns on refine_proposals validateRefineProposalsRequest accepted only revise and finalize, so AgentClient.refineProposals (and the storyboard runner that dispatches through it) could not send extend_hold, and createAdcpServer refused it before a seller's handler ran. - Requests: extend_hold is accepted on AdCP 3.3 with only proposal_id, action and ext; a batch containing it contains only extend_hold entries; a known seller capability set must declare proposal_refinement.hold_extension (VALIDATION_ERROR otherwise). include_collections is a 3.3 boolean. Both are refused on 3.2, and unknown keys are still rejected. - Responses: an extension verifies like a finalize (one committed successor, parent is the source, future expiry, all-or-none). A 3.3 contract accepts collections (when requested, each checked against core/response-collection.json) and expected_confirmation_at on a submitted response; a 3.2 contract still rejects them. - verifyHoldExtension and ProposalNegotiator.extendHold check the successor against the source: same terms_digest, hold_policy and hold_placed_at, later expires_at. - createAdcpServer projects hold_extension to 3.3 callers only and adds media_buy.hold_extension to experimental_features when declared. - createProposalRefinementHandler refuses hold_extension until #3600. Closes #3601 Refs #3724 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean PR adding AdCP 3.3 refine_proposals support (extend_hold, include_collections/collections, expected_confirmation_at).
Verified against repo-specific mandates:
- DR-0033 pathway-back: extend_hold and related wire changes are fail-closed on 3.2 (both request and response refused), satisfying the previous-minor handling requirement.
- Witness-not-translator: verifyHoldExtension provides anti-fabrication/witness checks catching term and hold mutation on extension; no re-shaping or placeholder injection.
- Changeset correctness: correct minor changeset present for the src/lib/** wire change.
- Schema validation: collections handled via schema-backed validation.
No Critical/High/Medium findings; no inline comments posted.
Decision table: no blocking findings (rows 1, 6 N/A); gated_paths is false (row 2 N/A); high_risk is false (rows 3, 5 N/A); no medium findings in data-loss/schema/infra (row 4 N/A); no prior escalation (row 6 N/A); no no-auto-approve team match (row 7 N/A); fewer than three medium findings (row 8 N/A). Falls through to row 9 → approve.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — additive AdCP 3.3 refine_proposals support (extend_hold action, include_collections/collections, expected_confirmation_at).
No critical/high/medium findings. Traced every load-bearing path:
- Request validation gates extend_hold/include_collections to 3.3 and fails closed on an undeclared hold_extension capability.
- Response verification flags collections without include_collections and strips the 3.3 keys for 3.2 contracts (RESPONSE_KEYS_33) — DR-0033 backward-compat pathway handled.
- verifyHoldExtension anchors on terms_digest/hold_policy/hold_placed_at plus a later expires_at.
- Engine refuses extend_hold at construction per #3600; capabilities projection adds media_buy.hold_extension only for 3.3 callers.
- Witness-not-translator intact (no fabrication).
- Changeset present and correctly minor.
Comprehensive tests including an end-to-end MCP round-trip. Non-blocking nit: the 3.2-refusal (DR-0033) pathway is tested in the feature's own test files rather than version-translation.test.js, but coverage is thorough and a regression would not be silent — does not meet the medium threshold.
gated_paths is false; review_decision is APPROVED; no author team gate; high_risk false. No rows 1–8 fire → row 9 approve.
Closes #3601
Refs #3724
Problem
validateRefineProposalsRequestaccepted onlyreviseandfinalize. Everyextend_holdentry failed withaction must be revise or finalizebefore it was sent.AgentClient.refineProposalscalls it, and the storyboard runner dispatchesrefine_proposalsthrough that method, so the 3.3media_buy_seller/hold_extensionstoryboard couldn't send the action.createAdcpServerruns the same validator before a seller's handler, so an SDK-hosted seller answeredextend_holdwith a validation error even when it declaredmedia_buy.proposal_refinement.hold_extension.#3725 left the other 3.3 additions to this task out of scope: top-level
include_collections, andcollectionsandexpected_confirmation_atin the response.Fix
Every shape comes from the vendored
3.3.0-rc.0schemas (refine-proposals-request.json,proposal-refinement.json,refine-proposals-response.json, the capabilities response andcore/response-collection.json).Requests (
negotiation/buyer.ts)extend_holdis accepted on AdCP 3.3. Likefinalize, an entry carries onlyproposal_id,actionandext. Every revise field and every unknown key is still rejected.extend_holdmust contain onlyextend_holdentries, as the schema'srefinementsrule requires.proposal_refinement.hold_extensionmust betrue. Otherwise the action fails withVALIDATION_ERROR, which is what the spec requires of a seller that doesn't declare it. Finalize and revise aren't gated.include_collectionsis accepted as a boolean on 3.3.extend_hold requires AdCP 3.3). This follows the existinginstallment_changesgate.extractProposalRefinementSupportcarrieshold_extensionthrough.Responses (
negotiation/verification.ts)extend_holdmay return onlyfinalizedorunable. The spec reports a successful extension asfinalized. The existing finalize checks apply: one committed successor,parent_proposal_idequal to the source, a fresh ID, a futureexpires_at, and all-or-none across the batch.collectionsis allowed on a completed response andexpected_confirmation_aton a submitted one (it must be an RFC 3339 date-time). A 3.2 contract still rejects both as undeclared keys.collectionsentry is validated againstcore/response-collection.json. Returningcollectionswhen the request didn't setinclude_collectionsis a verification issue, because sellers MUST NOT do it. Duplicate keys and unreferenced entries are not failures, because the spec tells buyers to fall back or ignore them.verifyHoldExtension(source, successor). Response verification sees only the source's ID, so this check uses the source proposal itself. The successor must keep the source'sterms_digest,hold_policyandhold_placed_atand carry a laterexpires_at.ProposalNegotiator.extendHold(proposal)sends the action and runs these checks. It doesn't check bounds againstmax_total_duration.Server (
server/create-adcp-server.ts)hold_extensionreaches 3.3 callers only. The existing release projection already strips it for 3.2 callers, and a test now covers that.hold_extensionis declared,media_buy.hold_extensionis added toexperimental_features. The 3.3 capabilities schema requires it (allOf/15). Without it, the buyer client flagged the seller's capabilities as invalid. These three lines are next to theproposal_refinementprojection and don't touch version negotiation (createAdcpServer: a prerelease preview ceiling leaks into stable negotiation and stable response shapes #3597).refine_proposalslistsinclude_collections.Seller engine (
negotiation/seller.ts)createProposalRefinementHandlercan't place, transfer or supersede holds. That work is #3600. Until then, it refuseshold_extension: truewhen constructed, and its own validator answersextend_holdwithVALIDATION_ERROR. This stops it from staging a committed successor without moving the hold. Sellers serveextend_holdfrom a customrefine_proposalshandler, which now receives the request.Types
ExtendHoldProposalRefinementis added to theProposalRefinementunion. Exhaustive switches onactionneed the new arm, as the 16→17 migration guide already says.ProposalRefinementCapabilities.hold_extensionRefineProposalsRequest.include_collectionsRefineProposalsCompletedResponse.collections(ResponseCollection[])RefineProposalsSubmittedResponse.expected_confirmation_athold_extensionissue codeRefineProposalsVerificationRequestThe media-buy compatibility coordinator passes
include_collectionsthrough to verification on the compact path.Tests
test/lib/proposal-hold-extension.test.js(new, 17 tests):extend_holdaccepted on 3.3, alone or in a batch, withext; refused on 3.2. Each revise field, an unknown key, and a non-objectextare rejected at the right field. Mixed batches and duplicate IDs are rejected. Thehold_extensiongate returnsVALIDATION_ERROR, and a non-boolean declaration is rejected. Discovery carries the flag.include_collectionsmust be a boolean and is refused on 3.2.unableresults withhold_unavailable,batch_abortedandsource_unavailable.revisedoutcome fails, and so does a partly successful batch. Wrong lineage, an expired hold and a reused ID also fail.collectionspasses when requested and fails when it wasn't requested, is empty, or has a malformed entry.expected_confirmation_atpasses only on a submitted response.verifyHoldExtensionpasses a correct successor. It fails on each changed field: expiry,hold_placed_at,hold_policy, parent or terms, and it fails when the source is a draft.ProposalNegotiator.extendHoldreturns a verified successor. It catches a seller that changed the terms, and it gates on the capability before any transport call.hold_extensionand returnsVALIDATION_ERRORforextend_hold.AgentClient.refineProposals, the method the storyboard runner dispatches through, sendsextend_holdandinclude_collectionsto a 3.3createAdcpServerseller. The response, includingcollections, passes strict validation and verification. Without the declaration, the call is refused before it is sent.test/lib/proposal-negotiation-server.test.js, throughcreateAdcpServerwith strict validation:extend_holdandinclude_collectionsreach the handler, and a finalized successor withcollectionspasses strict response validation.expected_confirmation_atpasses strict response validation.hold_extensionis refused withVALIDATION_ERRORatrefinements[0].actionbefore the handler runs.hold_extensionandmedia_buy.hold_extensionreach 3.3 callers only.test/lib/proposal-negotiation-validation.test.js: updated the unknown-action message.Local:
typecheck,build:lib,lint(0 errors) and prettier pass, andgenerate-agent-docsshows no drift.test/lib/proposal-*.test.jspass.Storyboards
The vendored
media_buy_seller/hold_extensionstoryboard (3.3.0-rc.0) builds bare{ proposal_id, action: "extend_hold" }entries. It sends them throughAgentClient.refineProposals, and the storyboard's own narrative names this issue as the blocker. The end-to-end test above shows the request now reaches the seller and the result passes verification.I did not run the full storyboard. No seller in this repo implements hold policy and seeding, which is #3600 here and the training agent in adcontextprotocol/adcp#8181. Grading the storyboard needs one of those. The known-failing skips in that training-agent matrix can come off once this ships.
Not included
unableextension may use. The spec describeshold_unavailable,batch_abortedandsource_unavailablefor this action but doesn't limit them, so the verifier doesn't either, as with finalize.expires_atagainsthold_placed_at + max_total_duration. That is duration arithmetic, and the storyboard grades it as advisory.extend_holdorinclude_collections.🤖 Generated with Claude Code