Repository navigation
fix(deps): clear audit advisories and accept unpatched picomatch ReDoS - #3744
Conversation
The Security Audit job fails on every PR since GitHub reviewed GHSA-fc5q-39xc-vjpf (picomatch <=4.0.7, high) on 2026-11-17. No picomatch release fixes it (4.0.7 is the latest; micromatch/picomatch#194 is open), so neither npm audit fix nor an overrides pin can clear it. Every other high finding (changesets, tinyglobby, fdir, tsup, typescript-eslint, ts-to-zod, json-schema-to-typescript, sucrase, @oclif/core) is a dependent of that one advisory. - Lockfile: hono 4.13.13 -> 4.13.19, @hono/node-server 1.19.17 -> 1.19.19, fast-xml-parser 5.11.2 -> 5.12.1 (with fast-xml-builder 1.3.2, strnum 2.5.1, is-unsafe 2.0.3). Supersedes dependabot #3697. - CI: the audit step runs scripts/security-audit.mjs, which fails on any high or critical advisory not listed in its accepted set. The set holds only GHSA-fc5q-39xc-vjpf, with its justification, and warns when an entry goes stale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — security-audit hardening PR with no blocking or medium findings.
Scope: new scripts/security-audit.mjs (91 lines), a Security Audit step in ci.yml, lockfile dependency bumps (hono, @hono/node-server, fast-xml-parser), and a patch changeset. The audit script is fail-closed on every error path (parse failure, report.error, non-GHSA via.source fallback all exit 1), covers the tree via advisory objects, preserves the high/critical threshold, and emits visible accepted/stale warnings. The CI job's timeout-minutes: 5 bounds the spawnSync npm-audit call. The changeset type (patch) matches the lockfile-only, no-behavior-change surface.
Gate checks: no no-auto-approve team match; gated_paths: false (so the REVIEW_REQUIRED status does not trigger row 2); high_risk: false; no prior decision. No critical/high/medium findings. Rows 1–8 do not fire → row 9 approve.
Summary
The Security Audit job, which the required Test & Build gate rolls up, fails on every PR to
mainand16.x. The cause is GHSA-fc5q-39xc-vjpf (picomatch ReDoS), which GitHub reviewed on 2026-11-17. All 17 high findings trace back to that one advisory, and no picomatch release fixes it. This PR clears the advisories that have a patched release and accepts that one advisory by ID in the audit gate. Every other high or critical advisory still fails CI.Supersedes #3697 (fast-xml-parser 5.11.2 → 5.12.0). This PR moves fast-xml-parser to 5.12.1.
Advisories addressed
npm audit fixandoverrideshave nothing to pin. It is accepted by ID inscripts/security-audit.mjswith its justification: picomatch is reached only through build, lint and release tooling (tsup, typescript-eslint,@changesets/cli, ts-to-zod, json-schema-to-typescript, and the typescript-eslint parser@adcp/eslint-pluginuses), which match globs from repo or project config, not request input. The@adcp/sdkruntime does not depend on picomatch. This advisory accounts for all 17 highs innpm audit. The others (@changesets/*,@manypkg/*, tinyglobby, fdir, tsup, sucrase,@oclif/core,@typescript-eslint/typescript-estree, json-schema-to-typescript) are its dependents.@modelcontextprotocol/node's^1.19.9). Fixed.@hono/node-server2.x, which needs a bump of the pinned direct dependency@modelcontextprotocol/node2.1.1 → 2.1.2 plus a major bump of@hono/node-server. Left for a separate change, since it is below the CI threshold.^4.11.4). Fixed.@google-cloud/storage's and@azure/core-xml's ranges). It brings fast-xml-builder 1.3.2, strnum 2.5.1 and is-unsafe 2.0.3 as its own dependencies. Fixed.minimatchto^10.2.1throughoverrides. Below the CI threshold.@google-cloud/storage7)@google-cloud/storage9, a major release. Below the CI threshold.Why no
npm audit fixI ran
npm audit fixwithout--forceand discarded the result. It cleared none of the highs, it downgradedsucrase(3.35.1 → 3.35.0) andgaxios(6.7.1 → 6.3.0), it movedejsfrom 3 to 6, and the sucrase downgrade addedglob10.5.0 with a new advisory. This PR usesnpm update hono @hono/node-server fast-xml-parserinstead. The lockfile diff is those three packages and the three dependencies fast-xml-parser 5.12 needs. Nothing else changes.CI change
.github/workflows/ci.yml's Security Audit step now runsnode scripts/security-audit.mjsinstead ofnpm audit --audit-level=high. The threshold is unchanged: the script parsesnpm audit --jsonand fails on every high or critical advisory whose GHSA ID is not inACCEPTED_ADVISORIES. It emits a::warningfor each accepted advisory it sees, so the exception stays visible on every run, and a stale-entry warning once an accepted advisory stops appearing. The fullnpm auditreport is still printed first.Verification
node scripts/security-audit.mjs: passes (36 total, 17 high, all GHSA-fc5q-39xc-vjpf). With the accepted ID removed, it fails and names picomatch.npm ci,format:check,lint,lint:boundaries,lint:workflows,typecheck,build:lib,typecheck:reporting-storagepass.test:node:fastand the eslint-plugin tests pass (one first-pass failure was 56 files hitting adistrebuilt mid-run; rerun against the finished build: 1065/1065). Full CI, including every Unit Tests lane, is green.🤖 Generated with Claude Code