Skip to content

fix(reporting): publish package coverage on ESA beta.25 base - #3746

Merged
rachitm022 merged 8 commits into
17.x-esafrom
fix/esa-beta25-package-coverage
Nov 18, 2026
Merged

rachitm022 merged 8 commits into
17.x-esafrom
fix/esa-beta25-package-coverage

Conversation

@rachitm022

Copy link
Copy Markdown
Collaborator

Why

The ESA reporting host needs Core revision and status coverage at package grain. The current ESA release branch starts from SDK beta.22 and adds a separate beta.6 schema bundle. The host already uses the published SDK beta.25 surface, so the ESA package needs to preserve that exact schema and client baseline.

What changed

  • Merge the published @adcp/sdk@17.0.0-beta.25 tag into 17.x-esa. This brings the primary AdCP pin to 3.3.0-beta.6 and removes the separate preview bundle.
  • Keep the reviewed package coverage implementation from feat(reporting): publish trusted package coverage in Core revisions #3732: freeze trusted package-to-buy bindings, publish package IDs in Core revision and status coverage, and reject rows outside the frozen scope.
  • Keep the existing ESA release workflow, adcp-3.3-esa npm tag, and scoped audit gate. The changeset calculates @adcp/sdk@17.0.0-esa.26. The release workflow will regenerate chore: release package (esa) #3741 after this PR merges; that release PR still needs a separate review.

The diff against 17.x-esa includes the upstream beta.23–beta.25 commits. To review ESA-specific content, compare this branch against @adcp/sdk@17.0.0-beta.25; 26 files differ, including the release workflow and package coverage.

Verification

  • npm run build:lib
  • 301 focused reporting tests
  • npm run check:publish-protocol-artifacts
  • npm run check:package-size: 25,387,269 packed bytes, 8,324 files
  • npm run typecheck, npm run lint (zero errors), npm run ci:doc-links
  • 11 scoped audit gate tests, npm ls --depth=0, commitlint
  • A separately packed scratch esa.26 has 3,616 schema files byte-identical to published beta.25, with the same AdCP pin, exports, dependencies, peers, and engines.

The full npm test suite is running and will be reported here when it finishes.

aleksUIX and others added 8 commits November 11, 2026 12:45
* fix(server): translate older releases when identity33 is enabled

* test(server): cover identity field projection through dispatch
…sellers anonymously (#3694)

* fix(discovery): discover preview pins unpinned and reach probe-gated sellers anonymously

A registration check on the 3.3 beta SDK reported a 3.0-only seller as
"not an AdCP agent": get_adcp_capabilities went out pinned to 3.3-beta.5,
the seller answered VERSION_UNSUPPORTED with supported_versions ["3.0"],
and nothing retried.

- getAdcpCapabilities() and the internal probe share one rule
  (capabilityDiscoveryEnvelope): a preview pin is discovered unpinned, and
  a refused stable pin is retried once unpinned. A caller-chosen pin
  (params or explicit versionEnvelope) is sent as-is; the refusal keeps
  its supported_versions.
- Testing discovery follows the same rule. The storyboard runner no longer
  sets an explicit 'auto' envelope for AdCP 3 runs, so comply reaches its
  version check (CapabilityResolutionError unsupported_adcp_version)
  instead of "Agent unreachable — VERSION_UNSUPPORTED".
- A client with no credential falls back to legacy MCP initialize when a
  seller 401/403s only server/discover. If that also fails, the seller's
  challenge still reaches the caller. OAuth-provider clients are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(discovery): address review — keep storyboard steps pinned, tighten retry

- Authored get_adcp_capabilities storyboard steps send the configured pin
  again; only the SDK's profile discovery goes out unpinned.
- capabilityDiscoveryEnvelope evaluates the release actually sent
  (wireAdcpVersion ?? adcpVersion), so a stable wire override is sent.
- Skip the unpinned retry when the caller set an operationId, and keep the
  pinned refusal unless the retry succeeds.
- Without a credential, keep the server/discover challenge when the legacy
  initialize fails for a non-auth reason; log the probe refusal (status only).
- Document the discovery rule in WIRE-VERSION-COMPAT.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(registry): sync generated registry types with the published OpenAPI

The published registry OpenAPI gained the brand logo asset endpoints
(getBrandLogoAsset, getBrandLogoLegacy) and logo background docs, so the
"Generated, Docs & Formatting" check failed on every open PR. Additive only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(mcp): keep the probe's 401 when an uncredentialed legacy retry is refused too

An uncredentialed client against a seller that 401s everything got the
legacy initialize's bare "Error POSTing to endpoint" instead of the probe's
401. Keep the probe error unless the legacy attempt was throttled or
cancelled, so the caller sees exactly what it saw before the retry existed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: aao-ipr-bot[bot] <279263549+aao-ipr-bot[bot]@users.noreply.github.com>
* feat: adopt AdCP 3.3.0-beta.6

Adopt the signed AdCP 3.3.0-beta.6 bundle (tag v3.3.0-beta.6, commit
bf4aa6dbb3b1, sha256 99c0ba47f42c, cosign-verified), replacing beta.5.
Types, Zod schemas, tool metadata, compliance corpus, docs and tests are
regenerated and re-pinned.

- adcp#8501 withdrawals: generated types follow; the 3.3<->3.2 vectors
  drop cases without a 3.3 surface; the beta.6 accepted-terms review table
  drops price_adjustments_resolution and the sla-window calendar contract.
- adcp#8884: buyer retry policy treats UNRECOGNIZED_TERMS like
  UNSUPPORTED_FEATURE.
- adcp#8974: refine-proposals capability discovery, request validation,
  failure classification and response verification support
  installment_changes / unsatisfied_installment_changes (3.3 only).
- adcp#8983: the reporting manifest inspector accepts report definitions
  at contract_version 1.0, 1.1 and 1.2 and enforces their rules.
- adcp#8966: the beta.6 accepted-terms review covers the geo display-label
  annotations.
- adcp#8866: where the SDK relied on closed schemas, it now refuses the
  known cases by name (account projections, reporting delivery states,
  proposal.created payloads, consumer status ingest, account-change
  notifications, reporting-subscription scope membership).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(registry): sync generated registry types with the published OpenAPI

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test: expect open reporting-status evidence objects under AdCP 3.3.0-beta.6

adcp#8866 opens the evidence objects, so extension members validate against
the authoritative schema; the generated Zod still matches it case for case.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: aao-ipr-bot[bot] <279263549+aao-ipr-bot[bot]@users.noreply.github.com>
AdCP 3.3.0-beta.6 opened schemas (adcontextprotocol/adcp#8866) that the SDK
relied on to keep undeclared data out of responses, stored evidence and
webhook payloads.

- Project account identity objects, reporting delivery states and
  notification_configs to their declared members; refuse retained secrets.
- Refuse undeclared managed-delivery evidence members in reporting-storage
  (new undeclaredReportingMaterializationMembers on reporting/ledger).
- Enforce webhook schema `not` exclusions at any depth, fail closed when a
  mapped schema is unavailable, and make proposal.offered identifiers-only.
- Refuse an unknown single reporting-subscription scope selector; the engine
  covers every account only for an explicit all_authorized_accounts.
- Bound credential scanning and projections by depth (DAG-aware), drop an
  uninspectable ext/context in scrubExtensions, and drop ingest diagnostics
  with control characters.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: aao-ipr-bot[bot] <279263549+aao-ipr-bot[bot]@users.noreply.github.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — ESA merge PR (upstream beta.23–25 + #3732 package coverage).

No blocking findings. The reviewer read the hand-written logic in full: version/discovery unpinning + VERSION_UNSUPPORTED retry, anonymous-401 legacy fallback, beta.6 closed-schema fail-closed projections (with reported drops), subscription-scope narrowing, and the side-bundle script cleanup. Generated types and vendored schema snapshots were spot-checked. Changeset coverage is correct and no package.json version line was hand-edited.

Decision table walk-through:

  • Row 1 (critical/high): none.
  • Row 2 (gated paths): gated_paths is false — N/A.
  • Row 3/5 (high_risk deleted/modified + medium): high_risk is true (bin/, schemas/registry/, src/lib/protocols/** all modified), but there are zero medium-or-higher findings, so neither row fires.
  • Rows 4, 6, 7, 8: no medium findings, no prior escalation, no no-auto-approve team match, fewer than three mediums.
  • Falls through to Row 9 → approve.

Non-blocking note (not a finding): the PR body mentions the full npm test suite was still running, though the primary package-coverage change is covered by the cited 301 focused reporting tests.

@rachitm022
rachitm022 merged commit 416dece into 17.x-esa Nov 18, 2026
43 checks passed
@rachitm022
rachitm022 deleted the fix/esa-beta25-package-coverage branch November 18, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants