Skip to content

test(signing): vendor Cloudflare web-bot-auth interop fixtures - #566

Merged
bokelley merged 1 commit into
mainfrom
bokelley/556-wba-interop-fixtures
Oct 15, 2026
Merged

bokelley merged 1 commit into
mainfrom
bokelley/556-wba-interop-fixtures

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Follow-up to #558. This vendors the Web Bot Auth interop fixtures that the TypeScript SDK generated against Cloudflare's reference libraries, and tests the Go verifier and signer against them.

What's vendored

adcp/v3/signing/testdata/wba-interop/ contains a byte-for-byte copy of adcontextprotocol/adcp-client test/fixtures/wba-interop/ at commit 577f21e82a7c9f640e69d073f0856700f3601fe7, merged in adcontextprotocol/adcp-client#3250. The files are README.md, keys.json, adcp-client-signed-{body-request,percent-encoded-path}.json, and cloudflare-signed-{body-request,percent-encoded-path}.json. The fixtures were generated against web-bot-auth@0.2.0 and http-message-sig@0.3.0. UPSTREAM.json records the repository, commit, path, and each file's SHA-256, and a test checks the checksums. keys.json holds the upstream test-only keys.

Tests (wba_interop_test.go)

  • Verifier. Each fixture's request is rebuilt the way a server receives it, with the origin-form request-target as sent and the Host field. Its directory is served at the fixture URL through the real DirectoryResolver, with directory signatures required so each signer's Appendix B signature is checked. VerifyWebBotAuthRequest runs at reference_now. All four pass, Cloudflare-signed and TypeScript-signed, including /a%7Eb/mcp/, with:

    • the expected identity and keyid;
    • the exact RFC 9421 signature base from the fixture;
    • @target-uri equal to the URI as received.

    A copy with the path percent-decoded is refused.

  • Signer. The test signs with the fixtures' Ed25519 key, created, and nonce. The Go signer reproduces the TypeScript-signed requests byte for byte (content-digest, signature-agent, signature-input, signature). Ed25519 is deterministic and both SDKs use the profile's component order. The Go-signed requests also verify under the Cloudflare-signed directory, and a Cloudflare-style padded-base64 nonce signs and verifies.

Interop result

I found no interop failure: no code changes were needed. The migration note and the signing README now point at the fixtures instead of listing them as pending.

Validation

In adcp/v3: go vet ./..., go test -race -count=1 ./..., and golangci-lint (0 issues). The legacy adcp/signing package is untouched and passes too.

Refs #556. Leave unmerged pending maintainer review.

🤖 Generated with Claude Code

Vendors adcontextprotocol/adcp-client test/fixtures/wba-interop/ at
577f21e8 (merged in adcp-client#3250) byte for byte, with provenance and
per-file SHA-256 in testdata/wba-interop/UPSTREAM.json. The fixtures were
generated against Cloudflare's web-bot-auth@0.2.0 and
http-message-sig@0.3.0.

Tests show the Go verifier accepts the Cloudflare-signed and the
TypeScript-signed requests, including the percent-encoded /a%7Eb/mcp/
target, against each signer's Appendix B-signed directory (signatures
required), with the expected identity, keyid, and RFC 9421 signature base;
a percent-decoded copy is refused. With the fixtures' created and nonce,
the Go signer reproduces the TypeScript-signed requests byte for byte, and
its output verifies under the Cloudflare-signed directory too. No interop
failure was found.

Refs #556

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — test-only PR vendoring Web Bot Auth interop fixtures.

This PR adds wba_interop_test.go plus pinned interop testdata (UPSTREAM.json with sha256 provenance) and migration doc updates — no production, schema, signing-semantics, or wire changes. The reviewer confirmed every symbol the new test calls (SignWebBotAuthRequest, wbaSignatureBase, receivedTargetURI, WBASignOptions.CreatedOverride/NonceOverride, VerifiedSigner.AgentURL, etc.) exists in the base so it compiles, and reviewed the largest file: the pinning self-guard (L343), scoped negative percent-decode case (L427-432), and full-header-map comparison (L499) are all sound.

Decision table: no critical/high/medium findings (rows 1, 4–6, 8 don't fire). gated_paths is false (row 2 n/a). high_risk is false (rows 3, 5 n/a). No prior decision (row 6 n/a). No no-auto-approve team match (row 7 n/a). Falls through to row 9 → approve. Note review_decision is REVIEW_REQUIRED, but that only gates when gated_paths is true, which it is not here.

@bokelley
bokelley merged commit 188cdcf into main Oct 15, 2026
18 checks passed
bokelley added a commit that referenced this pull request Oct 18, 2026
)

* chore(release): publish adcp/v3 as 3.3 pre-releases from main

main carries the experimental AdCP 3.3 agent-identity work (#557, #558,
#566, #568, #571), so the adcp/v3 module must not cut a stable v3.3.0
from it. Switch the adcp/v3 package to release-please's prerelease
versioning (prerelease-type beta.0) so the pending release becomes
adcp/v3.3.0-beta.0, marked as a GitHub pre-release. Other modules are
unchanged.

Document the model, the release/v3.2.x path for stable fixes, and how to
exit pre-release when AdCP 3.3 ratifies in RELEASING.md.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* docs(release): spell out default-strategy bumps from a beta

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* docs(release): scope commit guidance to adcp/v3/

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant