Repository navigation
feat(identity): re-pin identity schemas and vectors to AdCP 3.3.0-beta.3 - #603
Conversation
7fb6d24 to
7a581ef
Compare
7a581ef to
626911b
Compare
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean re-pin of experimental identity schemas and WBA vectors to AdCP 3.3.0-beta.3.
Checked:
- Validator (
trustjson.go) and hand-written types (types.go) move in lockstep with the vendored schemas, backed by a new checksum pinning test and updated coherence tests. - aao_verified/storyboard required-field rules and maxLength/maxItems bounds match the schema; maxLength correctly counts code points.
- All removed exported symbols are confined to the four edited files — no external consumer breaks.
- Breaking marker
feat(identity)!is present; DR-0032/0033 pathway-back is N/A since the layer is experimental and the wire pin stays 3.2.2.
No critical/high/medium findings. No author-team gate, gated_paths false, high_risk false, no prior decision. Falls through to row 9 → approve.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean re-pin of the experimental adcp/v3/identity layer to the signed AdCP 3.3.0-beta.3 bundle.
What I checked:
trustjson.govalidator rules match the beta.3 schema allOf conditionals (aao_verified→role, storyboard/experimental_feature→id) and new maxLength/maxItems bounds.types.gosymbol removals/renames (BuyerOnboardingMode, RequirementAgentIdentity, .Specialisms→VerifiedSpecialisms, DocumentationURL, RelationshipPending→RelationshipPendingApproval) are referenced only within the identity package and updated consistently — no compile break, no external callers.- Missing
feat!/BREAKING CHANGEmarker is not a finding: these symbols live under experimentaladcp/v3/, where such markers are forbidden per RELEASING.md:38-40, and the wire pin is unchanged (3.2.2). - New
TestIdentitySchemasArePinnedfails closed on checksum drift;TestTypesMatchPinnedSchemasenforces schema↔type coherence. - Interop D11 caveat and held ADCP_REF honestly disclosed.
No Critical/High/Medium findings. No gated paths, no high-risk flag, no author-team gate, no prior decision. Falls through to row 9.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean re-pin of experimental AdCP 3.3 identity schemas to the signed 3.3.0-beta.3 bundle.
What I checked:
- No critical/high/medium findings from the reviewer (rows 1, 4, 5, 6, 8 do not fire).
gated_paths: false— row 2 does not apply despitereview_decision: REVIEW_REQUIRED.high_risk: falseand no(deleted)/(modified)high-risk triggers — rows 3, 5 do not fire.- No no-auto-approve team match — row 7 does not fire.
- First review of this PR — no sticky escalation (row 6) applies.
Type↔schema coherence holds across every modeled type/enum, tracked by TestTypesMatchPinnedSchemas, with the new TestIdentitySchemasArePinned checksum-pinning each vendored schema. The trustjson.go validator's conditional-required and bounds match the schema's allOf. Removed exported symbols are referenced only within edited files (no external breakage), and the experimental/opt-in package with unchanged wire pin correctly omits a ! marker per RELEASING.md. Interop ADCP_REF deferral to #585 is disclosed.
Falls through to row 9 → approve.
Replace the draft identity schemas with the files from the signed
3.3.0-beta.3 bundle, and re-pin the Web Bot Auth vectors to the
v3.3.0-beta.3 tag (only README.md changed). Checksums for every vendored
schema are now pinned and checked.
API changes in the experimental identity package, following the
released schemas:
- BuyerOnboardingPosture.Mode is an AgentOnboardingMode (open,
application, invite_only). BuyerOnboardingMode and
considers_unsolicited are gone.
- RequirementAgentIdentity is gone. AgentOnboardingRequirement.Specialisms
is now VerifiedSpecialisms. DocumentationURL is gone from
AgentOnboarding and BuyerOnboardingPosture.
- RelationshipPending is now RelationshipPendingApproval
("pending_approval"). PrincipalRelationshipSetup gains Kind and
WaitingOn.
- The trust-record validator applies the requirement rules: aao_verified
needs role, storyboard and experimental_feature need id, and the
length and item bounds hold.
Added PrincipalChangedReportingSubscriptionChanged. The CI interop job's
ADCP_REF stays put: the beta.3 harness's D11 scenario fails until
adcp-go#585 lands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
626911b to
d3b594d
Compare
There was a problem hiding this comment.
Ladon verdict: Approve
Approve.
Clean pass with no blocking triggers. This PR re-pins the experimental 3.3 identity schemas from draft commits to the signed AdCP 3.3.0-beta.3 bundle, moving the Go types (adcp/v3/identity/types.go) and the trust.json validator (trustjson.go) in lockstep.
What I checked:
- Validator ↔ vendored schema coherence: trustjson.go:619-636 enforces aao_verified→role and storyboard/experimental_feature→id required fields plus the new maxLength/maxItems bounds, matching agent-onboarding-requirement.json; unknown kinds still early-return before required-field checks per the if/then schema.
- buyerPosture now accepts only seller modes (open/application/invite_only), with corresponding type/test updates for specialisms→verified_specialisms, pending→pending_approval, documentation_url removal, and the new pending-action-kind/party and principal-relationship-status enums.
- New TestIdentitySchemasArePinned checksum-gates all 15 vendored schemas against UPSTREAM.json.
- All wire-shape changes are confined to the opt-in experimental 3.3 layer (wire pin unchanged at 3.2.x), so DR-0032/0033 pathway-back does not apply; migration note documents the breaking draft changes and its delegation-chains link resolves.
Gate status: high_risk false, gated_paths false (and review_decision is APPROVED anyway), no no-auto-approve team match. No critical/high/medium findings. Falls through to row 9.
Keep main's v3.3.0-beta.3 pins (adcontextprotocol#603) for the wba-profile vectors, README, conformance test, and migration doc, and move the interop harness's ADCP_REF to the same tag so CI grades this SDK against beta.3, including the D11 directory-key scenario this PR fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
This replaces the draft identity schemas, pinned to PR commits from #8168, #8169 and #8170, with the files from the signed AdCP
3.3.0-beta.3bundle.download.shpassed live Sigstore verification. It also re-pins the Web Bot Auth vectors to thev3.3.0-beta.3tag. Together with #601, which vendors the delegation-chain vectors from the same tag, every upstream input of the identity layer now comes from one release.The SDK's wire bundle (
adcp/v3/schemas/VERSION) stays at 3.2.2. Adopting the 3.3 wire is a larger change, tracked in draft #602.API changes (experimental
identitypackage)These follow the released schemas:
BuyerOnboardingPosture.Modeis anAgentOnboardingMode(open,application,invite_only).BuyerOnboardingModeandconsiders_unsolicitedare gone.RequirementAgentIdentityis gone.AgentOnboardingRequirement.Specialisms→VerifiedSpecialisms.DocumentationURLis gone fromAgentOnboardingandBuyerOnboardingPosture.RelationshipPending→RelationshipPendingApproval(wire valuepending_approval).PrincipalRelationshipSetupgainsKindandWaitingOn.aao_verifiedneedsrole;storyboardandexperimental_featureneedid; and themaxLength/maxItemsbounds hold.PrincipalChangedReportingSubscriptionChanged.Pins
identity/testdata/schemas/UPSTREAM.jsonnow records the bundle, tag and commit, plus a sha256 for every vendored schema. The newTestIdentitySchemasArePinnedchecks them. Three enums the schemas now reference are vendored.identity/testdata/examplesare unchanged at the tag.signing/testdata/wba-profile: onlyREADME.mdchanged at the tag.ADCP_REF(the CI interop job) is not moved. I ran the beta.3tests/wba-interopharness against this SDK locally: 67 of 69 pass. The 2 failures are the new D11 scenario (a second Ed25519 key in the directory that doesn't sign), which fix(signing): use only validly signed directory keys, as adcp#7894 now requires #585 fixes. MoveADCP_REFtoa6106149once fix(signing): use only validly signed directory keys, as adcp#7894 now requires #585 merges. At the current ref, 64 of 64 checks pass.Tests
go test -race ./identity ./signingpasses.golangci-lint run ./identity/... ./signing/...(go1.26.2) reports 0 issues.The title has no
!: RELEASING.md forbids breaking-change markers underadcp/v3/, because release-please would propose4.0.0-beta.*. The experimental identity package changes inside the 3.3 beta line.🤖 Generated with Claude Code