Skip to content

Training agent: serve the experimental 3.3 hold-policy, extend_hold and response-collection surfaces #8181

Closed

Description

@bokelley

Problem

Four experimental 3.3 slices are heading to main. The plan is to exercise them end to end on the training agent before the working group reviews them together. The training agent can't serve any of them yet:

Slice PR Feature id
Hold policy on products and proposals, hold_placed_at #8140 (#7661) media_buy.hold_policy
extend_hold refinement action #8097 (#8086 item 1) media_buy.proposal_refinement.hold_extension
Collection objects in product and proposal responses, include_collections, collection.url, brand collection links #8141 (#8137) media_buy.collection_cards, brand.collection_links
Follower counts on collection distribution #8098 media_buy.collection_cards

Blockers found so far

  • Version ceiling. TRAINING_AGENT_CURRENT_ADCP_VERSION is '3.2' (server/src/training-agent/types.ts), and the storyboard runner pins that version. Several rules are version-gated. For example, a committed proposal whose effective policy is terms-only must be refused to callers below 3.3, and hold_policy / hold_placed_at are omitted for them. So the agent can't demonstrate the 3.3 behaviour.
  • SDK validation. SDK 14.2.0's createProposalRefinementHandler validates refine results against its bundled 3.2 canonical-proposal.json, which rejects unknown properties. Any hold_policy or hold_placed_at on a returned proposal fails inside the SDK. This needs an SDK release that bundles the 3.3 schemas, or a training-agent path that validates against the repo's own schemas.

Scope

  1. Serve 3.3 (or the experimental surfaces at 3.3) once the SDK can validate 3.3 shapes.
  2. Hold policy.
    • Product-level hold_policy planning hints.
    • Draft policy derived from the allocated products.
    • Committed proposals carrying the policy forward, with hold_placed_at and expires_at inside the bounds.
    • Mixed proposals finalizing terms-only.
    • hold_unavailable / batch_aborted in all-or-none batches.
    • Below-3.3 omission.
  3. extend_hold. Successors that carry hold_policy and hold_placed_at forward, the max_total_duration ceiling across the chain, declines when extendable is false, and INVALID_STATE against a commitment that holds no inventory.
  4. Response collections.
    • The include_collections flag on the four tasks, and the top-level collections[].
    • Feed versions scoped by the flag.
    • get_brand_identity collections links.
  5. Follower counts. Fixture data with distribution[].followers that changes without causing definition-pin drift.

The creator-marketplace fixtures in #8093 are the natural data for items 2–5.

Acceptance

  • A buyer can walk a creator slot through discovery (with cards), a draft with a hold policy, finalize, extend and accept against the hosted training agent.
  • The hold-policy compliance vectors (static/compliance/source/test-vectors/hold-policy/) grade the agent's actual responses as conformant.

Related: #8093, #7661, #8086, #8137.

Activity

  1. added this to the 3.3.0 milestone on Oct 28, 2026
  2. bokelley commented on Oct 31, 2026

    @bokelley
    ContributorAuthor

    Status (2026-10-31): not done. No PR exists. The training agent is still pinned to 3.2 (TRAINING_AGENT_CURRENT_ADCP_VERSION) and has no hold_policy, extend_hold, holds or list_collections handlers. The experimental surfaces ship in 3.3 regardless, and the WG's end-to-end review of the hold slices waits on this. Staying open in 3.3.0.

  3. bokelley commented on Nov 2, 2026

    @bokelley
    ContributorAuthor

    Done. The hosted reference training agent serves the experimental 3.3 hold and collection slices at the opt-in 3.3-beta.3 preview pin. Stable callers are unchanged, and TRAINING_AGENT_DISABLE_ADCP_PREVIEW=1 is the kill switch.

    Acceptance is met once deployed: a buyer pinned to 3.3-beta.3 (SDK 17.0.0-beta.11 or later) can take a creator slot through discovery with cards, a draft with a hold policy, finalize, extend and accept.

    Follow-ups:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions