Repository navigation
Description
Summary
media_buy_seller/product_filter_behavior checks that get_products filters apply in three buying modes: brief, wholesale and refine. Its refine phase (refine_filters, step filter_refined_product_out) sends buying_mode: "refine", but neither the storyboard nor the phase has a capability gate.
Refine is optional. media_buy.buying_modes defaults to ["brief"], and the refinement guide says refinement is not required. refine_products is already gated on media_buy.buying_modes containing refine (#6702).
The storyboard runs for any seller that exposes comply_test_controller. Take a seller that declares ["brief", "wholesale"] but not refine. For that seller, the refine step can't pass:
@adcp/sdk15.9.2 is the version the hosted grader has been pinned to since chore(deps): update @adcp/sdk to 15.9.2 and drop external-smoke SDK workarounds #8231. It refuses the call before sending it, withUnsupportedBuyingModeError(codeUNSUPPORTED_BUYING_MODE, from get_products: honor media_buy.buying_modes; don't send or default to wholesale for sellers that don't declare it adcp-client#3058). The seller never sees the request.- The runner records the refusal as a failed step, not a skip.
- The hosted policy counts a step that failed without being skipped as
failed. So the storyboard readspartial2/3 instead ofpassing.
The only way for the seller to clear the step is to declare refine. That would be a false capability claim, and it would also select refine_products.
The storyboard file is byte-identical in three places:
- on main
- in the 3.2.4 bundle, the latest in
published-versions.jsonand the bundle hosted 3.2 grading uses - in 3.2.5, released 2026-10-16
Among published bundles it ships only in 3.2.x, not in 3.0.x or 3.1.x.
Evidence
Main is at 68c90b6. adcp-client links are at the @adcp/sdk@15.9.2 tag, 90a40c3.
The step
- The
refine_filtersphase has norequires_capability: L176–L206. - The storyboard header has
requires: [controller]andrequired_tools: [get_products, comply_test_controller], and no capability gate: L1–L12. - The refine request reuses the product id that the wholesale phase captured.
Refine is optional
- In
get-adcp-capabilities-response.json,media_buy.buying_modessays brief is "universally supported and implicit", and the default is["brief"]: L1330–L1340. - The v3 readiness guide says an agent must handle refine semantics if it declares refine: L110.
- The refinement guide says what follows. The same text is in v3.2.4 and v3.2.5.
refine_productsis gated onmedia_buy.buying_modescontainingrefine: L10–L12.- fix(compliance): scope measurement acceptance and product-refinement scenarios #6702 asked for that gate. fix(compliance): scope optional media-buy behaviors #6739 added it on 2026-08-21, and fix(compliance): backport optional media-buy scoping to 3.1 #6742 backported it to 3.1.x.
product_filter_behaviorhad landed a week earlier, in feat(media-buy): add targeting-aware product discovery #6203 on 2026-08-14. Its refine phase didn't get the gate.
- The training agent declares
refinein every profile (task-handlers.ts L19859), so runs against it never reach the refusal.
What the runner does (15.9.2)
getProductsthrowsUnsupportedBuyingModeErrorbefore the wire call when a seller's declared modes don't include the requested mode. The check applies when the seller serves 3.1 or later, or declaresbuying_modes.- SingleAgentClient.ts L6970–L6987
supportsBuyingModeL821–L823- error class L123–L124
- This is intended, and it matches the capability docs.
runStepcatches the throw and returnspassed: falsewith the message and no skip reason: client.ts L558–L571.- Hosted runs refuse the call the same way.
- The storyboard runner turns request validation off only for
expect_errorsteps: runner.ts L6405. validateFeaturesappears nowhere inserver/on main.
- The storyboard runner turns request validation off only for
How the hosted grader scores it
classifyComplianceStepreturnsfailedfor a step that isn't skipped and didn't pass: step-disposition.ts L35.deriveStoryboardStatusescounts that step in the denominator, so 2 passed out of 3 ispartial: compliance-testing.ts L1084–L1098 and L1152–L1161.- When a phase's
requires_capabilityisn't met, the runner gives its stepsskip_reason: not_applicable(runner.ts L1818–L1838). The grader leaves those steps out of the denominator (step-disposition.ts L44).
Runs
- Our agent, local, SDK 15.8.1. Our 3.2 build is behind a flag that is off in production. It declares
buying_modes: ["brief", "wholesale"].- Full local run on 2026-10-14 against bundle 3.2.3.
- Brief and wholesale passed.
filter_refined_product_outfailed in 2 ms with "Seller does not support refine buying mode. Declared modes: brief, wholesale. …".- Between 3.2.3 and 3.2.4, the only change to this file is that it gains
requires: [controller].
- Stub seller, SDK 15.9.2.
- Run with
runAgainstLocalAgentover real MCP HTTP, using the 3.2.4 compliance cache that ships in the package. - The stub logs every
get_productscall it receives. - The hosted status column applies the
classifyComplianceStepandderiveStoryboardStatusesrules above.
- Run with
| Storyboard | Seller declares | Modes the stub received | Refine step | Hosted status |
|---|---|---|---|---|
| as shipped | brief, wholesale | brief, wholesale | failed: "Seller does not support refine buying mode…" | partial 2/3 |
| as shipped | brief, wholesale, refine | brief, wholesale, refine | passed | passing 3/3 |
| with the phase gate below | brief, wholesale | brief, wholesale | skipped, not_applicable |
passing 2/2 |
| with the phase gate below | brief, wholesale, refine | brief, wholesale, refine | passed | passing 3/3 |
For comparison, refine_products as shipped behaves the way the table's gated rows do:
- A seller declaring
[brief, wholesale]skips it ascapability_unsupported, which the hosted policy treats as not applicable. - A seller declaring
[brief, wholesale, refine]selects it and sends a refine call.
For rows 3 and 4, I added the gate to the loaded storyboard in memory rather than editing the YAML. 15.9.2 accepted the shape and applied the gate.
What isn't verified
- No hosted card shows this failure yet.
- I read the public registry's compliance cards twice on 2026-10-16, between 19:38 and 19:57Z. 35 agents are listed, and the API returned HTTP 500 for some cards.
- Of the cards that came back, one seller card is graded on a 3.2 bundle: 3.2.4 with SDK 15.8.1, graded 2026-10-13.
- On that card,
product_filter_behaviorisuntested(0/0) andrefine_productspasses 3/3, so that seller declares refine. - The hosted result above comes from the grader source at
68c90b6and the pinned SDK version, not from a card.
- Our own agent was run on 15.8.1, not 15.9.2. The 15.9.2 result comes from the stub. The refusal code path is the same in both versions.
- The stub returns a fixed product. It shows what the runner sends and how the step is scored, not how a real seller filters.
Our stake. We run https://sell.nofluffadvisory.com/mcp. It serves 3.1 and will stay on 3.1 until 3.3, so this doesn't affect our card today. Our 3.2 build doesn't iterate on prior products and doesn't declare refine, so this step would be one of its failures if we moved. The same is true for any seller that exposes the test controller, declares wholesale but not refine, and moves to 3.2.
Ask
-
Gate the
refine_filtersphase on the same capability asrefine_products:- id: refine_filters title: "Apply replacement filters during refinement" requires_capability: path: media_buy.buying_modes contains: refine steps:
- Sellers that declare refine are graded as they are now.
- A phase-level gate keeps brief and wholesale filter coverage for every seller that runs the storyboard. A storyboard-level gate would drop it.
requires_tooldoesn't fit, because refine is a mode ofget_products, not a separate tool.- Phase-level
containsgates already exist, for example seller_optimized_budget L351–L355. - fix(compliance): gate wholesale reporting and proposal replay by capabilities #7893 used a phase gate for proposal replay: proposal_finalize L270–L275.
- feat(media-buy): declare delivery modes and grade guaranteed-only sellers on a matching baseline #7973 notes that a phase gate takes one predicate. This phase has no gate today, so that limit doesn't apply.
-
Backport the fix to 3.2.x for the next patch.
- Precedent: fix(compliance): gate wholesale reporting and proposal replay by capabilities #7893's buying-mode gate on
advanced_delivery_reportingis already in the 3.2.3 bundle. - 3.1.x and 3.0.x don't ship this storyboard.
- Precedent: fix(compliance): gate wholesale reporting and proposal replay by capabilities #7893's buying-mode gate on
Same file, not our case: wholesale. wholesale_filters has no gate either, and the schema says wholesale is opt-in.
- With 15.9.2 and a seller that declares only
["brief"], the wholesale step fails the same way. The refine step is then skipped asprerequisite_failed, and the storyboard reads partial 1/3. - If wholesale gets a gate too, the refine phase needs to capture its product id from the brief phase instead. Otherwise a seller that declares
[brief, refine]loses it. - I haven't checked the other storyboards that send
buying_mode: "wholesale".
Related:
- fix(compliance): scope measurement acceptance and product-refinement scenarios #6702, fix(compliance): scope optional media-buy behaviors #6739 and fix(compliance): backport optional media-buy scoping to 3.1 #6742: the same gate for
refine_products. - Storyboard questions surfaced by SDK 14.0.0 grading of the Python reference sellers (wholesale gate, idempotency replay, controller requirement) #7858 and fix(compliance): gate wholesale reporting and proposal replay by capabilities #7893: the same kind of problem, for wholesale in
advanced_delivery_reporting. - get_products: honor media_buy.buying_modes; don't send or default to wholesale for sellers that don't declare it adcp-client#3058 and fix(client): honor buying modes and account contracts adcp-client#3064: the client-side refusal.
- feat(media-buy): declare delivery modes and grade guaranteed-only sellers on a matching baseline #7973: an open draft, held to 3.4, that adds a storyboard-level delivery-type gate to this file. It doesn't overlap with this phase gate.
- feat(media-buy): add targeting-aware product discovery #6203: where the storyboard came from.
Activity