You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove the canonical_formats dual-emission known-failing step after the SDK release with adcp-client#3474 #8542
server/tests/manual/run-storyboards.ts marks media_buy_seller/canonical_formats/create_media_buy_with_equivalent_direct_legacy_emission as known-failing. Beta.2's grader called the direct route's omitted max_file_size_kb under-specified, which contradicts the spec's product-satisfaction rule. That's fixed in adcontextprotocol/adcp-client#3474 (closes adcp-client#3470), merged but not yet released.
Bump @adcp/sdk (and the matching @adcp/reporting-storage), update docs/building/by-layer/L4/choose-your-sdk.mdx, and update the @adcp/sdk version in scripts/sdk-response-conformance/known-findings.json.
Remove the create_media_buy_with_equivalent_direct_legacy_emission entry from KNOWN_FAILING_STEPS. Keep reject_conflicting_dual_emission and reject_unprojectable_legacy_dual_emission: they come from a separate SDK serving-side gap.
Verified locally with #3474 patched in: the storyboard grades 23 passed, with only those two serving-side steps failing.
Step 2: the create_media_buy_with_equivalent_direct_legacy_emission entry is removed from KNOWN_FAILING_STEPS. The two serving-side entries stay.
Caveat: the local sales tenant does not reach the step today. Since fix(compliance): respect seller pricing and optional capabilities #8599 the native_canonical_compatibility_support fixture is unsatisfied, so canonical_formats records a coverage gap after its first step, on main too.
Activity
Synaeve commentedon Nov 10, 2026
Fix in #8875.
main:@adcp/sdk17.0.0-beta.21 includes fix(testing): an omitted selector constraint inherits the product value adcp-client#3474.create_media_buy_with_equivalent_direct_legacy_emissionentry is removed fromKNOWN_FAILING_STEPS. The two serving-side entries stay.native_canonical_compatibility_supportfixture is unsatisfied, socanonical_formatsrecords a coverage gap after its first step, onmaintoo.test(compliance): drop resolved canonical_formats known-failing step (a…