Repository navigation
feat(creative): disclose adjacent code and assignment application state for 3.4 - #8346
numarasSigmaSoftware wants to merge 5 commits into
Conversation
Propose fragment-only addon assembly, mandatory signed chain evidence, and explicit purchase bindings. Keep WG release-scope and signing-profile approval pending.
Preserve current release catalogs and purchase-input exclusions while resolving the addon proposal conflicts. Keep existing schema size limits and pending WG decisions unchanged.
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated schema paths touched without an approving review.
This PR modifies static/schemas/source/** (a deterministic hard approval gate) and review_decision is REVIEW_REQUIRED, not APPROVED. Per decision row 2, the outcome must be escalate (there are no blocking findings that would make it request-changes).
Escalation reasons
- Gated paths touched under
static/schemas/source/**(e.g.creative-addon-chain.json,product-purchase.json,error-code.json,specialism.json, plus 15 others) require human/CODEOWNERS approval.review_decisionisREVIEW_REQUIRED— gate not satisfied.
Review notes (non-blocking)
Reviewer found no Critical/High/Medium findings across all 46 files. Changeset is minor and additive (new get_creative_addons task, 7 core schemas, disclosure/chain fields, 7 ADDON_* error codes, creative-addon specialism) — no required-flip, no removed/renamed field, so not breaking-class. The sole new oneOf (creative-addon-chain discriminator status with const-pinned arms) is properly discriminated and won't fail audit-oneof. Schema↔docs coherence holds; dist/<semver>/ untouched. This is a clean additive proposal; the escalation is purely the deterministic approval gate, not a code concern.
Follow-up disclosed by author (non-blocking): two size-guard reds (controller 1,321,066>1,320,000; media-buy 476,621>475,136) left unraised pending a separate decision; full npm test not run.
Why human review
- Modifies gated paths under static/schemas/source/** (19 files incl. product-purchase.json, error-code.json, specialism.json, creative-addon-chain.json) — hard approval gate requires human/CODEOWNERS review; review_decision is REVIEW_REQUIRED, not APPROVED.
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/account/sync-accounts-response.json (modified) matches
static/schemas/source/**; static/schemas/source/core/canonical-product.json (modified) matchesstatic/schemas/source/**; static/schemas/source/core/creative-addon-capability.json (added) matchesstatic/schemas/source/**; static/schemas/source/core/creative-addon-chain.json (added) matchesstatic/schemas/source/**; static/schemas/source/core/creative-addon-disclosure.json (added) matchesstatic/schemas/source/**; static/schemas/source/core/creative-addon-failure.json (added) matchesstatic/schemas/source/**; static/schemas/source/core/creative-addon-fragment.json (added) matchesstatic/schemas/source/**; static/schemas/source/core/creative-addon-registration.json (added) matchesstatic/schemas/source/**; static/schemas/source/core/creative-addon-signing-key.json (added) matchesstatic/schemas/source/**; static/schemas/source/core/creative-variant.json (modified) matchesstatic/schemas/source/**; static/schemas/source/core/product.json (modified) matchesstatic/schemas/source/**; static/schemas/source/creative/get-creative-addons-request.json (added) matchesstatic/schemas/source/**; static/schemas/source/creative/get-creative-addons-response.json (added) matchesstatic/schemas/source/**; static/schemas/source/enums/error-code.json (modified) matchesstatic/schemas/source/**; static/schemas/source/enums/specialism.json (modified) matchesstatic/schemas/source/**; static/schemas/source/index.json (modified) matchesstatic/schemas/source/**; static/schemas/source/media-buy/product-fields.json (modified) matchesstatic/schemas/source/**; static/schemas/source/media-buy/product-purchase.json (modified) matchesstatic/schemas/source/**; static/schemas/source/protocol/get-adcp-capabilities-response.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
|
Hi @bokelley, if you can please review the bot feedback and approve the changes. I would like for this to be released in 3.3. |
Preserve upstream account requests and withdrawn feature decisions while retaining addon disclosure and 3.3 discovery. Keep WG approvals pending and schema size limits unchanged.
This revises #8346 around Bokelley's proposed 3.4 split. Buyers can discover seller-side code before purchase and inspect its current application state on each creative assignment. Required code that is pending or omitted blocks that assignment's delivery while creative approval remains unchanged.
Target: AdCP 3.4. WG approval: pending. This remains a proposal. The fragment API and assembly-signing profile have been removed from this PR for separate WG consideration.
The protocol additions are:
adjacent_code[]on both product shapes, carryingprovider,purpose, andrequired. Provider is an opaque seller-scoped reference;selleridentifies first-party seller code. Omission means undeclared, while[]explicitly declares none.list_creatives.assigned_packages[]andget_media_buys.creative_approvals[], addingposition: prepend | appendandstatus: applied | omitted | pending. It reports seller application state rather than independent proof of browser execution.creative.assignment_changedgainschange_kind: adjacent_code_changedfor required-code pending/omission transitions and policy changes that block or release delivery. Ordinary configuration edits and optional-code changes do not fire it. Existing webhook authentication remains in place.The same delivery hold applies after serving has begun. An authorized change to the effective assignment policy updates its readback; changing the current product offer does not retrospectively rewrite assignment state. Disclosure grants no consent to insert code and does not change accepted commercial terms.
The earlier purchase-path restrictions and acceptance-hash contract are removed. This revision adds no new restriction on legacy purchase paths. It also removes
get_creative_addons, vendor registration schemas, signed-chain fields and vectors, and their server registry/capability additions. No addon runtime implementation is included.New schema fields are marked
x-added-in: 3.4.0; release packaging must wait for the 3.4 line. These annotations are informative, not an automatic build filter, so this must not be published as part of a 3.3 prerelease. No released artifact or package version is manually changed. New containers are open under DR-0036; commercial terms remain untouched.Related: #6700. The first-party disclosure portion also addresses the concept discussed in #6878; counting methodology and impression joinability remain outside this PR. These references do not close the broader issues.
Validation after merging upstream main
32a90ee0d0fd7d66505bb14277a84eeb6d15fb79:adjacent_codeis withheld from 3.3 responses and available in 3.4.The revision contains 19 files, including that test update. The local storyboard matrix is deferred to authoritative CI using the repository-supported option. Required CI checks, Working Group approval, and human schema review remain pending merge gates.