Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/building/by-layer/L4/choose-your-sdk.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,16 @@ Production stays on the 3.2 line and the packages above. For development and sta

| SDK | Package | AdCP bundle | Roles and transports | Known limits |
|---|---|---|---|---|
| **`@adcp/sdk`** (TypeScript) | `17.0.0-beta.3` (npm `beta` dist-tag) | Signed `3.3.0-beta.0`; also bundles stable 3.2.7, 3.1.29 and 3.0.25 | Buyer client and seller server, MCP and A2A | Identity and Web Bot Auth (`@adcp/sdk/identity-3.3`) remain experimental opt-ins. The standalone commercial-terms verifier fails closed on 3.3 definition pins; keep snapshot verification on the stable 3.2.7 contract. Reliable Reporting storage needs `@adcp/reporting-storage@0.3.0-beta.1`. |
| **`@adcp/sdk`** (TypeScript) | `17.0.0-beta.6` (npm `beta` dist-tag) | Signed `3.3.0-beta.1` only (beta.5 dropped `3.3-beta.0`; a beta.0 peer negotiates stable 3.2.7); also bundles stable 3.2.7, 3.1.29 and 3.0.25 | Buyer client and seller server, MCP and A2A | Identity and Web Bot Auth (`@adcp/sdk/identity-3.3`) remain experimental opt-ins. The standalone commercial-terms verifier fails closed on 3.3 definition pins; keep snapshot verification on the stable 3.2.7 contract. Reliable Reporting storage needs `@adcp/reporting-storage@0.3.0-beta.1`. |

No Python or Go package is listed for beta.0 yet. Until a row here names one, treat that SDK's 3.3 types and validators as unavailable.
No Python or Go package is listed for the 3.3 beta.1 preview yet. Until a row here names one, treat that SDK's 3.3 types and validators as unavailable.

```bash
npm install @adcp/sdk@17.0.0-beta.3
node -p "require('@adcp/sdk').ADCP_VERSION" # 3.3.0-beta.0
npm install @adcp/sdk@17.0.0-beta.6
node -p "require('@adcp/sdk').ADCP_VERSION" # 3.3.0-beta.1
```

SDK 17 is a major release. Before upgrading from 16, read the [16 to 17 migration guide](https://github.com/adcontextprotocol/adcp-client/blob/main/docs/migration-16-to-17.md). It changes the HTML-markup legacy formats (`display_html`, `display_WxH_html`) from `html5` to `display_tag` with inline-markup delivery ([#8339](https://github.com/adcontextprotocol/adcp/issues/8339)). It also fails closed on unresolved account references on 3.3 routes. A 3.3 seller must advertise `3.3-beta.0` in `supported_versions` before an SDK 17 buyer sends that pin.
SDK 17 is a major release. Before upgrading from 16, read the [16 to 17 migration guide](https://github.com/adcontextprotocol/adcp-client/blob/main/docs/migration-16-to-17.md). It changes the HTML-markup legacy formats (`display_html`, `display_WxH_html`) from `html5` to `display_tag` with inline-markup delivery ([#8339](https://github.com/adcontextprotocol/adcp/issues/8339)). It also fails closed on unresolved account references on 3.3 routes. A 3.3 seller must advertise `3.3-beta.1` in `supported_versions` before an SDK 17 buyer sends that pin.

Integrations that stay on 3.1 keep using the 3.1 lines: `@adcp/sdk` 13.x (npm `adcp-3.1` dist-tag) and `adcp` 7.x. The [SDK version map](/docs/reference/migration/3-1-to-3-2#sdk-versions-for-3-2) lists the 3.1 and 3.2 line for each language and each SDK's upgrade guide.

Expand Down
6 changes: 3 additions & 3 deletions docs/contributing/creative33-sandbox.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ description: "Exercise AdCP 3.3 beta creative workflows with the published SDK,

# Creative 3.3 beta sandbox

This development lab serves the frozen AdCP `3.3.0-beta.0` contract using the
published TypeScript SDK `17.0.0-beta.0`. Its MCP endpoint is:
This development lab serves the frozen AdCP `3.3.0-beta.1` contract using the
published TypeScript SDK `17.0.0-beta.6`. Its MCP endpoint is:

`https://test-agent.adcontextprotocol.org/beta/3.3/creative/mcp`

The wire selector is `3.3-beta.0`. The endpoint defaults to that beta and
The wire selector is `3.3-beta.1`. The endpoint defaults to that beta and
rejects stable or other prerelease selectors. Capability discovery lists only
this release and the implemented creative fixture contracts. All operations
finish synchronously.
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
},
"dependencies": {
"@adcp/reporting-storage": "0.3.0-beta.1",
"@adcp/sdk": "17.0.0-beta.3",
"@adcp/sdk": "17.0.0-beta.6",
"@anthropic-ai/sdk": "^0.127.0",
"@asteasolutions/zod-to-openapi": "^8.5.0",
"@contentauth/c2pa-node": "^0.9.7",
Expand Down
2 changes: 1 addition & 1 deletion scripts/sdk-response-conformance/known-findings.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{
"sdk": {"package":"@adcp/sdk","version":"17.0.0-beta.3"},
"sdk": {"package":"@adcp/sdk","version":"17.0.0-beta.6"},
"protocol": {
"version": "3.2.1",
"wire_selector": "3.2",
Expand Down
4 changes: 2 additions & 2 deletions server/src/training-agent/creative33/catalog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import { createHash } from 'node:crypto';
import { getAgentUrl } from '../config.js';

export const CREATIVE33_WIRE_VERSION = '3.3-beta.0';
export const CREATIVE33_SCHEMA_VERSION = '3.3.0-beta.0';
export const CREATIVE33_WIRE_VERSION = '3.3-beta.1';
export const CREATIVE33_SCHEMA_VERSION = '3.3.0-beta.1';
export const CREATIVE33_ROUTE = '/beta/3.3/creative';
export const CREATIVE33_SIZES = [{ width: 300, height: 250 }, { width: 728, height: 90 }];
export const CREATIVE33_RESPONSIVE_HTML = '<!doctype html><html><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1"><style>html,body{margin:0;width:100%;height:100%}body{display:grid;place-items:center;background:#163c31;color:white;font:18px sans-serif}</style></head><body>Acme outdoor — deterministic sandbox fixture</body></html>';
Expand Down
4 changes: 2 additions & 2 deletions server/src/training-agent/creative33/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ import {
} from './catalog.js';

export const CREATIVE33_ROUTE = CREATIVE33_MCP_ROUTE;
export const CREATIVE33_WIRE_VERSION = '3.3-beta.0';
export const CREATIVE33_BUNDLE_VERSION = '3.3.0-beta.0';
export const CREATIVE33_WIRE_VERSION = '3.3-beta.1';
export const CREATIVE33_BUNDLE_VERSION = '3.3.0-beta.1';
const NAMESPACE = 'adcp-training-agent:creative33';
const logger = createLogger('training-agent-creative33');
const TOOLS = new Set([
Expand Down
2 changes: 1 addition & 1 deletion server/src/training-agent/task-handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3302,7 +3302,7 @@ import {
const SUPPORTED_MAJOR_VERSIONS = [3] as const;
const SUPPORTED_RELEASE_VERSIONS = TRAINING_AGENT_SUPPORTED_RELEASE_VERSIONS;
const DEFAULT_ADCP_VERSION = TRAINING_AGENT_DEFAULT_ADCP_VERSION;
const CORE_GENDER_CANDIDATE_VERSION = '3.3-beta.0';
const CORE_GENDER_CANDIDATE_VERSION = '3.3-beta.1';
export const TRAINING_ACCEPTANCE_POLICY_CATALOG_PATH = '/registry/acceptance-policy-catalog.json';
export const TRAINING_ACCEPTANCE_POLICY_CATALOG_DIGEST = 'sha256:3afb3865dbd69025b4f925c5c018c7659fa0a744efcb0b12b87e1b3a119b3d2a';
export const TRAINING_ACCEPTANCE_POLICY_DEFAULT_PROFILE = 'meta_political_advertising_acceptance';
Expand Down
4 changes: 2 additions & 2 deletions server/tests/unit/storyboard-cache.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('compliance storyboard cache', () => {
});

it('parses a bundle once and serves every ID from it', () => {
const options = { version: '3.3.0-beta.0', complianceDir: '/bundles/3.3' };
const options = { version: '3.3.0-beta.1', complianceDir: '/bundles/3.3' };
expect(getCachedComplianceStoryboardById('a', options)?.id).toBe('a');
expect(getCachedComplianceStoryboardById('b', { ...options, unrelatedRunOption: true } as never)?.id).toBe('b');
expect(getCachedComplianceStoryboardById('missing', options)).toBeUndefined();
Expand All @@ -30,7 +30,7 @@ describe('compliance storyboard cache', () => {

it('keeps bundles for different versions or directories apart', () => {
getCachedComplianceStoryboardById('a', { version: '3.2', complianceDir: '/x' });
getCachedComplianceStoryboardById('a', { version: '3.3.0-beta.0', complianceDir: '/x' });
getCachedComplianceStoryboardById('a', { version: '3.3.0-beta.1', complianceDir: '/x' });
getCachedComplianceStoryboardById('a', { version: '3.2', complianceDir: '/y' });
getCachedComplianceStoryboardById('a', { version: '3.2', complianceDir: '/y', hostedStableLineAlias: '3.2' });
expect(list).toHaveBeenCalledTimes(4);
Expand Down
38 changes: 19 additions & 19 deletions server/tests/unit/training-agent-candidate-version.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { storyboardStepStatus } from '../manual/storyboard-report-format.js';

vi.hoisted(() => {
process.env.ADCP_STORYBOARD_CANDIDATE_VERSION_MODE = '1';
process.env.ADCP_TRAINING_CANDIDATE_VERSION = '3.3-beta.0';
process.env.ADCP_TRAINING_CANDIDATE_VERSION = '3.3-beta.1';
process.env.PUBLIC_TEST_AGENT_TOKEN = 'candidate-version-test-token';
});

Expand All @@ -35,8 +35,8 @@ describe('local candidate wire contract', () => {
}
const indexPath = path.join(schemaRoot, 'index.json');
const index = JSON.parse(readFileSync(indexPath, 'utf8'));
writeFileSync(indexPath, JSON.stringify({ ...index, adcp_version: '3.3.0-beta.0' }));
registerExternalSchemaRoot('3.3.0-beta.0', schemaRoot);
writeFileSync(indexPath, JSON.stringify({ ...index, adcp_version: '3.3.0-beta.1' }));
registerExternalSchemaRoot('3.3.0-beta.1', schemaRoot);
const { createTrainingAgentRouter } = await import('../../src/training-agent/index.js');
const app = express();
app.use(express.json({ verify: (req, _res, body) => {
Expand All @@ -56,13 +56,13 @@ describe('local candidate wire contract', () => {
server.closeAllConnections();
await new Promise<void>(resolve => server.close(() => resolve()));
}
unregisterExternalSchemaRoot('3.3.0-beta.0');
unregisterExternalSchemaRoot('3.3.0-beta.1');
if (schemaRoot) rmSync(schemaRoot, { recursive: true, force: true });
});

it('requires the test runtime and both trusted candidate settings', () => {
const config = { NODE_ENV: 'test', ADCP_STORYBOARD_CANDIDATE_VERSION_MODE: '1', ADCP_TRAINING_CANDIDATE_VERSION: '3.3-beta.0' };
expect(trainingAgentCandidateVersion(config)).toBe('3.3-beta.0');
const config = { NODE_ENV: 'test', ADCP_STORYBOARD_CANDIDATE_VERSION_MODE: '1', ADCP_TRAINING_CANDIDATE_VERSION: '3.3-beta.1' };
expect(trainingAgentCandidateVersion(config)).toBe('3.3-beta.1');
for (const NODE_ENV of ['production', 'development', undefined]) {
expect(trainingAgentCandidateVersion({ ...config, NODE_ENV })).toBeUndefined();
}
Expand All @@ -73,7 +73,7 @@ describe('local candidate wire contract', () => {
});

it.each(['brand', 'sales'])('negotiates real candidate and explicit stable requests through /%s/mcp', async tenant => {
for (const adcp_version of ['3.3-beta.0', '3.2', undefined]) {
for (const adcp_version of ['3.3-beta.1', '3.2', undefined]) {
const response = await fetch(`${baseUrl}/${tenant}/mcp`, {
method: 'POST',
headers: { 'content-type': 'application/json', accept: 'application/json, text/event-stream', authorization: 'Bearer candidate-version-test-token' },
Expand All @@ -85,10 +85,10 @@ describe('local candidate wire contract', () => {
expect(result.adcp_error, JSON.stringify(result)).toBeUndefined();
expect(result.adcp_version).toBe(adcp_version ?? '3.2');
expect(result.adcp.supported_versions).toContain('3.2');
expect(result.adcp.supported_versions.filter((version: string) => version === '3.3-beta.0')).toHaveLength(1);
expect(result.adcp.supported_versions.filter((version: string) => version === '3.3-beta.1')).toHaveLength(1);
expect(result.experimental_features ?? []).not.toContain('media_buy.gender_targeting');
if (tenant === 'sales') {
if (adcp_version === '3.3-beta.0') expect(result.specialisms).toContain('sales-fixed-rate');
if (adcp_version === '3.3-beta.1') expect(result.specialisms).toContain('sales-fixed-rate');
else expect(result.specialisms).not.toContain('sales-fixed-rate');
expect(result.compliance_testing.scenarios).toContain('force_media_buy_confirmation');
}
Expand All @@ -98,11 +98,11 @@ describe('local candidate wire contract', () => {
it('keeps gender preview opt-in independent and candidate versions unique with both flags', async () => {
const preview = createTrainingAgentServer({ mode: 'open', developmentCoreGender: true });
const handler = (preview as unknown as { _requestHandlers: Map<string, Function> })._requestHandlers.get('tools/call')!;
for (const adcp_version of ['3.3-beta.0', '3.2']) {
for (const adcp_version of ['3.3-beta.1', '3.2']) {
const response = await handler({ method: 'tools/call', params: { name: 'get_adcp_capabilities', arguments: { adcp_version } } }, {});
const result = response.structuredContent;
expect(result.adcp.supported_versions.filter((version: string) => version === '3.3-beta.0')).toHaveLength(1);
if (adcp_version === '3.3-beta.0') expect(result.experimental_features ?? []).toContain('media_buy.gender_targeting');
expect(result.adcp.supported_versions.filter((version: string) => version === '3.3-beta.1')).toHaveLength(1);
if (adcp_version === '3.3-beta.1') expect(result.experimental_features ?? []).toContain('media_buy.gender_targeting');
else expect(result.experimental_features ?? []).not.toContain('media_buy.gender_targeting');
}
await preview.close();
Expand All @@ -114,10 +114,10 @@ describe('local candidate wire contract', () => {
const response = await fetch(`${baseUrl}/mcp`, {
method: 'POST',
headers: { 'content-type': 'application/json', accept: 'application/json, text/event-stream', authorization: 'Bearer candidate-version-test-token' },
body: JSON.stringify({ jsonrpc: '2.0', id: 1, method: 'tools/call', params: { name: 'get_adcp_capabilities', arguments: { adcp_version: '3.3-beta.0' } } }),
body: JSON.stringify({ jsonrpc: '2.0', id: 1, method: 'tools/call', params: { name: 'get_adcp_capabilities', arguments: { adcp_version: '3.3-beta.1' } } }),
});
const result = (await response.json()).result?.structuredContent;
expect(result?.adcp_version, JSON.stringify(result).slice(0, 300)).toBe('3.3-beta.0');
expect(result?.adcp_version, JSON.stringify(result).slice(0, 300)).toBe('3.3-beta.1');
expect(result.account).toBeDefined();
expect(result.account).not.toHaveProperty('stable_account_id');
});
Expand All @@ -126,17 +126,17 @@ describe('local candidate wire contract', () => {
const legacy = createTrainingAgentServer({ mode: 'open', strict: true, legacySigningProfile: true });
const handler = (legacy as unknown as { _requestHandlers: Map<string, Function> })._requestHandlers.get('tools/call')!;
const response = await handler({ method: 'tools/call', params: {
name: 'get_adcp_capabilities', arguments: { adcp_version: '3.3-beta.0' },
name: 'get_adcp_capabilities', arguments: { adcp_version: '3.3-beta.1' },
} }, {});
expect(response.structuredContent.adcp_error.code).toBe('VERSION_UNSUPPORTED');
expect(response.structuredContent.adcp_error.details.supported_versions).not.toContain('3.3-beta.0');
expect(response.structuredContent.adcp_error.details.supported_versions).not.toContain('3.3-beta.1');
await legacy.close();
});

it('reports real SDK advisory findings without overriding its blocking validation verdict', async () => {
const storyboard = loadStoryboardFile(path.resolve('static/compliance/source/universal/capability-discovery.yaml'));
const options = {
adcpVersion: '3.3.0-beta.0', wireAdcpVersion: '3.3-beta.0', schemaRoot,
adcpVersion: '3.3.0-beta.1', wireAdcpVersion: '3.3-beta.1', schemaRoot,
auth: { type: 'bearer' as const, token: 'candidate-version-test-token' }, allow_http: true,
};
const advisory = await runStoryboardStep(`${baseUrl}/sales/mcp`, storyboard, 'get_capabilities', options);
Expand Down Expand Up @@ -173,8 +173,8 @@ describe('local candidate wire contract', () => {
return result;
};
const account = { brand: { domain: 'candidate-three-three.example' }, operator: 'candidate-three-three.example', sandbox: true };
for (const adcp_version of ['3.3-beta.0', '3.2']) {
const current = adcp_version === '3.3-beta.0';
for (const adcp_version of ['3.3-beta.1', '3.2']) {
const current = adcp_version === '3.3-beta.1';
const sales = await call('sales', 'get_adcp_capabilities', { adcp_version });
expect(sales.account.stable_account_id).toBe(current ? true : undefined);
expect(sales.media_buy.features.supports_property_breakdown).toBe(current ? true : undefined);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import type { ToolArgs, TrainingContext } from '../../src/training-agent/types.j
const FIELD = 'start_requires_all_creatives_approved';
const ACCOUNT = { brand: { domain: 'nova-start-policy.example' }, operator: 'pinnacle-agency.example', sandbox: true };
const BRAND = { domain: 'nova-start-policy.example' };
const CANDIDATE_CTX: TrainingContext = { mode: 'open', servedAdcpVersion: '3.3-beta.0' };
const CANDIDATE_CTX: TrainingContext = { mode: 'open', servedAdcpVersion: '3.3-beta.1' };
const STABLE_CTX: TrainingContext = { mode: 'open', servedAdcpVersion: '3.2' };
const PRODUCT = { product_id: 'start_policy_display', pricing_option_id: 'fixed_cpm' };
type Result = Record<string, unknown>;
Expand Down
4 changes: 2 additions & 2 deletions server/tests/unit/training-agent-creative33-buyer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('published SDK buyer journeys on the frozen creative 3.3 beta', () => {
await new Promise<void>(resolve => server.once('listening', resolve));
base = `http://127.0.0.1:${(server.address() as { port: number }).port}`;
agent = ADCPMultiAgentClient.simple(`${base}/beta/3.3/creative/mcp`, {
authToken: 'buyer-flow-test', adcpVersion: '3.3.0-beta.0', wireAdcpVersion: '3.3-beta.0', timeout: 15000,
authToken: 'buyer-flow-test', adcpVersion: '3.3.0-beta.1', wireAdcpVersion: '3.3-beta.1', timeout: 15000,
}).agent('default-agent');
});
afterAll(async () => {
Expand All @@ -60,7 +60,7 @@ describe('published SDK buyer journeys on the frozen creative 3.3 beta', () => {

it('discovers the frozen contract', async () => {
const discovered = data(await agent.getAdcpCapabilities({}));
expect(discovered).toMatchObject({ adcp_version: '3.3-beta.0', adcp: { supported_versions: ['3.3-beta.0'] } });
expect(discovered).toMatchObject({ adcp_version: '3.3-beta.1', adcp: { supported_versions: ['3.3-beta.1'] } });
const formats = object(discovered.creative).supported_formats as Json[];
expect(formats.find(value => value.capability_id === capabilityId)).toMatchObject({ format: { format_kind: kind }, operations: expect.arrayContaining(['build', 'preview']) });
});
Expand Down
4 changes: 2 additions & 2 deletions server/tests/unit/training-agent-creative33-routing.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from '../../src/training-agent/creative33/router.js';

const PATH = '/beta/3.3/creative/mcp';
const VERSION = '3.3-beta.0';
const VERSION = '3.3-beta.1';
const ACCOUNT = { account_id: 'creative33_sandbox' };
const PRINCIPALS: Record<string, string> = {
'buyer-a': 'test:creative33:buyer-a',
Expand Down Expand Up @@ -276,7 +276,7 @@ describe('creative 3.3 beta route security boundaries', () => {
}
});

it.each(['3.2', '3.3', '3.3-beta.1', '3.3.0-beta.0', '../latest'])('refuses version %s without persisting', async version => {
it.each(['3.2', '3.3', '3.3-beta.0', '3.3.0-beta.1', '../latest'])('refuses version %s without persisting', async version => {
const app = boot();
const id = `wrong_version_${randomUUID()}`;
const response = await sync(app, creative(id), 'buyer-a', randomUUID(), { adcp_version: version });
Expand Down
Loading
Loading