Skip to content

fix(schema): withdraw 3.3 additions from get_products and sync_creatives assignments (#8501) - #8758

Merged
bokelley merged 3 commits into
mainfrom
fix/8501-get-products-sync-creatives-withdrawals
Nov 12, 2026
Merged

bokelley merged 3 commits into
mainfrom
fix/8501-get-products-sync-creatives-withdrawals

Conversation

@bokelley

@bokelley bokelley commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Refs #8501. This PR covers entries 20–25 of the disposition table and the get_products rows of the "Deprecated-task fields outside the 26" table.

Merge only after the consent window closes (Fri 2026-11-13), before the 3.3 RC. static/schemas/source/** is Ladon-gated, so a human merges it. Merge order: this PR first, then #8767, which is stacked on it. #8762 covers entries 11 and 12.

3.3 adds no field that exists only on a deprecated task. Every field below shipped in a 3.3 beta (through 3.3.0-beta.5), so this is a beta-to-beta change and breaks no stable release.

Rebased onto main after #8866

#8866 opened most of the rows this PR edits. Three changes follow, per the #8501 re-triage and the release coordinator's rulings:

  1. No baseline hunk. fix(schemas): open the 3.3 schemas that were meant to be open #8866 already removed the entry 20–25 rows from scripts/lint-additive-minor-baseline.json, so this PR no longer touches it.
  2. The withdrawn request fields are rejected by name, not by closure.
    • The deprecated sync_creatives assignments[] row is open now. It gets not: { anyOf: [{ required: ["trackers"] }, { required: ["landing_page_url"] }] } and a description sentence, matching unassign, replace and merge. The schema and the training agent's INVALID_REQUEST agree.
    • The get_products refine[] product entry is open now too. It gets not: { required: ["package"] }, so every scope rejects package (fix(schemas): open the 3.3 schemas that were meant to be open #8866 already named it on the request and proposal scopes), and the union description says why. This keeps the training agent's "reject what a facade can't honor" rule true.
    • The response-side refinement_applied[] fields are just undefined: readers ignore unknown fields.
  3. Release docs belong to docs(reference): bring the 3.3 release docs to 3.3.0-rc.0 #8883. This PR no longer edits 3-3-beta.mdx, the 3.2→3.3 migration guide, release-notes.mdx or whats-new-in-3-3.mdx.

Text this PR adds now says 3.3.0-beta.5 where it said beta.4. Where it said a schema was closed, it now says what #8866 left: the purchase input and offer filters are open but don't define target_audiences, and canonical-pricing-option.json and product-purchase.json are held closed with the commercial terms until 4.0.

Field → disposition

# / row Field Disposition What this PR does
20 sync_creatives assignments[] landing_page_url Withdraw Removed from the deprecated row, which rejects it by name. The assign operation keeps it (entries 18–19 untouched).
21 sync_creatives assignments[] trackers Withdraw Same as 20.
22 get_products refine[].package Withdraw Removed, along with its buying_mode/finalize rule, and rejected by name on every scope. media-buy/package-forecast-input.json is deleted because nothing else references it.
23 refinement_applied[].result_product_id Withdraw with 22 Removed, along with the applied rule.
24 refinement_applied[].resolved_start_time Withdraw with 22 Removed.
25 refinement_applied[].resolved_end_time Withdraw with 22 Removed.
row get_products filters.target_audiences Withdraw, 4.0 list Removed from core/product-filters.json. The existing purchase_target_audiences_required_in_4_0 check now records the withdrawal. It is not added to list_products offer_filters in 3.3.
row get_products include_collections / collections Withdraw Removed from the request, the response and the get-products-rejected.json branch, and dropped from the wholesale_feed_version scope. list_products, request_proposals and refine_proposals keep them.
row get_products include_execution_readiness / execution_readiness Move Moved onto the open list_products request and response. The map is absent on unchanged; the storyboard now drives list_products.
row price_adjustments on get_products pricing options (experimental) Withdraw, 4.0 list Removed from the 7 fixed-price options. Also removed: pricing-options/price-adjustments.json, error-details/price-adjustments-mismatch.json, the product allOf rule, the product-purchase.json verifier constraint, and the vectors and their test. New registry check: canonical_price_adjustments_required_in_4_0.
row counting_mechanisms (experimental) Withdraw Not in this PR. It is one property on the shared core/measurement-terms.json, which #8767 removes.

Not touched: metric_id (entry 6), available_installment_statuses, entries 1 and 11–12, and the create/update rows.

Also updated

  • Training agent:
    • get_products ignores include_collections: no collections array and no cards-scoped feed token. It still projects sample_content.
    • The tenant tool listing drops include_collections from get_products at every version.
    • sync_creatives rejects trackers/landing_page_url on a legacy assignments[] row with INVALID_REQUEST, as the schema now does by name.
    • The unsupported-package-forecast path is removed. A refine[] entry with package fails source validation.
  • Baselines: scripts/oneof-discriminators.baseline.json drops the three price-adjustments rows.
  • v4 registry and guide:
    • Adds canonical_price_adjustments_required_in_4_0, with its design and the preserving commit 4c35f8ce1.
    • Updates the purchase_target_audiences_required_in_4_0 text.
    • Removes the package-forecast-input.json format_ids site.
  • Docs: get_products, list_products (new per-account readiness section), specification, refinement, sync_creatives, pricing-models, collections-and-installments, media-products, targeting, broadcast, error-handling, experimental-status, and the test-vectors index. The target-audience matching rules stay on get_products.mdx, under the withdrawn heading with an explicit target-audiences-experimental anchor, until fix(schema): keep 3.3 additions off the deprecated create_media_buy and update_media_buy (#8501) #8767 moves them into the 4.0 design.
  • Changeset: minor. It lists every withdrawn or moved field, following withdraw-commercial-terms-features-to-4-0.md.

For reviewers

  • Discovery budget. Moving readiness onto list_products pushed the compact-discovery tools/list input schemas over the 162 KiB budget. I kept the budget and shortened the flag's description instead, dropping "default": false; the docs say "absent means false". product-discovery-schema-parity passes on the rebased tree.

Open WG question

Where does the exact-package forecast (#8468) live? This PR removes it from get_products and does not invent a new home. Konstantin flagged it as the one field he couldn't place. Wherever it lands has to carry the goal, because #8448 says "A guaranteed forecast depends on the goal". The design is preserved at 163ba7e7e9 (#8468).

Tests

On the rebased tree (main 2dc672e316 + 67bb4b87dc + db09bd59e8), run sequentially. A third commit, 8ff88b15f0, fixes the beta range in the 4.0 page's price_adjustments section. The Ladon review found it. That commit passes the registry tests, the docs validation and the hand-run hook steps (test:unit included).

Refreshed after #8762 and #8957 merged. The three commits are rebased onto main 7dd93fe024, with no conflicts: 315c288c1f, 9b3369f375 and d2d905a547. On the stacked #8767 tree (a superset of this one), build:schemas, lint:additive-minor (2 recorded, 0 new), test:mcp-schema-projection 41/41 (the controller stays under the 1,388,000 bound), capabilities-structural-bounds 25/25 and the withdrawal, installment and service-commitment suites (50/50) pass. CI is the gate for the rest.

  • npm run build:schemas: pass.
  • npm run test:schemas: 1181/1181, plus premium-display 10/10 and geo-region 6/6. That includes tests/get-products-deprecated-withdrawals.test.cjs with the new "refine[].package is rejected by name on every scope" test (one accept and one reject probe), and assignment-trackers and assignment-landing-page, which now probe the row's named rejection and that the row accepts an unrelated key.
  • npm run test:mcp-schema-projection 41/41, npm run test:examples, npm run test:contracts 464/464, npm run test:audience-evidence 40/40, npm run test:v4-compatibility-registry 19/19: pass.
  • npm run lint:additive-minor (4 recorded, 0 new), test:additive-minor, scripts/lint-v4-compatibility-registry.cjs, scripts/audit-oneof.mjs --check, npm run build:compliance -- --check (1882 references current), and the changeset scope check: pass.
  • Server vitest, the files this PR touches: assignment-operations 19/19, training-agent-collections 10/10, served-release-shape 11/11, product-discovery-schema-parity 4/4.
  • Pre-push: version sync, changeset policy and docs validation (58/58) pass. The local storyboard matrix was skipped with ADCP_SKIP_STORYBOARD_MATRIX=1 for load, as the playbook allows. CI's training-agent-storyboards job is the gate.

Local hook

Both rebased commits were made with HUSKY=0, with the release coordinator's approval. The hook's server-unit stage (precommit:server-unit) times out at this load (1500s budget, no assertion failures in the earlier #8762 run), so it was skipped for load. CI is the gate.

I ran the other hook steps by hand on the final tree. The dynamic-import, format-identity and callApi guards, npm run typecheck and the image check pass. npm run test:unit had 6 timeout failures in 3 files this PR doesn't touch (addie/billing-tools, billing/organization-db, billing/stripe-client), and those 3 files pass 141/141 on their own.

SDK generation: the SDK repos may need a regen for the removed and moved types (PackageForecastInput, PriceAdjustments, the get_products readiness and collections fields, and the list_products readiness fields). Not fixed here.

🤖 Generated with Claude Code

bokelley added a commit that referenced this pull request Nov 6, 2026
…rm remains (#8501)

With filters.target_audiences withdrawn from get_products (#8758) and the
package copy withdrawn from create_media_buy and update_media_buy, the
experimental media_buy.audience_evidence_targets has no 3.3 wire form.

- Delete core/audience-evidence-target.json and
  enums/audience-evidence-relationship.json and their index.json entries.
  The stable inline relationship enums on audience evidence stay.
- Drop the feature from the active inventories and publication claims:
  experimental status, release notes, What's new, the migration guide's
  experiments paragraph, and the changeset.
- Move the target-matching rules from get_products.mdx into the preserved
  4.0 design under purchase_target_audiences_required_in_4_0, keeping a short
  withdrawal notice at the old anchor; the check keeps its id and its
  detection no longer keys off the retired feature id.
- Retire tests/audience-evidence-targets.test.cjs (preserved at d9b5417)
  and stop reading the deleted package-forecast-input.json in
  tests/creative-start-policy.test.cjs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 7, 2026
…erimental, and inventory the rest

Adds scripts/audit-schema-bounds.cjs and its inventory: every unbounded array and string in the schema source, by stability, request or response side and proposed limit, plus every property or collection list carried inline. Bounds the arrays and strings that are new in 3.3 or experimental: 646 maxItems/maxLength keywords in 152 schemas, written by `node scripts/audit-schema-bounds.cjs --apply`, which is idempotent and is the one command for regenerating the slice after a conflict. Stable fields are proposed for 4.0 in specs/collection-bounds-proposal.md and registered as schema_bounds_required_in_4_0.

Not bounded: get_adcp_capabilities and its referenced types (#8198), inline property and collection lists, five nodes the SDK generators cannot carry a bound on, and seven 3.3 beta fields that the #8501 withdrawal PRs (#8765, #8762, #8758, #8767) remove.

The script now compares with the highest 3.2.x release (3.2.8), the base lint-additive-minor uses. Build Check runs its --check-unreleased guard as npm run lint:schema-bounds, so every new 3.3 or experimental array or string arrives with a bound. The MCP parity compile limit moves from 1,376,000 to 1,378,000 bytes (the controller closure measures 1,377,055).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 7, 2026
…erimental, and inventory the rest

Adds scripts/audit-schema-bounds.cjs and its inventory: every unbounded array and string in the schema source, by stability, request or response side and proposed limit, plus every property or collection list carried inline. Bounds the arrays and strings that are new in 3.3 or experimental: 646 maxItems/maxLength keywords in 152 schemas, written by `node scripts/audit-schema-bounds.cjs --apply`, which is idempotent and is the one command for regenerating the slice after a conflict. Stable fields are proposed for 4.0 in specs/collection-bounds-proposal.md and registered as schema_bounds_required_in_4_0.

Not bounded: get_adcp_capabilities and its referenced types (#8198), inline property and collection lists, five nodes the SDK generators cannot carry a bound on, and seven 3.3 beta fields that the #8501 withdrawal PRs (#8765, #8762, #8758, #8767) remove.

The script now compares with the highest 3.2.x release (3.2.8), the base lint-additive-minor uses. Build Check runs its --check-unreleased guard as npm run lint:schema-bounds, so every new 3.3 or experimental array or string arrives with a bound. The MCP parity compile limit moves from 1,376,000 to 1,378,000 bytes (the controller closure measures 1,377,055).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 8, 2026
…erimental, and inventory the rest

Adds scripts/audit-schema-bounds.cjs and its inventory: every unbounded array and string in the schema source, by stability, request or response side and proposed limit, plus every property or collection list carried inline. Bounds the arrays and strings that are new in 3.3 or experimental: 648 maxItems/maxLength keywords in 152 schemas, written by `node scripts/audit-schema-bounds.cjs --apply`, which is idempotent and is the one command for regenerating the slice after a conflict. Stable fields are proposed for 4.0 in specs/collection-bounds-proposal.md and registered as schema_bounds_required_in_4_0.

Not bounded: get_adcp_capabilities and its referenced types (#8198), inline property and collection lists, five nodes the SDK generators cannot carry a bound on, and seven 3.3 beta fields that the #8501 withdrawal PRs (#8765, #8762, #8758, #8767) remove.

The script now compares with the highest 3.2.x release (3.2.8), the base lint-additive-minor uses. Build Check runs its --check-unreleased guard as npm run lint:schema-bounds, so every new 3.3 or experimental array or string arrives with a bound. The match_keys arrays #8446 added on product identity and TMP provider registration get maxItems 64, the cap media_buy.supported_match_keys already carries. The MCP parity compile limit moves from 1,384,000 to 1,386,000 bytes (the controller closure measures 1,385,040).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 8, 2026
…erimental, and inventory the rest

Adds scripts/audit-schema-bounds.cjs and its inventory: every unbounded array and string in the schema source, by stability, request or response side and proposed limit, plus every property or collection list carried inline. Bounds the arrays and strings that are new in 3.3 or experimental: 648 maxItems/maxLength keywords in 152 schemas, written by `node scripts/audit-schema-bounds.cjs --apply`, which is idempotent and is the one command for regenerating the slice after a conflict. Stable fields are proposed for 4.0 in specs/collection-bounds-proposal.md and registered as schema_bounds_required_in_4_0.

Not bounded: get_adcp_capabilities and its referenced types (#8198), inline property and collection lists, five nodes the SDK generators cannot carry a bound on, and seven 3.3 beta fields that the #8501 withdrawal PRs (#8765, #8762, #8758, #8767) remove.

The script now compares with the highest 3.2.x release (3.2.8), the base lint-additive-minor uses. Build Check runs its --check-unreleased guard as npm run lint:schema-bounds, so every new 3.3 or experimental array or string arrives with a bound. The match_keys arrays #8446 added on product identity and TMP provider registration get maxItems 64, the cap media_buy.supported_match_keys already carries. The MCP parity compile limit moves from 1,384,000 to 1,386,000 bytes (the controller closure measures 1,385,040).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 8, 2026
…erimental, and inventory the rest

Adds scripts/audit-schema-bounds.cjs and its inventory: every unbounded array and string in the schema source, by stability, request or response side and proposed limit, plus every property or collection list carried inline. Bounds the arrays and strings that are new in 3.3 or experimental: 648 maxItems/maxLength keywords in 152 schemas, written by `node scripts/audit-schema-bounds.cjs --apply`, which is idempotent and is the one command for regenerating the slice after a conflict. Stable fields are proposed for 4.0 in specs/collection-bounds-proposal.md and registered as schema_bounds_required_in_4_0.

Not bounded: get_adcp_capabilities and its referenced types (#8198), inline property and collection lists, five nodes the SDK generators cannot carry a bound on, and seven 3.3 beta fields that the #8501 withdrawal PRs (#8765, #8762, #8758, #8767) remove.

The script now compares with the highest 3.2.x release (3.2.8), the base lint-additive-minor uses. Build Check runs its --check-unreleased guard as npm run lint:schema-bounds, so every new 3.3 or experimental array or string arrives with a bound. The match_keys arrays #8446 added on product identity and TMP provider registration get maxItems 64, the cap media_buy.supported_match_keys already carries. The MCP parity compile limit moves from 1,384,000 to 1,386,000 bytes (the controller closure measures 1,385,040).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bokelley
bokelley force-pushed the fix/8501-get-products-sync-creatives-withdrawals branch from 58e0269 to db09bd5 Compare November 12, 2026 16:42
bokelley added a commit that referenced this pull request Nov 12, 2026
…nd update_media_buy (#8501)

create_media_buy and update_media_buy are deprecated compatibility tasks, so
3.3 adds nothing to them. Six fields the 3.3 betas added to them are removed;
the live tasks keep every one they also carry.

- predecessor_media_buy_id, lineage_reason: off create_media_buy; stay on
  buy_products, accept_proposal and get_media_buys.
- artifact_webhook.signing_profile: off create_media_buy; no live task has
  artifact_webhook, so it is signed with adcp/webhook-signing/v1.
- start_requires_all_creatives_approved: off package-request, package-update
  and core/package.json; stays on control_media_buy and get_media_buys.
- target_audiences: off package-request; with #8758 withdrawing the
  get_products copy, no 3.3 wire form remains.
- trackers, landing_page_url: off core/creative-assignment.json; stay on
  sync_creatives assign, list_creatives and get_media_buys.
- billing_measurement.counting_mechanisms: off core/measurement-terms.json
  (create, update and get_products); the canonical terms gain it in 4.0.

The training agent ignores the withdrawn fields on create/update, as the
versioning rules require for unknown fields, and no longer echoes them in
create/update responses; get_media_buys still reads back what assign set.
The 4.0 registry and the task references say where each field lives; the
3.3 release pages are left to #8883. Text that called the purchase,
offer-filter or canonical measurement schemas closed now says what #8866
left: the first two are open but don't define the field, and the
canonical terms are held closed with the commercial terms until 4.0.

Refs #8501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 12, 2026
…rm remains (#8501)

With filters.target_audiences withdrawn from get_products (#8758) and the
package copy withdrawn from create_media_buy and update_media_buy, the
experimental media_buy.audience_evidence_targets has no 3.3 wire form.

- Delete core/audience-evidence-target.json and
  enums/audience-evidence-relationship.json and their index.json entries.
  The stable inline relationship enums on audience evidence stay.
- Drop the feature from the changeset. Its experimental-status row went
  with the previous commit, and the 3.3 release pages are left to #8883.
- Move the target-matching rules from get_products.mdx into the preserved
  4.0 design under purchase_target_audiences_required_in_4_0, keeping a short
  withdrawal notice at the old anchor; the check keeps its id and its
  detection no longer keys off the retired feature id.
- Retire tests/audience-evidence-targets.test.cjs (preserved at d9b5417)
  and stop reading the deleted package-forecast-input.json in
  tests/creative-start-policy.test.cjs.

Refs #8501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bokelley
bokelley marked this pull request as ready for review November 12, 2026 17:04

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — gated schema paths require human/CODEOWNERS approval, plus a breaking-class protocol withdrawal.

This PR touches the published protocol surface under static/schemas/source/** (the hard, path-based approval gate), and review_decision is REVIEW_REQUIRED — not APPROVED. Per decision-table row 2, the gate is not satisfied, so this cannot be approved or plain-commented. Independently, the change withdraws 3.3-beta additions (deletes price-adjustments.json, price-adjustments-mismatch.json, package-forecast-input.json and removes pricing-option/product rules), which is a Breaking-class protocol change — ratification is a human act and is never auto-approved unless review_decision is APPROVED.

Reviewer confirms schema↔docs coherence holds across all 62 files (no dangling $refs, clean oneof-baseline removal, consistent training-agent/compliance migration, withdrawals test present). No critical/high findings. One medium finding remains (a beta.4 vs beta.5 inconsistency in the migration doc) but it is not the driver here.

Escalation reasons

  • static/schemas/source/** is a gated path and review_decision is REVIEW_REQUIRED (not APPROVED) — human/CODEOWNERS review required.
  • Deleted protocol schema files (static/schemas/source/error-details/price-adjustments-mismatch.json, static/schemas/source/media-buy/package-forecast-input.json, static/schemas/source/pricing-options/price-adjustments.json) — deletions in a sensitive path.
  • Breaking-class protocol withdrawal — ratification requires human sign-off.

Medium findings

  • docs/reference/migration/v4-compatibility.mdx:229 — states price_adjustments beta.4 twice; changeset, v4-compatibility.yaml, and pricing-models.mdx all say beta.5. Please reconcile.

Medium findings

  • docs/reference/migration/v4-compatibility.mdx:229 — v4-compatibility.mdx says price_adjustments beta.4; changeset/registry/pricing-models say beta.5

Why human review

  • static/schemas/source/** is a gated path and review_decision is REVIEW_REQUIRED (not APPROVED) — human/CODEOWNERS review required
  • Deletes protocol schema files (price-adjustments-mismatch.json, package-forecast-input.json, price-adjustments.json) in static/schemas/source/** — deletion in sensitive path
  • Breaking-class protocol withdrawal — ratification requires human sign-off; never auto-approved unless review_decision is APPROVED
  • This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/core/execution-requirement-readiness.json (modified) matches static/schemas/source/**; static/schemas/source/core/product-execution-readiness.json (modified) matches static/schemas/source/**; static/schemas/source/core/product-execution-requirement.json (modified) matches static/schemas/source/**; static/schemas/source/core/product-filters.json (modified) matches static/schemas/source/**; static/schemas/source/core/product.json (modified) matches static/schemas/source/**; static/schemas/source/core/targeting-overlay-support.json (modified) matches static/schemas/source/**; static/schemas/source/creative/sync-creatives-request.json (modified) matches static/schemas/source/**; static/schemas/source/error-details/price-adjustments-mismatch.json (deleted) matches static/schemas/source/**; static/schemas/source/media-buy/get-products-rejected.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/get-products-request.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/get-products-response.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/list-products-request.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/list-products-response.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/package-forecast-input.json (delet

…(truncated)…

@aao-secretariat aao-secretariat Bot added the ladon/needs-human-review Ladon has escalated this PR for human review. label Nov 12, 2026
bokelley added a commit that referenced this pull request Nov 12, 2026
…nd update_media_buy (#8501)

create_media_buy and update_media_buy are deprecated compatibility tasks, so
3.3 adds nothing to them. Six fields the 3.3 betas added to them are removed;
the live tasks keep every one they also carry.

- predecessor_media_buy_id, lineage_reason: off create_media_buy; stay on
  buy_products, accept_proposal and get_media_buys.
- artifact_webhook.signing_profile: off create_media_buy; no live task has
  artifact_webhook, so it is signed with adcp/webhook-signing/v1.
- start_requires_all_creatives_approved: off package-request, package-update
  and core/package.json; stays on control_media_buy and get_media_buys.
- target_audiences: off package-request; with #8758 withdrawing the
  get_products copy, no 3.3 wire form remains.
- trackers, landing_page_url: off core/creative-assignment.json; stay on
  sync_creatives assign, list_creatives and get_media_buys.
- billing_measurement.counting_mechanisms: off core/measurement-terms.json
  (create, update and get_products); the canonical terms gain it in 4.0.

The training agent ignores the withdrawn fields on create/update, as the
versioning rules require for unknown fields, and no longer echoes them in
create/update responses; get_media_buys still reads back what assign set.
The 4.0 registry and the task references say where each field lives; the
3.3 release pages are left to #8883. Text that called the purchase,
offer-filter or canonical measurement schemas closed now says what #8866
left: the first two are open but don't define the field, and the
canonical terms are held closed with the commercial terms until 4.0.

Refs #8501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 12, 2026
…rm remains (#8501)

With filters.target_audiences withdrawn from get_products (#8758) and the
package copy withdrawn from create_media_buy and update_media_buy, the
experimental media_buy.audience_evidence_targets has no 3.3 wire form.

- Delete core/audience-evidence-target.json and
  enums/audience-evidence-relationship.json and their index.json entries.
  The stable inline relationship enums on audience evidence stay.
- Drop the feature from the changeset. Its experimental-status row went
  with the previous commit, and the 3.3 release pages are left to #8883.
- Move the target-matching rules from get_products.mdx into the preserved
  4.0 design under purchase_target_audiences_required_in_4_0, keeping a short
  withdrawal notice at the old anchor; the check keeps its id and its
  detection no longer keys off the retired feature id.
- Retire tests/audience-evidence-targets.test.cjs (preserved at d9b5417)
  and stop reading the deleted package-forecast-input.json in
  tests/creative-start-policy.test.cjs.

Refs #8501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — gated paths under static/schemas/source/** with no human/CODEOWNERS approval, plus a breaking-class protocol withdrawal and sensitive-path deletions.

This PR touches the published protocol surface (static/schemas/source/**) which is a hard, deterministic approval gate (gated_paths: true), and the current review_decision is REVIEW_REQUIRED, not APPROVED. Decision-table row 2 therefore forces escalate — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is. The prose hard gate on breaking-class changes applies the same posture.

Escalation reasons

  • static/schemas/source/** is a gated path and review_decision is REVIEW_REQUIRED (not APPROVED) — human/CODEOWNERS review required.
  • Deletes protocol schema files (static/schemas/source/error-details/price-adjustments-mismatch.json, static/schemas/source/media-buy/package-forecast-input.json, static/schemas/source/pricing-options/price-adjustments.json) — deletions in a sensitive path (row 3).
  • Breaking-class protocol withdrawal (price_adjustments / deprecated field removal) — ratification is a human act; never auto-approved unless review_decision is APPROVED.

Net improvement since prior run: The sole prior Medium finding (v4-compatibility.mdx beta.4 vs beta.5 inconsistency) has been resolved — the doc now reads beta.5 consistently with the changeset, registry, and pricing-models. No new findings in the delta. The escalation persists solely on the deterministic gate and the sensitive deletions, not on any unresolved reviewer finding.

Why human review

  • static/schemas/source/** is a gated path and review_decision is REVIEW_REQUIRED (not APPROVED) — human/CODEOWNERS review required
  • Deletes protocol schema files (price-adjustments-mismatch.json, package-forecast-input.json, price-adjustments.json) in static/schemas/source/** — deletion in sensitive path
  • Breaking-class protocol withdrawal — ratification requires human sign-off; never auto-approved unless review_decision is APPROVED
  • This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/core/execution-requirement-readiness.json (modified) matches static/schemas/source/**; static/schemas/source/core/product-execution-readiness.json (modified) matches static/schemas/source/**; static/schemas/source/core/product-execution-requirement.json (modified) matches static/schemas/source/**; static/schemas/source/core/product-filters.json (modified) matches static/schemas/source/**; static/schemas/source/core/product.json (modified) matches static/schemas/source/**; static/schemas/source/core/targeting-overlay-support.json (modified) matches static/schemas/source/**; static/schemas/source/creative/sync-creatives-request.json (modified) matches static/schemas/source/**; static/schemas/source/error-details/price-adjustments-mismatch.json (deleted) matches static/schemas/source/**; static/schemas/source/media-buy/get-products-rejected.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/get-products-request.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/get-products-response.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/list-products-request.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/list-products-response.json (modified) matches static/schemas/source/**; static/schemas/source/media-buy/package-forecast-input.json (deleted) matches static/schemas/source/**; static/schemas/source/media-buy/product-purchase.json (modified) matches static/schemas/source/**; static/schemas/source/pricing-options/cpc-option.json (modified) matches static/schemas/source/**; static/schemas/source/pricing-options/cpcv-option.json (modified) matches static/schemas/source/**; static/schemas/source/pri

…(truncated)…

bokelley and others added 3 commits November 12, 2026 19:05
…ves assignments (#8501)

3.3 adds no field that exists only on a deprecated task. Withdraw from
get_products: refine[].package (and package-forecast-input.json),
refinement_applied[] result_product_id / resolved_start_time /
resolved_end_time, filters.target_audiences, include_collections and
collections, and experimental price_adjustments on pricing options (with
price-adjustments.json, the mismatch error details, and the vectors).
Move include_execution_readiness / execution_readiness to list_products.
Withdraw landing_page_url and trackers from the deprecated sync_creatives
assignments[] row; the assign operation keeps them.

#8866 opened the assignments[] row and the refine[] product entry, so
both now reject the withdrawn request fields by name (not: required),
with a description sentence: the row rejects trackers and
landing_page_url, and every refine[] scope rejects package. The schema
and the training agent's INVALID_REQUEST agree. The response-side
refinement_applied fields are just undefined.

Updates the training agent, the execution readiness storyboard, the v4
registry (canonical_price_adjustments_required_in_4_0), the oneOf
discriminator baseline, docs, and tests. #8866 already removed the
additive-minor baseline rows, and the 3.3 release pages are left to
#8883. counting_mechanisms is left to the create/update_media_buy PR,
which removes it from the shared measurement-terms.json.

Refs #8501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ckages (#8501)

execution_readiness moved to list_products, whose next step is buy_products,
but binding_field examples still taught the legacy create_media_buy paths,
including packages[].catalogs[], which a purchase does not define. Teach
purchases[].optimization_goals[].event_sources[].event_source_id and
purchases[].catalog_ids[] in the spec, list_products docs, the readiness and
requirement schemas, and the readiness fixtures; label the remaining
packages[] paths as legacy. The readiness text no longer claims buy_products
rejects unmet purchases: only create_media_buy's rule is specified, and the
purchase-side rule stays with adcp#7763.

Refs #8501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The canonical_price_adjustments_required_in_4_0 section of the 4.0 page
still said the table shipped in 3.3.0-beta.1 through beta.4 and that the
beta.1 to beta.4 bundles keep the schemas. beta.5 shipped with it too, and
the changeset, the registry entry and pricing-models.mdx already say so.
The section now also says canonical-pricing-option.json is held closed
with the commercial terms until 4.0, matching the registry entry, rather
than "closed in 3.x".

Found by the Ladon review.

Refs #8501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
…ge section

Its last line named a "Withdrawn from the deprecated tasks" section that
#8758 dropped in favor of the migration guide's closed-schema triage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
…ge section

Its last line named a "Withdrawn from the deprecated tasks" section that
#8758 dropped in favor of the migration guide's closed-schema triage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
…ge section

Its last line named a "Withdrawn from the deprecated tasks" section that
#8758 dropped in favor of the migration guide's closed-schema triage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
…ge section

Its last line named a "Withdrawn from the deprecated tasks" section that
#8758 dropped in favor of the migration guide's closed-schema triage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
…ge section

Its last line named a "Withdrawn from the deprecated tasks" section that
#8758 dropped in favor of the migration guide's closed-schema triage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
…ge section

Its last line named a "Withdrawn from the deprecated tasks" section that
#8758 dropped in favor of the migration guide's closed-schema triage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 13, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 14, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 14, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 14, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 14, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 15, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 15, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 16, 2026
#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 16, 2026
… surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Nov 16, 2026
* docs(reference): bring the 3.3 release docs to 3.3.0-rc.0

Bring the release notes, What's new, the 3.2 to 3.3 migration guide, the
prerelease program page, Versions, and the 3.3 rows of Choose your SDK to
the first release candidate. The prerelease page keeps its 3-3-beta URL
and is retitled, as the 3.2 page was at its RC. rc.0 joins the checkpoint
and wire-pin tables with the 3.3-rc documentation selector.

Cover the 2026-11-09 decision to open the schemas that were closed by
accident, and the #8501 triage that followed it: which beta fields stay in
3.3, which leave because they sit on deprecated tasks or would change a
signed term, and which move. The migration guide lists every field; the
other pages summarize it. Record boolean overlay demographics as
deprecated.

Leave the lines that #8866 rewrites alone, and fix the "closed schemas
stay closed" wording it does not touch: the Send-only-to-3.3-peers intro
and proposal-flow correction in the 3.2 to 3.3 guide, the 3.1 to 3.2
guide, optimization reporting, and the daily-budget spec.

Describe deprecated 3.3 features as expected to be removed in 4.0, with
3.3 supported for a window after 4.0 GA, instead of the six-month notice
promise. Record @adcp/sdk 17.0.0-beta.22 and Python adcp 10.0.0b15 on
beta.5, Python adcp 9.6.2 with the A2A input fix on the 3.2 line, no SDK
on rc.0 yet, and no Go or Java support for 3.3.

Content that depends on unmerged PRs or on the rc.0 cut carries a
{/* depends on ... */} marker (HTML comment in the spec markdown) so it
can be re-checked before the cut.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): state the 12-month 3.3 support window after 4.0 GA

Replace "length to be confirmed" in the 3.2 to 3.3 Deprecations intro
with the decided window: 3.3 stays supported for at least 12 months after
4.0 GA. Point the marker at #8858, which carries the policy change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): describe the commercial terms as held closed until 4.0

Konstantin's review of #8866 rejects signed commercial terms as a
structural reason to keep a schema closed: terms_digest covers open
members at every depth, including ext. Describe the nodes inside
commercial_terms, and proposal-budget-constraint, as held closed until
4.0 in the triage tables and summaries, the release notes, What's new,
Versions, and the daily-budget spec, and drop the claim that the digest
stops a 3.2 buyer from accepting a term it ignored. The triage reason is
renamed from signed meaning to held closed until 4.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): prerelease pins, unpinned discovery, and anonymous capabilities

A 3.3 beta reader pinned get_adcp_capabilities to 3.3-beta.5 against a
3.0-only seller, got VERSION_UNSUPPORTED, and never retried. State how
each side avoids that (approved by Brian for the 3.3 RC docs):

- Versioning, pre-release pins: a buyer MUST send a prerelease
  adcp_version only to a peer whose supported_versions lists that exact
  value, SHOULD discover unpinned, and SHOULD retry unpinned or at a
  listed version on VERSION_UNSUPPORTED, matching the existing retry
  SHOULD and the error code's recovery hint. Mirrored on the 3.3
  prerelease page.
- Authentication: a seller SHOULD serve get_adcp_capabilities without
  credentials; a SHOULD in 3.3 and a MUST in 4.0.
- MCP guide: a gateway that allow-lists JSON-RPC methods SHOULD let
  server/discover, initialize, and tools/list through without
  credentials.
- Release docs: a migration-guide section with buyer and seller
  checklist rows, a What's new and release-notes bullet, and the 4.0
  item in v4-compatibility's not-yet-checked list.

Docs only; no schema changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): follow #8866 and the other rc.0 merges in the 3.3 release docs

After rebasing onto main with #8866 merged:

- Take #8866's wording for the boolean form of demographics in the
  migration guide's Deprecations section, and align the release notes and
  What's new with it (#8778 tracks the 4.0 removal).
- 3.2.10 shipped without the schema opening, so say "the next 3.2.x patch
  (#8864)" and "3.2.10 and earlier", including in #8866's
  Schemas-are-open-by-default bullet.
- Drop the dependency markers #8866 satisfied, and retarget the rest.
- Cover the other changes merged for rc.0: origin-only authorized_agents
  URLs (#8939), declared-option creative conformance (#8941), TMP cache
  isolation (#7446), creative.supports_registry_policy_enforcement
  (#8857), 3gp/mpeg/m4v containers (#8668), carousel card_image_sizes
  (#8937), and the loosened URL patterns (#8792).
- Refresh the in-review table against the 3.3.0 milestone on 2026-11-12,
  and remove the stray duplicate table header it carried.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(sdk): keep the SDK matrix on the installed @adcp/sdk prerelease

tests/sdk-runtime-compat.test.cjs requires Choose your SDK to name the
@adcp/sdk prerelease this repository installs (17.0.0-beta.21), and no
other 17.0.0 prerelease. Revert the TypeScript row and install command to
beta.21 and drop the npm beta dist-tag label, which now points at beta.22.
The release pages keep recording that beta.22 also bundles beta.5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8858 and #8864 markers in the 3.3 release docs

- #8858 merged: drop its markers on the 3.3 support window and the
  daily-budget spec.
- #8864 merged into 3.2.x, so the schema opening ships in 3.2.11: say
  "3.2.11 (#8864)" instead of "the next 3.2.x patch", with one marker per
  page on the 3.2.11 release itself (Version Packages #8942).
- target_audiences on list_products offer_filters is decided: it stays as
  it is in 3.3, and any change is 4.x, so media_buy.audience_evidence_targets
  has no 3.3 surface once the get_products and create_media_buy copies leave.
- The available_installment_statuses move is a 3.3 RC item; its markers
  now point at c4777ebd's PR, and the release-notes installment_lifecycle
  row carries a marker to move to the canonical location when it lands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): point the available_installment_statuses markers at #8957

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8762 and #8957 markers in the 3.3 release docs

#8762 (sla-window back to its 3.2 shape, business time on the creative
review SLA) and #8957 (available_installment_statuses on the canonical
reporting capabilities) merged; #8762's own release-doc lines arrive with
the rebase. Drop both from the dependency markers, name the canonical
product's reporting_capabilities in the release-notes
media_buy.installment_lifecycle row, and refresh the #8501 row of the
in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8758 markers in the 3.3 release docs

#8758 merged: the get_products and sync_creatives assignments[]
withdrawals and the execution_readiness move to list_products are in
main. Drop it from the dependency markers, remove the #7659 note's
marker, move it to merged in the in-review table, and say that the
deprecated assignments[] row rejects trackers and landing_page_url by
name, so a stale sender is rejected there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8767 markers and describe the withdrawn surfaces

#8758 and #8767 merged and handed their release-doc text to #8883. Drop
#8767 from the dependency markers, and bring the lines that still
described withdrawn surfaces as current in line with main:

- media_buy.price_adjustments and media_buy.audience_evidence_targets are
  withdrawn at rc.0 and no longer registered (experimental table, feature
  index, What's new, migration guide).
- execution_readiness is on list_products; lineage is on buy_products and
  accept_proposal; collection cards leave get_products; the creative start
  gate is set through control_media_buy; counting_mechanisms leaves
  measurement_terms; assignment trackers and landing pages stay only on
  sync_creatives assign operations.
- Point the price-adjustment and target-audience links at the withdrawn
  sections; refresh the #8501 row of the in-review table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): add the rc.0 installment experiments, with dependency markers

Two experimental, capability-gated rc.0 items are in progress: installment
selection through refine_proposals (media_buy.installment_refinement,
(media_buy.installment_creative_assignment, #8968). Add them to the
feature index, the experimental surfaces table, What's new, and the
migration guide, each behind a marker until its PR merges. Note on every
"installment selection withdrawn to 4.0" passage that 3.3 now covers the
request side, while the signed purchases[].installments[] stays a 4.0
item.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): cover #8884's signed-terms acceptance rule in the rc.0 docs

#8884 states that accepting signed commercial terms binds every member
terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms
decline reason. Add it to the rc.0 checkpoint and feature index, the
behavior changes, What's new, and the migration guide (a required-behavior
section, checklist row 52, and its storyboard).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): describe #8972, per-installment creative assignment, in the rc.0 docs

#8968's PR is #8972: installment_refs on sync_creatives assign and replace
operations, read back on get_media_buys and list_creatives, rejected by
name on unassign and merge, VALIDATION_ERROR for a ref outside the bought
installments and CREATIVE_DEADLINE_EXCEEDED past change_cutoff. Correct
the RFC-based placeholder and point its markers at #8972.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): describe #8974, installment refinement, in the rc.0 docs

refine_proposals, unsatisfied_installment_changes with a reason, the
installment_changes value in proposal_refinement.supported_dimensions, and
a seller answer that buys a product whose installments are the chosen set.
Correct the RFC-based placeholder, link the new anchors, and point its
markers at #8974. Drop the sentence in the 4.0 page's What stays in 3.3,
which #8974 rewrites itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): cover #8793 and #8458 in the rc.0 docs

#8793: Reliable Reporting managed delivery holds no buyer secret, row push
is reporting_webhook, and the experimental https_put file_transfer
transport. #8458: media_buy.supported_delivery_types. Add both to the rc.0
checkpoint and feature index, the behavior changes and the
reporting_delivery experimental row, What's new, and the migration guide
(an experimental notice and checklist rows 53 and 54), and mark #8149 as
shipped in the in-review table. #8458's own optional-declaration lines
are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the 3.2.11 markers

3.2.11 published on 2026-11-13 with the 3.2 schema opening (#8864), so
the release pages' 3.2.11 statements no longer wait on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8974 markers

#8974 merged as a7af517. Drop its markers, and narrow the shared
installment markers to #8972. The migration guide no longer says
core/installment-change-set.json and the installment_changes dimension
are gone: they leave after beta.1 and return in rc.0 under
media_buy.installment_refinement.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): describe #8983, report definitions at contract_version 1.2, in the rc.0 docs

#8983 (#8971) adds Reliable Reporting report-definition contract_version
1.2: a definition whose dimensions include media_buy_id must include
package_id, account-level definitions are exempt, and callers pinned below
3.3 get 1.0 or 1.1 offerings. Add it to the release notes (checkpoint
row, feature index, behavior change, experimental table), What's new, and
the migration guide (checklist row 55 and a section), with markers until
it merges. The checkpoint row also gains #8974 and #8972, which it was
missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8972 markers

#8972 merged as e903ee6. Drop its markers and narrow the shared ones
to #8983. The migration guide adds #8972's capability rule: buyers send
installment_refs only to a seller that lists the feature id, and a seller
without it rejects the field with UNSUPPORTED_FEATURE.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8983 markers

#8983 merged as 39334ab. Drop its seven markers, and state the
serving rule as a MUST everywhere it appears: a seller serves callers
pinned below 3.3 only 1.0 or 1.1 report-definition offerings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): add 3.3.0-beta.6 ahead of rc.0

beta.6 is cut on main today for SDK testing over the weekend, and rc.0
stays on Monday. Add beta.6 to the checkpoint, SDK-posture and
version-string tables and to Versions, say rc.0 follows seven betas,
and note that everything in "New in rc.0" first shipped in beta.6 except
the prerelease-pin and anonymous-discovery guidance. beta.6's date
carries a marker until it publishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): describe #8966, display labels for geo targeting codes, in the beta.6 and rc.0 docs

#8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6
checkpoint row and the beta.6 and rc.0 feature index, to What's new
(smaller additions), and to the migration guide: checklist row 56, a
send-only-to-3.3-peers row for geo_value_labels, and a section under
Adopt by capability. Labels never resolve or apply targeting, sellers
never reject a request because they are present, and equality and
readback compare codes only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the beta.6 date markers

3.3.0-beta.6 published on 2026-11-13 (tag v3.3.0-beta.6 at bf4aa6d,
from Version Packages #8801). The pages already give that date, so drop
the four markers that held it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): describe #8995, social distribution identifier types, in the rc.0 docs

#8995 (#8992) adds eight distribution-identifier-type values for
Instagram, Facebook, Snapchat and X: a canonical ID and a handle alias
for each, with handles compared as @ plus the lowercased name. It lands
after beta.6, so add it to the rc.0 checkpoint rows, the feature index,
What's new, and the migration guide's send-only enum values, with
markers until it merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the #8995 markers and fold #8997 into the rc.0 docs

#8995 merged as 15b0c46, identical to the version these pages
describe, so its seven markers go.

#8997 (declared sync_creatives assignment operations) merged after
beta.6 with its own release-doc lines. The rebase kept this branch's
side of the overlapping hunks, so restore #8997's text: its migration
checklist row (now row 57, after this PR's rows 45 to 56), the
release-notes Creative bullet, and the What's new adopter rows. Its
migration and What's new sections and its behavior-change bullet came
through unchanged. As post-beta.6 content, it joins the rc.0 rows and
the "new in rc.0" notes.

#8986 (training agent refuses installment_refs) is server-only with no
changeset, so the rc.0 rows don't list it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): add #8970 and the other post-beta.6 merges to the rc.0 docs

#8970 (merged as 145ba50) asks get_media_buy_delivery sellers to
return at least one by_package row, one per package, and to omit a buy
they can't report rather than return an empty by_package. by_package: []
stays valid in 3.x, and minItems: 1 is proposed for 4.0 in #8973. Add a
behavior-change bullet, a What's new sentence, migration checklist row
58, and #8973 under v4-compatibility "Changes not checked yet".

#8996, #9001 and #8934 also merged after beta.6. #8996 and #9001 wrote
their own release-doc text, which came through the rebase unchanged.
Add all four to the rc.0 rows and the "new in rc.0" notes, and split
the release-notes feature index into a beta.6 bullet and an rc.0
bullet. Refresh the in-review table to 2026-11-14: #8149, #8107 and
#8856 (merged as #8934) closed, #8943 has #9011, and #9014 and #8998
(#9013) are new.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): write #8854 up as in review, not in rc.0

#8854 (withdraw metric_id, restore evaluator as a deprecated x-entity
value; #8501 entries 6 and 26) has not merged by Sunday 2026-11-15, with
changes requested. Per the Sunday rule, describe it as in review and not
in rc.0, and drop its eight markers. rc.0's schemas still carry metric_id
on the canonical and legacy performance standards and on
required_performance_standards, and still lack evaluator. The triage
decision stands, so metric_id stays listed as leaving 3.3, with a note
that the withdrawal is in review, and evaluator leaves the "stays in
3.3" lists. signing_profile is no longer part of #8854 and stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): take #9018's beta.6 SDKs and test-agent preview, and add #9011 and #9017

#9018 (6c34d90) bumped @adcp/sdk to 17.0.0-beta.26 and moved the
public test agent's preview to 3.3-beta.6. The rebase kept this
branch's side of the overlapping lines, so apply its facts here:
17.0.0-beta.21 to beta.23 and Python adcp 10.0.0b13 to 10.0.0b16
support beta.5, 17.0.0-beta.24 and later and 10.0.0b17 and later
support beta.6, Choose your SDK names beta.26 and 10.0.0b17, the test
agent serves 3.3-beta.6, and SDK-backed testing stays on beta.6 until
an SDK bundles rc.0.

#9011 and #9017 merged after beta.6 with their migration-guide text.
When several authorized_agents entries match one agent, its scope is
the union, and a signing_keys pin holds only if every matching entry
pins. Add them to the rc.0 rows, the rc.0 feature index and What's new.
The in-review table moves to 2026-11-15: #8943 and #9016 closed, and
#9013 is out of draft.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): fold #8989, #9007 and the last post-beta.6 changesets into the rc.0 docs

#8989 renames three experimental values to their counterparts'
spelling, with no alias: input_required to input-required
(execution_readiness), click_through to clickthrough (live_updates),
underdelivery to under_delivery (delivery_projection). Add a migration
section with the old and new spellings, checklist row 59, a release-
notes behavior change, a What's new bullet, and a "Renamed in rc.0" row
on the prerelease page, and fix the two input_required spellings that
the rebase kept from this branch.

#9007 lets campaign governance accept a sync_plans plan that omits
human_review_required, and states two sync_plans rules: checklist row
60, a release-notes bullet, and a What's new sentence.

Every changeset pending for rc.0 is now in the rc.0 rows and notes,
including the compliance gates #9013 and #9005 and #9018's beta.6
test-agent preview. Choose your SDK takes main's @adcp/sdk
17.0.0-beta.28. The in-review table moves to 2026-11-16: #8998 closed
(#9013), and #8987 is new.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(reference): resolve the rc.0-cut markers

rc.0 is cut today, 2026-11-16, and the pages already give that date, so
drop the five date markers. Write the three post-cut markers forward:
SDK prereleases that adopt 3.3.0-rc.0 follow within days of the cut,
Choose your SDK gains their rows when they publish, and the test-agent
preview moves to rc.0 once an @adcp/sdk prerelease negotiates it. A
follow-up PR on main adds the real versions after rc.0 publishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ladon/needs-human-review Ladon has escalated this PR for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant