Repository navigation
Conversation
terms_digest is SHA-256 over the JCS bytes of the whole commercial_terms value, and many schemas reachable from commercial-terms.json are already open, so members a party does not recognize can sit inside the signed bytes. The spec never said what accepting such terms means. State the rule in commercial-terms.json, the terms_digest description, check-governance-request.json, and the docs that specify the digest and acceptance: - The digest covers the entire commercial_terms JSON value, every member at every depth, including ext and unrecognized members. - Accepting the terms binds the accepting party to every member. A party that cannot interpret every member must not accept them: a buyer declines with the new decline reason unrecognized_terms, a seller rejects the request with the new error code UNRECOGNIZED_TERMS, and a governance agent denies the check. A member whose schema defines it as opaque, such as context, is interpreted by that definition. - A party computes or verifies the digest over the JSON value as received, never over a re-serialized parsed model. Correct the release notes, What's new in 3.3, and both migration guides, which gave "terms_digest signs exactly those terms" as a reason to keep commercial-terms closed. It stays closed because a minor release never changes a closed schema. Add the media_buy_seller/unrecognized_terms_rejected storyboard: a buy_products purchase carries an undefined member in format_option_refs[0], an open schema, and must fail with UNRECOGNIZED_TERMS; the same purchase without it must succeed. The training agent recorded the member inside the accepted commercial_terms; it now rejects any purchase member the source schemas do not declare.
Spell the decline reason UNRECOGNIZED_TERMS, like the error code. It names the same condition from the buyer's side, and its description now says so. Split the storyboard so the control purchase runs in its own phase before the rejection, and make the rejection phase depend on it. The UNRECOGNIZED_TERMS check is graded only after the identical purchase is proven acceptable; if the control fails, the runner skips the check. Replace the undefined member with adcp_compliance_undefined_member, a name reserved as undefined so that no conformant seller can legitimately interpret it.
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated schema paths require human/CODEOWNERS approval.
This PR modifies five files under static/schemas/source/**, which fall under the repo's hard, path-based approval gate (gated_paths: true). The current review_decision is REVIEW_REQUIRED, not APPROVED, so the gate is not satisfied (decision table row 2).
Gated files requiring review:
- static/schemas/source/core/canonical-proposal.json
- static/schemas/source/enums/error-code.json
- static/schemas/source/enums/proposal-decline-reason.json
- static/schemas/source/governance/check-governance-request.json
- static/schemas/source/media-buy/commercial-terms.json
The reviewer found the change clean: additive Normative surface (new UNRECOGNIZED_TERMS error code + decline_proposals reason, acceptance rule in commercial-terms.json/terms_digest/check-governance-request.json), schema↔docs coherent across all nine edited pages, a minor changeset matching the additive enum/requirement surface, no oneOf regression, and no released-artifact mutation. No blocking or medium findings. The uppercase UNRECOGNIZED_TERMS casing is acknowledged and deferred to #8885 — not a finding.
Despite the clean diff, the gated-paths hard rule forbids auto-approve until a human/CODEOWNERS approval lands. Once review_decision becomes APPROVED, this PR falls through to the normal table and can approve on its clean findings.
Why human review
- Touches gated schema paths under static/schemas/source/** (canonical-proposal.json, error-code.json, proposal-decline-reason.json, check-governance-request.json, commercial-terms.json) and review_decision is REVIEW_REQUIRED, not APPROVED — human/CODEOWNERS review required before merge.
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/core/canonical-proposal.json (modified) matches
static/schemas/source/**; static/schemas/source/enums/error-code.json (modified) matchesstatic/schemas/source/**; static/schemas/source/enums/proposal-decline-reason.json (modified) matchesstatic/schemas/source/**; static/schemas/source/governance/check-governance-request.json (modified) matchesstatic/schemas/source/**; static/schemas/source/media-buy/commercial-terms.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
bokelley
left a comment
There was a problem hiding this comment.
Thanks Konstantin. This is the rule that makes open schemas inside signed terms safe, and I want it in the 3.3 RC. I'm approving the rule as written:
- the digest covers every member at every depth, including
ext; - accepting binds you to all of them;
- a party that can't interpret a member refuses;
- the digest is computed over the value as received.
I'm also happy with the correctable classification and the storyboard.
One change before merge: please make the decline reason lowercase, unrecognized_terms, in enums/proposal-decline-reason.json. Every other value in that enum is lowercase snake_case, and the enum is closed. An uppercase value would stay inconsistent through all of 3.x, which #8885 can only fix in 4.0. Keep UNRECOGNIZED_TERMS as the error code in enums/error-code.json, matching the other error codes.
It's still one condition seen from either side, so keep the cross-references. Each vocabulary just keeps its own casing, e.g. "a buyer declines with reason unrecognized_terms; a seller reports error code UNRECOGNIZED_TERMS". The decline-reason spelling also appears in:
- the
commercial-terms.jsonandcanonical-proposal.jsondescriptions; check-governance-request.json, if it names the reason;- the decline-reason
enumDescriptionsentry; - the proposal-negotiation,
decline_proposals,pricing-modelsand migration/release docs; - the changeset.
Ordering with #8866: whichever of the two lands first, the other rebases. #8866 is taking your review now. It drops the "signed commercial terms" structural reason in favour of "held closed until 4.0", so the three docs pages should end up saying the same thing as this PR.
… enum proposal-decline-reason is a closed lowercase snake_case enum, so the decline reason is unrecognized_terms. The error code stays UNRECOGNIZED_TERMS, like the other error codes. Text that names both keeps the cross-reference with each vocabulary's own casing.
The decline_proposals check and the compact refine-decline check each kept a hand-written list of decline reasons, and neither had unrecognized_terms. Both now read one set from enums/proposal-decline-reason.json, so the agent accepts exactly the reasons the schema allows.
Keeps main's "held closed until 4.0" wording from adcontextprotocol#8866 in the four release docs and adds this PR's acceptance rule after it.
After the merge of main, the release notes, What's new in 3.3 and the 3.2 to 3.3 migration guide keep the note that commercial-terms is held closed until 4.0 and state the acceptance rule after it. The changeset no longer gives the reason main already replaced.
|
Thanks, Brian. It's pushed, head
|
bokelley
left a comment
There was a problem hiding this comment.
Re-approving on c734281. The condition from my earlier approval is met: unrecognized_terms is lowercase in enums/proposal-decline-reason.json, and the training agent accepts it. Since then the only changes are the merge of main and the changeset wording.
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(reference): bring the 3.3 release docs to 3.3.0-rc.0 Bring the release notes, What's new, the 3.2 to 3.3 migration guide, the prerelease program page, Versions, and the 3.3 rows of Choose your SDK to the first release candidate. The prerelease page keeps its 3-3-beta URL and is retitled, as the 3.2 page was at its RC. rc.0 joins the checkpoint and wire-pin tables with the 3.3-rc documentation selector. Cover the 2026-11-09 decision to open the schemas that were closed by accident, and the #8501 triage that followed it: which beta fields stay in 3.3, which leave because they sit on deprecated tasks or would change a signed term, and which move. The migration guide lists every field; the other pages summarize it. Record boolean overlay demographics as deprecated. Leave the lines that #8866 rewrites alone, and fix the "closed schemas stay closed" wording it does not touch: the Send-only-to-3.3-peers intro and proposal-flow correction in the 3.2 to 3.3 guide, the 3.1 to 3.2 guide, optimization reporting, and the daily-budget spec. Describe deprecated 3.3 features as expected to be removed in 4.0, with 3.3 supported for a window after 4.0 GA, instead of the six-month notice promise. Record @adcp/sdk 17.0.0-beta.22 and Python adcp 10.0.0b15 on beta.5, Python adcp 9.6.2 with the A2A input fix on the 3.2 line, no SDK on rc.0 yet, and no Go or Java support for 3.3. Content that depends on unmerged PRs or on the rc.0 cut carries a {/* depends on ... */} marker (HTML comment in the spec markdown) so it can be re-checked before the cut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): state the 12-month 3.3 support window after 4.0 GA Replace "length to be confirmed" in the 3.2 to 3.3 Deprecations intro with the decided window: 3.3 stays supported for at least 12 months after 4.0 GA. Point the marker at #8858, which carries the policy change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe the commercial terms as held closed until 4.0 Konstantin's review of #8866 rejects signed commercial terms as a structural reason to keep a schema closed: terms_digest covers open members at every depth, including ext. Describe the nodes inside commercial_terms, and proposal-budget-constraint, as held closed until 4.0 in the triage tables and summaries, the release notes, What's new, Versions, and the daily-budget spec, and drop the claim that the digest stops a 3.2 buyer from accepting a term it ignored. The triage reason is renamed from signed meaning to held closed until 4.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): prerelease pins, unpinned discovery, and anonymous capabilities A 3.3 beta reader pinned get_adcp_capabilities to 3.3-beta.5 against a 3.0-only seller, got VERSION_UNSUPPORTED, and never retried. State how each side avoids that (approved by Brian for the 3.3 RC docs): - Versioning, pre-release pins: a buyer MUST send a prerelease adcp_version only to a peer whose supported_versions lists that exact value, SHOULD discover unpinned, and SHOULD retry unpinned or at a listed version on VERSION_UNSUPPORTED, matching the existing retry SHOULD and the error code's recovery hint. Mirrored on the 3.3 prerelease page. - Authentication: a seller SHOULD serve get_adcp_capabilities without credentials; a SHOULD in 3.3 and a MUST in 4.0. - MCP guide: a gateway that allow-lists JSON-RPC methods SHOULD let server/discover, initialize, and tools/list through without credentials. - Release docs: a migration-guide section with buyer and seller checklist rows, a What's new and release-notes bullet, and the 4.0 item in v4-compatibility's not-yet-checked list. Docs only; no schema changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): follow #8866 and the other rc.0 merges in the 3.3 release docs After rebasing onto main with #8866 merged: - Take #8866's wording for the boolean form of demographics in the migration guide's Deprecations section, and align the release notes and What's new with it (#8778 tracks the 4.0 removal). - 3.2.10 shipped without the schema opening, so say "the next 3.2.x patch (#8864)" and "3.2.10 and earlier", including in #8866's Schemas-are-open-by-default bullet. - Drop the dependency markers #8866 satisfied, and retarget the rest. - Cover the other changes merged for rc.0: origin-only authorized_agents URLs (#8939), declared-option creative conformance (#8941), TMP cache isolation (#7446), creative.supports_registry_policy_enforcement (#8857), 3gp/mpeg/m4v containers (#8668), carousel card_image_sizes (#8937), and the loosened URL patterns (#8792). - Refresh the in-review table against the 3.3.0 milestone on 2026-11-12, and remove the stray duplicate table header it carried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(sdk): keep the SDK matrix on the installed @adcp/sdk prerelease tests/sdk-runtime-compat.test.cjs requires Choose your SDK to name the @adcp/sdk prerelease this repository installs (17.0.0-beta.21), and no other 17.0.0 prerelease. Revert the TypeScript row and install command to beta.21 and drop the npm beta dist-tag label, which now points at beta.22. The release pages keep recording that beta.22 also bundles beta.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8858 and #8864 markers in the 3.3 release docs - #8858 merged: drop its markers on the 3.3 support window and the daily-budget spec. - #8864 merged into 3.2.x, so the schema opening ships in 3.2.11: say "3.2.11 (#8864)" instead of "the next 3.2.x patch", with one marker per page on the 3.2.11 release itself (Version Packages #8942). - target_audiences on list_products offer_filters is decided: it stays as it is in 3.3, and any change is 4.x, so media_buy.audience_evidence_targets has no 3.3 surface once the get_products and create_media_buy copies leave. - The available_installment_statuses move is a 3.3 RC item; its markers now point at c4777ebd's PR, and the release-notes installment_lifecycle row carries a marker to move to the canonical location when it lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): point the available_installment_statuses markers at #8957 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8762 and #8957 markers in the 3.3 release docs #8762 (sla-window back to its 3.2 shape, business time on the creative review SLA) and #8957 (available_installment_statuses on the canonical reporting capabilities) merged; #8762's own release-doc lines arrive with the rebase. Drop both from the dependency markers, name the canonical product's reporting_capabilities in the release-notes media_buy.installment_lifecycle row, and refresh the #8501 row of the in-review table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8758 markers in the 3.3 release docs #8758 merged: the get_products and sync_creatives assignments[] withdrawals and the execution_readiness move to list_products are in main. Drop it from the dependency markers, remove the #7659 note's marker, move it to merged in the in-review table, and say that the deprecated assignments[] row rejects trackers and landing_page_url by name, so a stale sender is rejected there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8767 markers and describe the withdrawn surfaces #8758 and #8767 merged and handed their release-doc text to #8883. Drop #8767 from the dependency markers, and bring the lines that still described withdrawn surfaces as current in line with main: - media_buy.price_adjustments and media_buy.audience_evidence_targets are withdrawn at rc.0 and no longer registered (experimental table, feature index, What's new, migration guide). - execution_readiness is on list_products; lineage is on buy_products and accept_proposal; collection cards leave get_products; the creative start gate is set through control_media_buy; counting_mechanisms leaves measurement_terms; assignment trackers and landing pages stay only on sync_creatives assign operations. - Point the price-adjustment and target-audience links at the withdrawn sections; refresh the #8501 row of the in-review table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): add the rc.0 installment experiments, with dependency markers Two experimental, capability-gated rc.0 items are in progress: installment selection through refine_proposals (media_buy.installment_refinement, (media_buy.installment_creative_assignment, #8968). Add them to the feature index, the experimental surfaces table, What's new, and the migration guide, each behind a marker until its PR merges. Note on every "installment selection withdrawn to 4.0" passage that 3.3 now covers the request side, while the signed purchases[].installments[] stays a 4.0 item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): cover #8884's signed-terms acceptance rule in the rc.0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8972, per-installment creative assignment, in the rc.0 docs #8968's PR is #8972: installment_refs on sync_creatives assign and replace operations, read back on get_media_buys and list_creatives, rejected by name on unassign and merge, VALIDATION_ERROR for a ref outside the bought installments and CREATIVE_DEADLINE_EXCEEDED past change_cutoff. Correct the RFC-based placeholder and point its markers at #8972. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8974, installment refinement, in the rc.0 docs refine_proposals, unsatisfied_installment_changes with a reason, the installment_changes value in proposal_refinement.supported_dimensions, and a seller answer that buys a product whose installments are the chosen set. Correct the RFC-based placeholder, link the new anchors, and point its markers at #8974. Drop the sentence in the 4.0 page's What stays in 3.3, which #8974 rewrites itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): cover #8793 and #8458 in the rc.0 docs #8793: Reliable Reporting managed delivery holds no buyer secret, row push is reporting_webhook, and the experimental https_put file_transfer transport. #8458: media_buy.supported_delivery_types. Add both to the rc.0 checkpoint and feature index, the behavior changes and the reporting_delivery experimental row, What's new, and the migration guide (an experimental notice and checklist rows 53 and 54), and mark #8149 as shipped in the in-review table. #8458's own optional-declaration lines are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the 3.2.11 markers 3.2.11 published on 2026-11-13 with the 3.2 schema opening (#8864), so the release pages' 3.2.11 statements no longer wait on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8974 markers #8974 merged as a7af517. Drop its markers, and narrow the shared installment markers to #8972. The migration guide no longer says core/installment-change-set.json and the installment_changes dimension are gone: they leave after beta.1 and return in rc.0 under media_buy.installment_refinement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8983, report definitions at contract_version 1.2, in the rc.0 docs #8983 (#8971) adds Reliable Reporting report-definition contract_version 1.2: a definition whose dimensions include media_buy_id must include package_id, account-level definitions are exempt, and callers pinned below 3.3 get 1.0 or 1.1 offerings. Add it to the release notes (checkpoint row, feature index, behavior change, experimental table), What's new, and the migration guide (checklist row 55 and a section), with markers until it merges. The checkpoint row also gains #8974 and #8972, which it was missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8972 markers #8972 merged as e903ee6. Drop its markers and narrow the shared ones to #8983. The migration guide adds #8972's capability rule: buyers send installment_refs only to a seller that lists the feature id, and a seller without it rejects the field with UNSUPPORTED_FEATURE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8983 markers #8983 merged as 39334ab. Drop its seven markers, and state the serving rule as a MUST everywhere it appears: a seller serves callers pinned below 3.3 only 1.0 or 1.1 report-definition offerings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): add 3.3.0-beta.6 ahead of rc.0 beta.6 is cut on main today for SDK testing over the weekend, and rc.0 stays on Monday. Add beta.6 to the checkpoint, SDK-posture and version-string tables and to Versions, say rc.0 follows seven betas, and note that everything in "New in rc.0" first shipped in beta.6 except the prerelease-pin and anonymous-discovery guidance. beta.6's date carries a marker until it publishes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8966, display labels for geo targeting codes, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the beta.6 date markers 3.3.0-beta.6 published on 2026-11-13 (tag v3.3.0-beta.6 at bf4aa6d, from Version Packages #8801). The pages already give that date, so drop the four markers that held it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8995, social distribution identifier types, in the rc.0 docs #8995 (#8992) adds eight distribution-identifier-type values for Instagram, Facebook, Snapchat and X: a canonical ID and a handle alias for each, with handles compared as @ plus the lowercased name. It lands after beta.6, so add it to the rc.0 checkpoint rows, the feature index, What's new, and the migration guide's send-only enum values, with markers until it merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8995 markers and fold #8997 into the rc.0 docs #8995 merged as 15b0c46, identical to the version these pages describe, so its seven markers go. #8997 (declared sync_creatives assignment operations) merged after beta.6 with its own release-doc lines. The rebase kept this branch's side of the overlapping hunks, so restore #8997's text: its migration checklist row (now row 57, after this PR's rows 45 to 56), the release-notes Creative bullet, and the What's new adopter rows. Its migration and What's new sections and its behavior-change bullet came through unchanged. As post-beta.6 content, it joins the rc.0 rows and the "new in rc.0" notes. #8986 (training agent refuses installment_refs) is server-only with no changeset, so the rc.0 rows don't list it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): add #8970 and the other post-beta.6 merges to the rc.0 docs #8970 (merged as 145ba50) asks get_media_buy_delivery sellers to return at least one by_package row, one per package, and to omit a buy they can't report rather than return an empty by_package. by_package: [] stays valid in 3.x, and minItems: 1 is proposed for 4.0 in #8973. Add a behavior-change bullet, a What's new sentence, migration checklist row 58, and #8973 under v4-compatibility "Changes not checked yet". #8996, #9001 and #8934 also merged after beta.6. #8996 and #9001 wrote their own release-doc text, which came through the rebase unchanged. Add all four to the rc.0 rows and the "new in rc.0" notes, and split the release-notes feature index into a beta.6 bullet and an rc.0 bullet. Refresh the in-review table to 2026-11-14: #8149, #8107 and #8856 (merged as #8934) closed, #8943 has #9011, and #9014 and #8998 (#9013) are new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): write #8854 up as in review, not in rc.0 #8854 (withdraw metric_id, restore evaluator as a deprecated x-entity value; #8501 entries 6 and 26) has not merged by Sunday 2026-11-15, with changes requested. Per the Sunday rule, describe it as in review and not in rc.0, and drop its eight markers. rc.0's schemas still carry metric_id on the canonical and legacy performance standards and on required_performance_standards, and still lack evaluator. The triage decision stands, so metric_id stays listed as leaving 3.3, with a note that the withdrawal is in review, and evaluator leaves the "stays in 3.3" lists. signing_profile is no longer part of #8854 and stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): take #9018's beta.6 SDKs and test-agent preview, and add #9011 and #9017 #9018 (6c34d90) bumped @adcp/sdk to 17.0.0-beta.26 and moved the public test agent's preview to 3.3-beta.6. The rebase kept this branch's side of the overlapping lines, so apply its facts here: 17.0.0-beta.21 to beta.23 and Python adcp 10.0.0b13 to 10.0.0b16 support beta.5, 17.0.0-beta.24 and later and 10.0.0b17 and later support beta.6, Choose your SDK names beta.26 and 10.0.0b17, the test agent serves 3.3-beta.6, and SDK-backed testing stays on beta.6 until an SDK bundles rc.0. #9011 and #9017 merged after beta.6 with their migration-guide text. When several authorized_agents entries match one agent, its scope is the union, and a signing_keys pin holds only if every matching entry pins. Add them to the rc.0 rows, the rc.0 feature index and What's new. The in-review table moves to 2026-11-15: #8943 and #9016 closed, and #9013 is out of draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): fold #8989, #9007 and the last post-beta.6 changesets into the rc.0 docs #8989 renames three experimental values to their counterparts' spelling, with no alias: input_required to input-required (execution_readiness), click_through to clickthrough (live_updates), underdelivery to under_delivery (delivery_projection). Add a migration section with the old and new spellings, checklist row 59, a release- notes behavior change, a What's new bullet, and a "Renamed in rc.0" row on the prerelease page, and fix the two input_required spellings that the rebase kept from this branch. #9007 lets campaign governance accept a sync_plans plan that omits human_review_required, and states two sync_plans rules: checklist row 60, a release-notes bullet, and a What's new sentence. Every changeset pending for rc.0 is now in the rc.0 rows and notes, including the compliance gates #9013 and #9005 and #9018's beta.6 test-agent preview. Choose your SDK takes main's @adcp/sdk 17.0.0-beta.28. The in-review table moves to 2026-11-16: #8998 closed (#9013), and #8987 is new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the rc.0-cut markers rc.0 is cut today, 2026-11-16, and the pages already give that date, so drop the five date markers. Write the three post-cut markers forward: SDK prereleases that adopt 3.3.0-rc.0 follow within days of the cut, Choose your SDK gains their rows when they publish, and the test-agent preview moves to rc.0 once an @adcp/sdk prerelease negotiates it. A follow-up PR on main adds the real versions after rc.0 publishes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
terms_digestis SHA-256 over the RFC 8785 JCS bytes of the wholecommercial_termsvalue. On main, many of the 92 schemas reachable frommedia-buy/commercial-terms.jsonhave open nodes (core/targeting.json,core/format-option-ref.json,core/ext.json, and others), so members a party doesn't recognize can already sit inside the signed bytes. The spec doesn't say what accepting those terms means for such members. This PR states it:commercial_termsJSON value: every member at every depth, includingextand members the party doesn't recognize.decline_proposalsreasonunrecognized_terms, a seller rejects the request withUNRECOGNIZED_TERMS, and a governance agent denies through its existing deny path. A member whose schema defines it as opaque, such ascontext, is interpreted by that definition.Changes
enums/error-code.json: newUNRECOGNIZED_TERMS, with description andenumMetadata. I classified itcorrectable: the buyer can remove the member, or send it only to a seller that interprets it, and retry. Nothing about it needs operator intervention, soterminaldidn't fit. It is distinct fromUNSUPPORTED_FEATURE(a field the seller recognizes but doesn't support) andINVALID_REQUEST(a schema failure).scripts/error-code-drift-dispositions.jsonholds it for 3.3, anddocs/snippets/compliance-error-codes.mdxis regenerated.enums/proposal-decline-reason.json: newunrecognized_terms, lowercase like the rest of the enum. It is the same condition a seller reports as error codeUNRECOGNIZED_TERMS, and the decline-reason description names that code, each in its own vocabulary's casing. One spelling for both is part of 4.0: one UPPER_SNAKE_CASE vocabulary for error, reason and outcome codes, defined per protocol and checked by the build #8885.media-buy/commercial-terms.jsondescription, theterms_digestdescription incore/canonical-proposal.json, and theproposaldescription ingovernance/check-governance-request.json.buy_products(the seller side),decline_proposals,check_governance, and a line in pricing models so "ignore unrecognized fields inprice_breakdown" doesn't read as permission to accept terms carrying them.commercial-termsis held closed until 4.0 and state the acceptance rule after it. The 4.0 compatibility page is unchanged: this PR only removed the old reason there, and fix(schemas): open the 3.3 schemas that were meant to be open #8866 already had.media_buy_seller/unrecognized_terms_rejected, listed in the media-buy protocol'srequires_scenariosand gated onmedia_buy.lifecycle_toolscontainingbuy_products. The buyer'sbuy_productspurchases become the accepted proposal'scommercial_terms, so the seller is the accepting party there. A control phase first buys the product with a plain purchase and expects a MediaBuy. The rejection phase depends on it and sends the identical purchase with one added member,adcp_compliance_undefined_member, informat_option_refs[0], and expectsUNRECOGNIZED_TERMS. The name is reserved as undefined, so no conformant seller can legitimately interpret it.core/format-option-ref.jsonis open, so the request is schema-valid, and the member is the only difference between the two requests. If the control fails, the runner skips the rejection step (prerequisite_failed) instead of grading it. Nothing in the spec makes a second buy of the same product fail: the two requests use different idempotency keys, and there is no duplicate-buy rule.accept_proposalisn't covered because the buyer sends onlyproposal_idandproposal_terms_digestthere, never the terms.commercial_terms.handleBuyProductsnow rejects any purchase member the source schemas don't declare, at any depth, withUNRECOGNIZED_TERMSanderror.fieldset to its path. The walk isundeclaredMembersinserved-release-fields.tsand reuses that module's schema walk. A unit test covers an undeclared member, anextmember, and an opaquecontextmember.decline_proposalsand the compact refine decline now read their accepted reasons fromenums/proposal-decline-reason.jsoninstead of two hand-written lists that lacked the new reason.minor(new enum values and a new normative requirement).Not changed
governance/decisions/DR-0036-closed-schemas-stay-closed-within-a-major.md, which docs(governance): DR-0036 records open schemas within a major; withdraw DR-0032 and DR-0033 #8858 rewrote after this PR opened. A decision record is outside this PR.commercial-termsstays held closed until 4.0, as fix(schemas): open the 3.3 schemas that were meant to be open #8866 left it.Testing
All run in a clean worktree off
origin/mainat 0f337b4, on Node 24.21.0, before the merge of main:npm run build:schemas: passes.npm run test:schemas: passes.npm run typecheck: passes.npm run build:compliance -- --check: passes.npm run test:compliance-snippets: passes.npm run test:additive-minor: passes (enum additions are allowed in a minor release).npm run test:docs-nav,npm run check:owned-links,npm run lint:schema-links: pass.npm run test:mcp-schema-projection: passes.npm run test:storyboard-*lints: pass.node scripts/lint-error-code-drift.cjs: passes.node tests/json-schema-validation.test.cjs --fileandnode tests/snippet-validation.test.cjs --fileon each of the 9 edited docs pages: pass.node scripts/check-changeset-protocol-scope.cjs origin/mainandnpx @changesets/cli status --since=origin/main: pass, oneminorbump.npx vitest run --config server/vitest.config.ts server/tests/unit/training-agent-served-release-fields.test.ts: 6 of 6 pass./sales, in the same candidate-version mode CI uses: with the training-agent change reverted, the control step passes and only theUNRECOGNIZED_TERMScheck inreject_unrecognized_memberfails (5 of 6 steps pass). With the fix it passes 6 of 6. With the control deliberately broken (an unknown pricing option), the control fails and the rejection step is reported as skipped (prerequisite_failed), not graded.media_buy_seller/compact_direct_buy_lifecyclestill passes 8 of 8./saleshad 196 of 196 applicable storyboards clean and 1422 passing steps (floors 191 and 1400).After the merge of main (
2dc672e316):build:schemas,test:schemas,test:error-codes,test:doc-compliance-drift,test:compliance-snippets, all 23test:storyboard-*lints, andtraining-agent.test.tswithtraining-agent-served-release-fields.test.ts(834 of 834) pass. The last commit changes only the changeset; its pre-commit hook andcheck-changeset-protocol-scope.cjspass. The local pre-push storyboard matrix was skipped for this push: on this machine it fails the same way on unmodifiedmain(18da1a4559), where CI's storyboard workflow passes, so CI grades this head.Merge timing
Intended for 3.3, before the Nov 16 release candidate.