Repository navigation
feat(schema): display labels for geo targeting codes - #8966
Conversation
Targeting gains display names beside its geographic codes, in the shape geo_places already uses. geo_metros and geo_metros_exclude entries take value_labels, and core/targeting.json takes geo_value_labels for the ISO codes in geo_countries, geo_countries_exclude, geo_regions and geo_regions_exclude. Labels are diagnostic: they never resolve or apply targeting, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated schema paths require human/CODEOWNERS approval.
This is a clean, fully additive 3.3 change: adds optional geo_value_labels to targeting.json/targeting-input.json and value_labels to geo-metro.json, all under additionalProperties: true. The reviewer found no blocking or Medium findings — changeset (minor) is correct for additive optional fields, schema↔docs coherence verified, propertyNames pattern is the correct union of geo_countries/geo_regions, no new undiscriminated oneOf, no dist/** edits, and tests cover both validation branches.
However, the PR modifies files under static/schemas/source/**, which are declared under a hard, deterministic approval gate (gated_paths: true), and review_decision is REVIEW_REQUIRED — not APPROVED. Per decision-table row 2, the gate is not satisfied and the outcome must be escalate regardless of the clean diff.
Escalation reasons
- Gated paths touched without approval:
static/schemas/source/core/geo-metro.json,static/schemas/source/core/targeting-input.json,static/schemas/source/core/targeting.json— human/CODEOWNERS review required (review_decision is REVIEW_REQUIRED).
Once a CODEOWNERS/human approval lands (review_decision: APPROVED), this diff has no other trigger and would fall through to approve.
Why human review
- Gated schema files modified without approval: static/schemas/source/core/geo-metro.json, static/schemas/source/core/targeting-input.json, static/schemas/source/core/targeting.json — review_decision is REVIEW_REQUIRED, human/CODEOWNERS approval required to satisfy the hard approval gate.
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/core/geo-metro.json (modified) matches
static/schemas/source/**; static/schemas/source/core/targeting-input.json (modified) matchesstatic/schemas/source/**; static/schemas/source/core/targeting.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
|
Local results for the suites still running when I opened this: |
Every targeting field in targeting-input.json has a null branch, which targeting-null-clear.test.cjs enforces. geo_value_labels follows the same three states: omit to keep, a map to replace, null to clear labels the seller kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated schema files modified without the required human/CODEOWNERS approval.
This PR modifies three files under static/schemas/source/** (geo-metro.json, targeting-input.json, targeting.json), which fall under a hard, non-overridable approval gate (gated_paths: true). The current review_decision is REVIEW_REQUIRED, not APPROVED, so the gate is NOT satisfied (decision table row 2).
The reviewer's delta pass found no Critical/High/Medium findings: targeting-input.json makes geo_value_labels nullable via anyOf [$ref, null], matching the three-state dimension pattern used by sibling fields; the docs at targeting.mdx:9 are coherent with the schema; the null branch bypasses the $ref so no x-adcp-validation conflict arises. The diff is mechanically clean and a changeset is present (.changeset/geo-value-labels.md). But a clean diff cannot clear the hard approval gate — ratification of schema changes is a human act.
Escalation reasons:
- Gated schema files modified (
static/schemas/source/core/geo-metro.json,targeting-input.json,targeting.json) whilereview_decisionisREVIEW_REQUIRED— human/CODEOWNERS approval required to satisfy the hard approval gate.
Once a CODEOWNERS/human approval is recorded (review_decision: APPROVED), this PR falls through to the normal table and, given no blocking findings, is approvable.
Why human review
- Gated paths unsatisfied: static/schemas/source/core/geo-metro.json, static/schemas/source/core/targeting-input.json, static/schemas/source/core/targeting.json modified while review_decision is REVIEW_REQUIRED (not APPROVED) — human/CODEOWNERS approval required for the hard approval gate.
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/core/geo-metro.json (modified) matches
static/schemas/source/**; static/schemas/source/core/targeting-input.json (modified) matchesstatic/schemas/source/**; static/schemas/source/core/targeting.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
|
Ruling (Brian O'Kelley, 13 November 2026): |
|
Admin-merged at Brian O'Kelley's direction ("merge #8966 once it is green", 13 November 2026). Head |
…es, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(reference): bring the 3.3 release docs to 3.3.0-rc.0 Bring the release notes, What's new, the 3.2 to 3.3 migration guide, the prerelease program page, Versions, and the 3.3 rows of Choose your SDK to the first release candidate. The prerelease page keeps its 3-3-beta URL and is retitled, as the 3.2 page was at its RC. rc.0 joins the checkpoint and wire-pin tables with the 3.3-rc documentation selector. Cover the 2026-11-09 decision to open the schemas that were closed by accident, and the #8501 triage that followed it: which beta fields stay in 3.3, which leave because they sit on deprecated tasks or would change a signed term, and which move. The migration guide lists every field; the other pages summarize it. Record boolean overlay demographics as deprecated. Leave the lines that #8866 rewrites alone, and fix the "closed schemas stay closed" wording it does not touch: the Send-only-to-3.3-peers intro and proposal-flow correction in the 3.2 to 3.3 guide, the 3.1 to 3.2 guide, optimization reporting, and the daily-budget spec. Describe deprecated 3.3 features as expected to be removed in 4.0, with 3.3 supported for a window after 4.0 GA, instead of the six-month notice promise. Record @adcp/sdk 17.0.0-beta.22 and Python adcp 10.0.0b15 on beta.5, Python adcp 9.6.2 with the A2A input fix on the 3.2 line, no SDK on rc.0 yet, and no Go or Java support for 3.3. Content that depends on unmerged PRs or on the rc.0 cut carries a {/* depends on ... */} marker (HTML comment in the spec markdown) so it can be re-checked before the cut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): state the 12-month 3.3 support window after 4.0 GA Replace "length to be confirmed" in the 3.2 to 3.3 Deprecations intro with the decided window: 3.3 stays supported for at least 12 months after 4.0 GA. Point the marker at #8858, which carries the policy change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe the commercial terms as held closed until 4.0 Konstantin's review of #8866 rejects signed commercial terms as a structural reason to keep a schema closed: terms_digest covers open members at every depth, including ext. Describe the nodes inside commercial_terms, and proposal-budget-constraint, as held closed until 4.0 in the triage tables and summaries, the release notes, What's new, Versions, and the daily-budget spec, and drop the claim that the digest stops a 3.2 buyer from accepting a term it ignored. The triage reason is renamed from signed meaning to held closed until 4.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): prerelease pins, unpinned discovery, and anonymous capabilities A 3.3 beta reader pinned get_adcp_capabilities to 3.3-beta.5 against a 3.0-only seller, got VERSION_UNSUPPORTED, and never retried. State how each side avoids that (approved by Brian for the 3.3 RC docs): - Versioning, pre-release pins: a buyer MUST send a prerelease adcp_version only to a peer whose supported_versions lists that exact value, SHOULD discover unpinned, and SHOULD retry unpinned or at a listed version on VERSION_UNSUPPORTED, matching the existing retry SHOULD and the error code's recovery hint. Mirrored on the 3.3 prerelease page. - Authentication: a seller SHOULD serve get_adcp_capabilities without credentials; a SHOULD in 3.3 and a MUST in 4.0. - MCP guide: a gateway that allow-lists JSON-RPC methods SHOULD let server/discover, initialize, and tools/list through without credentials. - Release docs: a migration-guide section with buyer and seller checklist rows, a What's new and release-notes bullet, and the 4.0 item in v4-compatibility's not-yet-checked list. Docs only; no schema changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): follow #8866 and the other rc.0 merges in the 3.3 release docs After rebasing onto main with #8866 merged: - Take #8866's wording for the boolean form of demographics in the migration guide's Deprecations section, and align the release notes and What's new with it (#8778 tracks the 4.0 removal). - 3.2.10 shipped without the schema opening, so say "the next 3.2.x patch (#8864)" and "3.2.10 and earlier", including in #8866's Schemas-are-open-by-default bullet. - Drop the dependency markers #8866 satisfied, and retarget the rest. - Cover the other changes merged for rc.0: origin-only authorized_agents URLs (#8939), declared-option creative conformance (#8941), TMP cache isolation (#7446), creative.supports_registry_policy_enforcement (#8857), 3gp/mpeg/m4v containers (#8668), carousel card_image_sizes (#8937), and the loosened URL patterns (#8792). - Refresh the in-review table against the 3.3.0 milestone on 2026-11-12, and remove the stray duplicate table header it carried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(sdk): keep the SDK matrix on the installed @adcp/sdk prerelease tests/sdk-runtime-compat.test.cjs requires Choose your SDK to name the @adcp/sdk prerelease this repository installs (17.0.0-beta.21), and no other 17.0.0 prerelease. Revert the TypeScript row and install command to beta.21 and drop the npm beta dist-tag label, which now points at beta.22. The release pages keep recording that beta.22 also bundles beta.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8858 and #8864 markers in the 3.3 release docs - #8858 merged: drop its markers on the 3.3 support window and the daily-budget spec. - #8864 merged into 3.2.x, so the schema opening ships in 3.2.11: say "3.2.11 (#8864)" instead of "the next 3.2.x patch", with one marker per page on the 3.2.11 release itself (Version Packages #8942). - target_audiences on list_products offer_filters is decided: it stays as it is in 3.3, and any change is 4.x, so media_buy.audience_evidence_targets has no 3.3 surface once the get_products and create_media_buy copies leave. - The available_installment_statuses move is a 3.3 RC item; its markers now point at c4777ebd's PR, and the release-notes installment_lifecycle row carries a marker to move to the canonical location when it lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): point the available_installment_statuses markers at #8957 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8762 and #8957 markers in the 3.3 release docs #8762 (sla-window back to its 3.2 shape, business time on the creative review SLA) and #8957 (available_installment_statuses on the canonical reporting capabilities) merged; #8762's own release-doc lines arrive with the rebase. Drop both from the dependency markers, name the canonical product's reporting_capabilities in the release-notes media_buy.installment_lifecycle row, and refresh the #8501 row of the in-review table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8758 markers in the 3.3 release docs #8758 merged: the get_products and sync_creatives assignments[] withdrawals and the execution_readiness move to list_products are in main. Drop it from the dependency markers, remove the #7659 note's marker, move it to merged in the in-review table, and say that the deprecated assignments[] row rejects trackers and landing_page_url by name, so a stale sender is rejected there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8767 markers and describe the withdrawn surfaces #8758 and #8767 merged and handed their release-doc text to #8883. Drop #8767 from the dependency markers, and bring the lines that still described withdrawn surfaces as current in line with main: - media_buy.price_adjustments and media_buy.audience_evidence_targets are withdrawn at rc.0 and no longer registered (experimental table, feature index, What's new, migration guide). - execution_readiness is on list_products; lineage is on buy_products and accept_proposal; collection cards leave get_products; the creative start gate is set through control_media_buy; counting_mechanisms leaves measurement_terms; assignment trackers and landing pages stay only on sync_creatives assign operations. - Point the price-adjustment and target-audience links at the withdrawn sections; refresh the #8501 row of the in-review table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): add the rc.0 installment experiments, with dependency markers Two experimental, capability-gated rc.0 items are in progress: installment selection through refine_proposals (media_buy.installment_refinement, (media_buy.installment_creative_assignment, #8968). Add them to the feature index, the experimental surfaces table, What's new, and the migration guide, each behind a marker until its PR merges. Note on every "installment selection withdrawn to 4.0" passage that 3.3 now covers the request side, while the signed purchases[].installments[] stays a 4.0 item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): cover #8884's signed-terms acceptance rule in the rc.0 docs #8884 states that accepting signed commercial terms binds every member terms_digest covers, with UNRECOGNIZED_TERMS and the unrecognized_terms decline reason. Add it to the rc.0 checkpoint and feature index, the behavior changes, What's new, and the migration guide (a required-behavior section, checklist row 52, and its storyboard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8972, per-installment creative assignment, in the rc.0 docs #8968's PR is #8972: installment_refs on sync_creatives assign and replace operations, read back on get_media_buys and list_creatives, rejected by name on unassign and merge, VALIDATION_ERROR for a ref outside the bought installments and CREATIVE_DEADLINE_EXCEEDED past change_cutoff. Correct the RFC-based placeholder and point its markers at #8972. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8974, installment refinement, in the rc.0 docs refine_proposals, unsatisfied_installment_changes with a reason, the installment_changes value in proposal_refinement.supported_dimensions, and a seller answer that buys a product whose installments are the chosen set. Correct the RFC-based placeholder, link the new anchors, and point its markers at #8974. Drop the sentence in the 4.0 page's What stays in 3.3, which #8974 rewrites itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): cover #8793 and #8458 in the rc.0 docs #8793: Reliable Reporting managed delivery holds no buyer secret, row push is reporting_webhook, and the experimental https_put file_transfer transport. #8458: media_buy.supported_delivery_types. Add both to the rc.0 checkpoint and feature index, the behavior changes and the reporting_delivery experimental row, What's new, and the migration guide (an experimental notice and checklist rows 53 and 54), and mark #8149 as shipped in the in-review table. #8458's own optional-declaration lines are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the 3.2.11 markers 3.2.11 published on 2026-11-13 with the 3.2 schema opening (#8864), so the release pages' 3.2.11 statements no longer wait on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8974 markers #8974 merged as a7af517. Drop its markers, and narrow the shared installment markers to #8972. The migration guide no longer says core/installment-change-set.json and the installment_changes dimension are gone: they leave after beta.1 and return in rc.0 under media_buy.installment_refinement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8983, report definitions at contract_version 1.2, in the rc.0 docs #8983 (#8971) adds Reliable Reporting report-definition contract_version 1.2: a definition whose dimensions include media_buy_id must include package_id, account-level definitions are exempt, and callers pinned below 3.3 get 1.0 or 1.1 offerings. Add it to the release notes (checkpoint row, feature index, behavior change, experimental table), What's new, and the migration guide (checklist row 55 and a section), with markers until it merges. The checkpoint row also gains #8974 and #8972, which it was missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8972 markers #8972 merged as e903ee6. Drop its markers and narrow the shared ones to #8983. The migration guide adds #8972's capability rule: buyers send installment_refs only to a seller that lists the feature id, and a seller without it rejects the field with UNSUPPORTED_FEATURE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8983 markers #8983 merged as 39334ab. Drop its seven markers, and state the serving rule as a MUST everywhere it appears: a seller serves callers pinned below 3.3 only 1.0 or 1.1 report-definition offerings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): add 3.3.0-beta.6 ahead of rc.0 beta.6 is cut on main today for SDK testing over the weekend, and rc.0 stays on Monday. Add beta.6 to the checkpoint, SDK-posture and version-string tables and to Versions, say rc.0 follows seven betas, and note that everything in "New in rc.0" first shipped in beta.6 except the prerelease-pin and anonymous-discovery guidance. beta.6's date carries a marker until it publishes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8966, display labels for geo targeting codes, in the beta.6 and rc.0 docs #8966 merged as aa94f36 and ships in beta.6. Add it to the beta.6 checkpoint row and the beta.6 and rc.0 feature index, to What's new (smaller additions), and to the migration guide: checklist row 56, a send-only-to-3.3-peers row for geo_value_labels, and a section under Adopt by capability. Labels never resolve or apply targeting, sellers never reject a request because they are present, and equality and readback compare codes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the beta.6 date markers 3.3.0-beta.6 published on 2026-11-13 (tag v3.3.0-beta.6 at bf4aa6d, from Version Packages #8801). The pages already give that date, so drop the four markers that held it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): describe #8995, social distribution identifier types, in the rc.0 docs #8995 (#8992) adds eight distribution-identifier-type values for Instagram, Facebook, Snapchat and X: a canonical ID and a handle alias for each, with handles compared as @ plus the lowercased name. It lands after beta.6, so add it to the rc.0 checkpoint rows, the feature index, What's new, and the migration guide's send-only enum values, with markers until it merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the #8995 markers and fold #8997 into the rc.0 docs #8995 merged as 15b0c46, identical to the version these pages describe, so its seven markers go. #8997 (declared sync_creatives assignment operations) merged after beta.6 with its own release-doc lines. The rebase kept this branch's side of the overlapping hunks, so restore #8997's text: its migration checklist row (now row 57, after this PR's rows 45 to 56), the release-notes Creative bullet, and the What's new adopter rows. Its migration and What's new sections and its behavior-change bullet came through unchanged. As post-beta.6 content, it joins the rc.0 rows and the "new in rc.0" notes. #8986 (training agent refuses installment_refs) is server-only with no changeset, so the rc.0 rows don't list it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): add #8970 and the other post-beta.6 merges to the rc.0 docs #8970 (merged as 145ba50) asks get_media_buy_delivery sellers to return at least one by_package row, one per package, and to omit a buy they can't report rather than return an empty by_package. by_package: [] stays valid in 3.x, and minItems: 1 is proposed for 4.0 in #8973. Add a behavior-change bullet, a What's new sentence, migration checklist row 58, and #8973 under v4-compatibility "Changes not checked yet". #8996, #9001 and #8934 also merged after beta.6. #8996 and #9001 wrote their own release-doc text, which came through the rebase unchanged. Add all four to the rc.0 rows and the "new in rc.0" notes, and split the release-notes feature index into a beta.6 bullet and an rc.0 bullet. Refresh the in-review table to 2026-11-14: #8149, #8107 and #8856 (merged as #8934) closed, #8943 has #9011, and #9014 and #8998 (#9013) are new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): write #8854 up as in review, not in rc.0 #8854 (withdraw metric_id, restore evaluator as a deprecated x-entity value; #8501 entries 6 and 26) has not merged by Sunday 2026-11-15, with changes requested. Per the Sunday rule, describe it as in review and not in rc.0, and drop its eight markers. rc.0's schemas still carry metric_id on the canonical and legacy performance standards and on required_performance_standards, and still lack evaluator. The triage decision stands, so metric_id stays listed as leaving 3.3, with a note that the withdrawal is in review, and evaluator leaves the "stays in 3.3" lists. signing_profile is no longer part of #8854 and stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): take #9018's beta.6 SDKs and test-agent preview, and add #9011 and #9017 #9018 (6c34d90) bumped @adcp/sdk to 17.0.0-beta.26 and moved the public test agent's preview to 3.3-beta.6. The rebase kept this branch's side of the overlapping lines, so apply its facts here: 17.0.0-beta.21 to beta.23 and Python adcp 10.0.0b13 to 10.0.0b16 support beta.5, 17.0.0-beta.24 and later and 10.0.0b17 and later support beta.6, Choose your SDK names beta.26 and 10.0.0b17, the test agent serves 3.3-beta.6, and SDK-backed testing stays on beta.6 until an SDK bundles rc.0. #9011 and #9017 merged after beta.6 with their migration-guide text. When several authorized_agents entries match one agent, its scope is the union, and a signing_keys pin holds only if every matching entry pins. Add them to the rc.0 rows, the rc.0 feature index and What's new. The in-review table moves to 2026-11-15: #8943 and #9016 closed, and #9013 is out of draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): fold #8989, #9007 and the last post-beta.6 changesets into the rc.0 docs #8989 renames three experimental values to their counterparts' spelling, with no alias: input_required to input-required (execution_readiness), click_through to clickthrough (live_updates), underdelivery to under_delivery (delivery_projection). Add a migration section with the old and new spellings, checklist row 59, a release- notes behavior change, a What's new bullet, and a "Renamed in rc.0" row on the prerelease page, and fix the two input_required spellings that the rebase kept from this branch. #9007 lets campaign governance accept a sync_plans plan that omits human_review_required, and states two sync_plans rules: checklist row 60, a release-notes bullet, and a What's new sentence. Every changeset pending for rc.0 is now in the rc.0 rows and notes, including the compliance gates #9013 and #9005 and #9018's beta.6 test-agent preview. Choose your SDK takes main's @adcp/sdk 17.0.0-beta.28. The in-review table moves to 2026-11-16: #8998 closed (#9013), and #8987 is new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): resolve the rc.0-cut markers rc.0 is cut today, 2026-11-16, and the pages already give that date, so drop the five date markers. Write the three post-cut markers forward: SDK prereleases that adopt 3.3.0-rc.0 follow within days of the cut, Choose your SDK gains their rows when they publish, and the test-agent preview moves to rc.0 once an @adcp/sdk prerelease negotiates it. A follow-up PR on main adds the real versions after rc.0 publishes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Targeting carries geographic codes, never names:
geo_metrosvalues like"501",geo_regionslike"US-CA". Anyone showing a package, proposal or audit log to a person has to look every code up before they can write "New York" or "California".geo_placesalready solves this withvalue_labels, a map from code to name that is diagnostic only. This PR uses the same shape for metros, countries and regions, so a targeting object can carry its own display names.core/geo-metro.json(used bygeo_metros) and thegeo_metros_excludeentries gain optionalvalue_labels, with the same definition andx-adcp-validationkey rule asgeo-place-area.json:{ "system": "nielsen_dma", "values": ["501"], "value_labels": { "501": "New York" } }.core/targeting.jsongains one map for all four ISO fields,geo_value_labels:{ "DE": "Germany", "US-CA": "California" }. Its keys must be ISO 3166-1 or 3166-2 codes (propertyNames), and each key must appear ingeo_countries,geo_countries_exclude,geo_regionsorgeo_regions_exclude(a newmap_keys_subset_of_arraysvalidation rule, since draft-07 can't express it). ISO 3166-1 and 3166-2 codes can't collide, so one map is enough.core/targeting-input.jsonaccepts it with the same three states as a dimension (omit to keep, a map to replace,nullto clear labels the seller kept), whichtests/targeting-null-clear.test.cjsrequires of every targeting field.Postal areas are left out. Postal codes are their own labels in practice, and nobody has asked.
The rules
Labels are not a targeting dimension. The targeting guide's Geographic Restrictions section now says so normatively:
"California"ingeo_regions) is still invalid.geo_value_labelsto a seller on a version before 3.3. Rejected targeting dimensions says a seller rejects a dimension it doesn't support, and a 3.2 seller may read an unknown top-level key as one.value_labelsinside a metro entry has no such risk, because the entry schemas are open.Why now
Apostra's V3 API returns AdCP targeting on campaign and media-buy reads, and agents showing those reads to people need names. Without a protocol field, the choice is between an extra lookup call per read and a field of our own outside AdCP. We'd rather the shape be AdCP's.
Compatibility
Additive and optional on open schemas, so
lint:additive-minorshould need no baseline rows. Two points for the 3.3 release coordinator:core/targeting-input.jsonandcore/targeting.jsonare shared by the live tasks (buy_products,list_products,get_media_buys) and the deprecated ones (create_media_buy,update_media_buy,get_products), so these fields reach the deprecated tasks too, as 3.3's core gender targeting does. fix(schema): keep 3.3 additions off the deprecated create_media_buy and update_media_buy (#8501) #8767 kept task-level 3.3 additions off the deprecated tasks. If the same must hold for shared core targeting, this needs a split of the targeting schemas, and I'd rather take that ruling than guess.Testing
node tests/schema-validation.test.cjs: 36/36. The geo place test now also asserts the metro andgeo_metros_excludevalue_labelsrules, thegeo_value_labelsrule's field list, and the semantic subset check accepting and rejecting the right overlays.node tests/json-schema-validation.test.cjs --file docs/media-buy/advanced-topics/targeting.mdx: 22/22 blocks.lint:additive-minor: passes against 3.2.10 with 0 new non-additive changes.npm run typecheck,scripts/check-changeset-protocol-scope.cjs origin/main, and the pre-push checks (version sync, changeset policy, schema links, docs navigation 58/58): pass.test:unit(1284/1284) and the three checks after it passed.precommit:server-unithit its 1500-second limit on a heavily loaded shared host, after 14 tests had failed. They were timeouts and worker-spawn failures in Addie, standalone sites and training-agent tenants. The two that touch schemas or release fields,training-agent-served-release-fieldsandstoryboard-candidate-schema-root, pass when run alone (7/7). I committed with--no-verifyand am relying on hosted CI for the full server suite.test:composed,test:extensionsandtest:mcp-schema-projectionwere still running when I opened this PR; I'll add the results.🤖 Generated with Claude Code