Repository navigation
chore(release): refresh the 3.3.0-rc.0 marker for #8915 - #9054
Merged
Merged
Conversation
…s in the rc.0 docs #8915 (f4899aa) merged after the rc.0 marker. It adds a replacement for six enum positions that collide with SDK target languages and deprecates the originals: pass to passed (binary-verdict, local_verdict, the registry feed's compliance tracks status), global to all (RATE_LIMITED scope), and name to full_name (signal onboarder match_keys, on the definition and the enrichment). Both spellings are valid through 3.x, and 4.0 removes the originals. Send a replacement only to a peer served 3.3 or later; published files keep the original. Add it to the rc.0 rows, the release-notes rc.0 bullet, status line and deprecations, What's new, migration checklist row 61, a migration section with old and new values, the send-only-to-3.3-peers table, and the deprecations intro. #8915's v4-compatibility text is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#8915 (reserved-word-enum-replacements.md) merged after the rc.0 marker (#9050), so the Release run's promote check would reject #9009 with "Pending changesets do not match the reviewed RC promotion marker". Regenerate .changeset/rc-promotion.json with npm run promote:rc -- --prepare. It folds all 17 pending changesets into 3.3.0-rc.0, each with its sha256: the 15 #9050 listed, reserved-word-enum-replacements.md, and this PR's rc0-docs-reserved-word-enums.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — docs-only refresh with verified schema↔docs coherence.
This PR documents the already-merged #8915 (reserved-word-safe enum replacements) for 3.3.0-rc.0 and refreshes the RC promotion marker. It touches only docs and changeset files (38 additions, 7 deletions across 7 files).
What I checked:
- Schema↔docs coherence at all six enum positions:
pass→passed(binary-verdict, get_media_buy_artifacts local_verdict),global→all(rate-limited scope, with correctagentdisambiguation note),name→full_name(signal-definition onboarder.match_keys) — all claims match the schema. - Changeset scope is correct for a docs refresh (patch).
- The independently-verifiable marker sha256 for #8915's changeset matches exactly.
No Critical/High/Medium findings. The high_risk flag is driven solely by docs/reference/** (modified) matches; per the arbiter rules, a modification with no medium-or-higher finding is presumed safe and does not escalate on the flag alone. gated_paths is false, no no-auto-approve team match, no prior decision. Decision table rows 1–8 do not fire → row 9 approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8915 (reserved-word-safe enum replacements,
reserved-word-enum-replacements.md) merged at 13:30Z, after the rc.0 promotion marker (#9050,7c2d226b1c). That marker snapshots 15 changesets and omits #8915's, so the Release run's promote check would throw "Pending changesets do not match the reviewed RC promotion marker", and #9009 could not become3.3.0-rc.0. This PR documents #8915 for rc.0 and refreshes the marker. It is based onmainat36ee5f9900.Commits
Release docs for feat(schema): add reserved-word-safe replacements for 6 enum positions and deprecate the originals (#8791) #8915. Six enum positions get a replacement that no SDK target language reserves. The originals are deprecated, not removed, and both spellings are valid through 3.x:
passpassedenums/binary-verdict.json,get_media_buy_artifactslocal_verdict, and the registry feed's compliancetracksstatusglobalallRATE_LIMITEDdetailsscopenamefull_nameonboarder.match_keys(core/signal-definition.json,core/signal-definition-enrichment.json)A replacement goes only to a peer served 3.3 or later, and published files such as
adagents.jsonkeep the original through 3.x. The docs changes:feat(schema): add reserved-word-safe replacements for 6 enum positions and deprecate the originals (#8791) #8915's own
v4-compatibility.mdxtext is unchanged. A patch changeset,rc0-docs-reserved-word-enums.md, covers the docs.Marker.
.changeset/rc-promotion.jsonwas regenerated:git rm, thennpm run promote:rc -- --check, then--prepare. It now folds 17 pending changesets into3.3.0-rc.0, each with its sha256: the 15 from chore(release): prepare AdCP 3.3.0-rc.0 #9050,reserved-word-enum-replacements.md, andrc0-docs-reserved-word-enums.md.promote:rc -- --checkpasses against it.maingained one more commit after #9050, #9052 (36ee5f9900, training agent). It has no changeset and doesn't change the marker. If anything with a changeset reachesmainbefore this merges, the marker has to be prepared again.Checks run
test:docs-nav,check:owned-links,lint:schema-links, andcheck-changeset-protocol-scope.cjs origin/main.promote:rc -- --check(17 changesets).test:unit(1284/1284), the dynamic-import, format-identity and callApi guards, andtypecheck. Committed withHUSKY=0under the standing approval for docs-only release commits through the RC;precommit:server-unitwas skipped for host load, and CI is the gate.🤖 Generated with Claude Code