Migrate from CJS to ESM and from Jest to Vitest ( claude for comparison )#99
Open
purplecabbage wants to merge 1 commit into
Open
Migrate from CJS to ESM and from Jest to Vitest ( claude for comparison )#99purplecabbage wants to merge 1 commit into
purplecabbage wants to merge 1 commit into
Conversation
- add "type": "module" and convert all src/bin to import/export - rename bin/run -> bin/run.js for ESM resolution - bump fs-extra ^9 -> ^11 - swap jest/eslint-plugin-jest for vitest/@vitest/coverage-v8/@vitest/eslint-plugin - add vitest.config.js, replace test/jest.setup.js with test/vitest.setup.js - rewrite fingerprint forge mocking using vi.resetModules + vi.doMock/doUnmock (vitest has no isolateModules) - add index command test to keep coverage at 100% Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 PR Reviewer
This is a clean migration from CommonJS/Jest to ESM/Vitest. The changes are well-structured, consistent, and follow ESM best practices throughout. The test refactoring correctly handles the lack of isolateModules in Vitest using vi.resetModules() and dynamic imports. No significant issues found.
✅ LGTM! This PR looks good to merge.
💡 How to re-trigger
Comment /review or /pr-reviewer on this PR
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: