Repository navigation
fix(design-data): refine size token taxonomy - #1503
Open
NateBaldwinDesign wants to merge 33 commits into
Open
NateBaldwinDesign wants to merge 33 commits into
NateBaldwinDesign wants to merge 33 commits into
Conversation
🦋 Changeset detectedLatest commit: 86362ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
🎨 Token Changes ReportTokens Changed (457)Original Branch: Newly Deprecated (278)
Newly "Un-deprecated" (4)
Added (149)
Updated (26)Added Properties (14)
Updated Properties (12)
This comment was automatically generated by the token diff tool. 🤖 |
Contributor
Run report for 86362ee7Total time: 8m 55s | Comparison time: 24m 31s | Estimated savings: 15m 35s (63.6% faster)
Expanded report
Changed files |
Regenerate packages/tokens/src from the cascade source in packages/design-data to include this PR's size token taxonomy work, and fix three cascade data bugs surfaced by the regeneration: - relationships/field.json: remove the deprecated field-width-* aliases that duplicated the legacyKey now owned by the new layout-component size tokens (confirmed with Nate Baldwin over Slack that the legacy names are reused intentionally, not an accidental collision). - tokens/layout-component.tokens.json, tokens/layout.tokens.json: move 82 non-component-scoped tokens (banner-*, base-height-*, container-*, size-*, thickness-size-*) out of layout-component into layout, where shared/foundation tokens belong. - relationships, tokens: add the missing lifecycle deprecation to 149 scale-set sibling entries (mobile variants) left inconsistent with their already-deprecated desktop counterpart. packages/tokens/src now regenerates cleanly: 2650 tokens across 91 files, all tokens:test checks passing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6 of 10 tasks
Member
Snapshot release publishedA Current resolved version: What's in it
Also fixed the snapshot-release workflow itself along the way (it was using a stale cc @NateBaldwinDesign for visibility since this touches the field-width naming decision from Slack. |
… fixes CI's check-data-bump rule requires a pending changeset bumping @adobe/design-data-wasm whenever packages/design-data/tokens/*.tokens.json changes. The reconcile-field-width-legacy-keys changeset touched layout-component.tokens.json and layout.tokens.json but only bumped @adobe/spectrum-design-data; add the design-data-wasm patch bump so the embedded wasm dataset snapshot picks up these fixes too. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Erroneously added in the original PR. Removed since 'bar-thickness-*' cover their intended purpose
Removed multiple size definitions for indicators from layout-component.tokens.json as they were not intended to be introduced in original PR
Removed deprecated lifecycle and rationale fields from visual size tokens. Design decided not to deprecate
No longer has a replacement value
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Attach file and source locations to relationship JSON parse errors. Cover diagnostic behavior with regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Regenerate legacy output and remove dangling replacement pointers. Include canonical design data in the legacy parity task cache inputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Spectrum tokens snapshot publishedA refreshed npm i @adobe/spectrum-tokens@size-token-taxonomyThe What's in itThis snapshot includes the token changes through
The snapshot was published from the disposable The tag can move to a newer snapshot after a refresh. To keep testing this exact build, install |
Member
Size taxonomy variables are now in the Figma POCThe variables have been written to S2 / Web (Size variables POC). They correspond to Same canonical sourceI regenerated The Figma exporter currently consumes that generated legacy projection. What landed
Post-write readback confirmed every emitted variable's name, collection, type, WEB code syntax, and mode values, including alias targets. Numeric comparisons used an absolute tolerance of Examples: Deliberate POC boundaries
Verification
No token data, versions, changesets, or concurrent local monorepo changes were edited. Skipped composites (58)
Unresolved aliases (11)
Unsupported schema (1)
Unparseable values (7)
Retained Figma-only variables in .Color theme (104)
Retained Figma-only variables in .Platform scale (58)
Newly deprecated keys retained in the POC (282)
|
6 of 10 tasks
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Resolve moon.yml and layout.json conflicts; use alias.json $schema for visual-size tokens that reference size-scale tokens. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Snapshot refresh + Figma POC republishnpm snapshot (dist-tag
Figma POC: https://www.figma.com/design/6VgZUC8QxFDxsHWD0Jdjfj/ (exported with
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…p sets Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Snapshot release and Figma POC updateBuilt from npm snapshot (dist-tag
CI fixes in this update
Figma variables (S2 - Web - Size variables POC), exported from
|
NateBaldwinDesign
marked this pull request as ready for review
November 10, 2026 17:28
Collaborator
Author
|
@GarthDB FYI the RFC for this work has been approved so from a design side we're ready to merge. The conflict that exists with button is about a size token (component-specific) that we want to replace with an alias and deprecate. It's not clear to me looking at the diff where or how to maintain that deprecation with all the new data that's been added to that component relationship json. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Size token refinements from SDS-16083 size phase.
Related Issue
SDS-16264
Motivation and Context
See full motivation and context here
How Has This Been Tested?
This PR is in draft so that we can publish a Snapshot release in order to allow further testing.
Screenshots (if appropriate):
Types of changes
Checklist: