Skip to content

docs(menu-separator): phase 4 accessibility - #6888

Closed
blunteshwar wants to merge 3 commits into
menu-separator-migrationfrom
menu-separator-phase-4-a11y
Closed

blunteshwar wants to merge 3 commits into
menu-separator-migrationfrom
menu-separator-phase-4-a11y

Conversation

@blunteshwar

Copy link
Copy Markdown
Contributor

Description

Phase 4 (accessibility) of the swc-menu-separator gen2 migration. Targets the menu-separator-migration feature branch. Stacked on the Phase 3 PR (#6887), so the diff includes earlier phases until they merge.

The accessibility analysis prescribes only role="separator" on the host, no slot, no accessible name, no value semantics and no focus stop. Phase 3 already implemented that in MenuSeparatorBase, so this phase has no TypeScript change.

  • Marks the semantics checklist item done in the migration plan.
  • Replaces the analysis note "confirm attribute timing in source" with the confirmed behavior (connectedCallback).

Still open for later phases:

  • Contrast of the line against the menu background (WCAG 1.4.11) is checked in the styling phase.
  • "Not focusable; roving focus skips it" is verified in the testing phase, together with the menu.

Motivation and context

Closes out the accessibility requirements that the analysis assigns to the element itself.

Related issue(s)

  • Epic SWC-2668

Screenshots (if appropriate)

N/A


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Validation

  • npx prettier --check on the menu-separator docs: passed.
  • No code changed in this PR. Behavior is covered by the Phase 3 build and the Phase 6 tests.

@changeset-bot

changeset-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a4ddd63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6888

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@blunteshwar

Copy link
Copy Markdown
Contributor Author

Docs-only and consistent with the a11y analysis. Minor: the checklist ticks the role item, but nothing yet verifies it inside a real swc-menu (focus skipping, parent role inspection). That is correctly deferred, but please keep those items unticked until swc-menu-item lands.

@blunteshwar

Copy link
Copy Markdown
Contributor Author

Combined into #6893.

@blunteshwar blunteshwar closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant