[blunteshwar]

Description

Phase 8 (review) of the swc-menu-separator migration. Stacked on #6891 (Phase 7) and targets the menu-separator-migration feature branch, so the diff includes earlier phases until they merge.

Epic: SWC-2668.

• yarn lint:gen2 passes.
• Ticks the review items in the migration plan.

Open items

• Q3 (container height token update), Q4 (breaking-change tickets, 1st-gen deprecations), Q5, Q7, Q9 remain open in the plan.
• Contrast (1.4.11), keyboard and screen reader testing, VRT, and the menu-dependent tests and stories wait on swc-menu-item and swc-menu-group.
• The status table has no menu-separator row, so it was not updated.
• Peer sign-off is pending.

Validation

• yarn lint:gen2: passed
• yarn workspace @spectrum-web-components/gen2 build: passed (Phase 7)
• npx vitest --run --project storybook menu-separator: passed (Phase 6)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3581e7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[blunteshwar]

No code issues. Notes: the plan now ticks "PR created" with a hard-coded PR range, which will go stale. The status table (01_status.md) still has no menu-separator row, so the "Status table updated" item rightly stays unticked, and someone needs to decide whether the table's columns apply to this component. Peer sign-off is outstanding.

[github-actions]

📚 Branch Preview Links

• Storybook (Gen2, dev mode)
• Storybook (Gen2, prod mode)
• Documentation Site (Gen1)
• Storybook (Gen1)

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• Spectrum | Light | Medium | LTR
• Spectrum | Dark | Large | RTL
• Express | Light | Medium | LTR
• Express | Dark | Large | RTL
• Spectrum-two | Light | Medium | LTR
• Spectrum-two | Dark | Large | RTL
• High Contrast Mode | Medium | LTR

Deployed to Azure Blob Storage: pr-6892

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.