Fix spendInMicroCurrency and bidAmountMicro to use 64-bit long type#2133
Open
ejsuncy wants to merge 1 commit intoadobe:masterfrom
Open
Fix spendInMicroCurrency and bidAmountMicro to use 64-bit long type#2133ejsuncy wants to merge 1 commit intoadobe:masterfrom
ejsuncy wants to merge 1 commit intoadobe:masterfrom
Conversation
Micro currency fields (amount * 1,000,000) can easily exceed the 32-bit integer ceiling of 2,147,483,647. Add meta:xdmType: long to both xdm:spendInMicroCurrency and xdm:bidAmountMicro to prevent overflow errors at real-world spend values. Fixes adobe#2132 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the change intends to do
Fixes an integer overflow bug in the Core Paid Media Cost Metrics field group.
xdm:spendInMicroCurrencyandxdm:bidAmountMicrowere defined astype: "integer"withoutmeta:xdmType, causing the platform to treat them as 32-bit integers (max 2,147,483,647). Since micro currency values are computed asamount × 1,000,000, even a ~$2,437 spend overflows and produces an ingestion error.This change adds
"meta:xdmType": "long"to both fields, explicitly declaring them as 64-bit integers.Breaking changes
None — this is a widening type change (Int32 → Int64). Existing valid values remain valid.
Fixes #2132