fix: history not working due to a failed getDistance function from geolib#186
Merged
aeharding merged 2 commits intoaeharding:mainfrom May 2, 2026
Merged
fix: history not working due to a failed getDistance function from geolib#186aeharding merged 2 commits intoaeharding:mainfrom
aeharding merged 2 commits intoaeharding:mainfrom
Conversation
…by external package. Removed the package and added a new getDistance function.
aeharding
changed the title
- Extract haversine getDistance into src/helpers/geo.ts with a LatLon interface so it can be reused outside user storage. - Fix findLocation, which passed GeolocationCoordinates (latitude/ longitude) to a function typed for UserLocation (lat/lon), causing a TS error and NaN distances at runtime. - Add unit tests for getDistance. - Reformat storage.ts to satisfy prettier.
Owner
|
Great catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed this by removing the package all together and simply adding a haversine distance formula. Tested and don't find any issue of locations being added to the list twice which seemed to be the goal of this distance check.